oxmc/libgtop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stat () first and don't make any unnecessary noise in case of EACCES.

Browse Source
This commit is contained in:
Martin Baulig
2000-04-24 13:37:37 +00:00
parent a40a438ec8
commit 0ff66c2eaa
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
sysdeps/linux/proccwd.c
View File

@@ -60,6 +60,19 @@ glibtop_get_proc_cwd_s (glibtop *server, glibtop_proc_cwd *buf, pid_t pid)
sprintf (fn, "/proc/%d/cwd", pid); sprintf (fn, "/proc/%d/cwd", pid);
if (stat (fn, &statb)) {
/* If we can't even stat () than we can't readlink (). */
if (errno != EACCES) {
/* Don't make too much unnecessary noise here. */
glibtop_warn_io_r (server, "stat (%s)", fn);
}
return retval;
}
buf->device = statb.st_dev;
buf->inode = statb.st_ino;
buf->flags = _glibtop_sysdeps_proc_cwd_stat;
len = readlink (fn, buffer, BUFSIZ-1); len = readlink (fn, buffer, BUFSIZ-1);
if (len < 0) { if (len < 0) {
@@ -72,17 +85,7 @@ glibtop_get_proc_cwd_s (glibtop *server, glibtop_proc_cwd *buf, pid_t pid)
retval = glibtop_strdup_r (server, buffer); retval = glibtop_strdup_r (server, buffer);
buf->size = len+1; buf->size = len+1;
buf->flags = _glibtop_sysdeps_proc_cwd; buf->flags |= _glibtop_sysdeps_proc_cwd;
if (lstat (fn, &statb)) {
glibtop_warn_io_r (server, "lstat (%s)", fn);
return retval;
}
buf->device = statb.st_dev;
buf->inode = statb.st_ino;
buf->flags |= _glibtop_sysdeps_proc_cwd_stat;
return retval; return retval;
} }