oxmc/free-file-sync-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
main
free-file-sync-mirror/Bugs.txt
T
oxmc 29a4d4494b v 14.6
2025-12-10 14:38:26 -08:00

253 lines
9.4 KiB
Plaintext
Raw Permalink Blame History

When manually compiling FreeFileSync, you should also fix the following bugs in its library dependencies.
FreeFileSync generally uses the latest library versions and works with upstream to get the bugs fixed
that affect FreeFileSync. Therefore it is NOT RECOMMENDED TO COMPILE AGAINST OLDER library versions than
the ones mentioned below. The remaining issues that are yet to be fixed are listed in the following:
-----------------
| libcurl 8.16.0|
-----------------
__________________________________________________________________________________________________________
/lib/ftp.c
https://github.com/curl/curl/issues/1455
+ static bool is_routable_ip_v4(unsigned int ip[4])
+ {
+ if (ip[0] == 127 || //127.0.0.0/8 (localhost)
+ ip[0] == 10 || //10.0.0.0/8 (private)
+ (ip[0] == 192 && ip[1] == 168) || //192.168.0.0/16 (private)
+ (ip[0] == 169 && ip[1] == 254) || //169.254.0.0/16 (link-local)
+ (ip[0] == 172 && ip[1] / 16 == 1)) //172.16.0.0/12 (private)
+ return false;
+ return true;
+ }
- if (data->set.ftp_skip_ip)
+ bool skipIp = data->set.ftp_skip_ip;
+ if (!skipIp && !is_routable_ip_v4(ip))
+ {
+ unsigned int ip_ctrl[4];
+ if (4 != sscanf(control_address(conn), "%u.%u.%u.%u",
+ &ip_ctrl[0], &ip_ctrl[1], &ip_ctrl[2], &ip_ctrl[3]) ||
+ is_routable_ip_v4(ip_ctrl))
+ skipIp = true;
+ }
+
+ if (skipIp)
__________________________________________________________________________________________________________
/lib/ftp.c
https://github.com/curl/curl/issues/4342
- result = ftp_nb_type(conn, TRUE, FTP_LIST_TYPE);
+ result = ftp_nb_type(conn, data->set.prefer_ascii, FTP_LIST_TYPE);
__________________________________________________________________________________________________________
----------------------
| libssh2 1.11.2_DEV |
----------------------
__________________________________________________________________________________________________________
src/session.c
memory leak: https://github.com/libssh2/libssh2/issues/28
-if (session->state & LIBSSH2_STATE_NEWKEYS)
+//if (session->state & LIBSSH2_STATE_NEWKEYS)
__________________________________________________________________________________________________________
move the following constants from src/sftp.h to include/libssh2_sftp.h:
#define MAX_SFTP_OUTGOING_SIZE 30000
#define MAX_SFTP_READ_SIZE 30000
__________________________________________________________________________________________________________
-------------------
| wxWidgets 3.3.1 |
-------------------
__________________________________________________________________________________________________________
/include/wx/settings.h
Support changing system colors for proper dark mode support:
+ struct wxColorHook
+ {
+ virtual ~wxColorHook() {}
+ virtual wxColor getColor(wxSystemColour index) const = 0;
+ };
+ WXDLLIMPEXP_CORE inline std::unique_ptr<wxColorHook>& refGlobalColorHook()
+ {
+ static std::unique_ptr<wxColorHook> globalColorHook;
+ return globalColorHook;
+ }
class WXDLLIMPEXP_CORE wxSystemSettings : public wxSystemSettingsNative
{
public:
+ static wxColour GetColour(wxSystemColour index)
+ {
+ if (refGlobalColorHook())
+ return refGlobalColorHook()->getColor(index);
+
+ return wxSystemSettingsNative::GetColour(index);
+ }
__________________________________________________________________________________________________________
/src/aui/framemanager.cpp:
Fix incorrect pane height calculations:
- // determine the dock's minimum size
- bool plus_border = false;
- bool plus_caption = false;
- int dock_min_size = 0;
- for (j = 0; j < dock_pane_count; ++j)
- {
- wxAuiPaneInfo& pane = *dock.panes.Item(j);
- if (pane.min_size != wxDefaultSize)
- {
- if (pane.HasBorder())
- plus_border = true;
- if (pane.HasCaption())
- plus_caption = true;
- if (dock.IsHorizontal())
- {
- if (pane.min_size.y > dock_min_size)
- dock_min_size = pane.min_size.y;
- }
- else
- {
- if (pane.min_size.x > dock_min_size)
- dock_min_size = pane.min_size.x;
- }
- }
- }
-
- if (plus_border)
- dock_min_size += (pane_borderSize*2);
- if (plus_caption && dock.IsHorizontal())
- dock_min_size += (caption_size);
-
- dock.min_size = dock_min_size;
+ // determine the dock's minimum size
+ int dock_min_size = 0;
+ for (j = 0; j < dock_pane_count; ++j)
+ {
+ wxAuiPaneInfo& pane = *dock.panes.Item(j);
+ if (pane.min_size != wxDefaultSize)
+ {
+ int paneSize = dock.IsHorizontal() ? pane.min_size.y : pane.min_size.x;
+ if (pane.HasBorder())
+ paneSize += 2 * pane_borderSize;
+ if (pane.HasCaption() && dock.IsHorizontal())
+ paneSize += caption_size;
+
+ if (paneSize > dock_min_size)
+ dock_min_size = paneSize;
+ }
+ }
+
+ dock.min_size = dock_min_size;
__________________________________________________________________________________________________________
/src/gtk/menu.cpp
-g_signal_connect(m_menu, "map", G_CALLBACK(menu_map), this);
+g_signal_connect(m_menu, "show", G_CALLBACK(menu_map), this); //"map" is never called on Ubuntu Unity, but "show" is
__________________________________________________________________________________________________________
/src/gtk/window.cpp
Backspace not working in filter dialog: http://www.freefilesync.org/forum/viewtopic.php?t=347
void wxWindowGTK::ConnectWidget( GtkWidget *widget )
{
- static bool isSourceAttached;
- if (!isSourceAttached)
- {
- // attach GSource to detect new GDK events
- isSourceAttached = true;
- static GSourceFuncs funcs =
- {
- source_prepare, source_check, source_dispatch,
- NULL, NULL, NULL
- };
- GSource* source = g_source_new(&funcs, sizeof(GSource));
- // priority slightly higher than GDK_PRIORITY_EVENTS
- g_source_set_priority(source, GDK_PRIORITY_EVENTS - 1);
- g_source_attach(source, NULL);
- g_source_unref(source);
- }
g_signal_connect (widget, "key_press_event",
G_CALLBACK (gtk_window_key_press_callback), this);
__________________________________________________________________________________________________________
/src/unix/sound.cpp
Fix crackling sound at the beginning of WAV playback:
See: http://soundfile.sapp.org/doc/WaveFormat/ => skip 8 bytes (Subchunk2ID and Subchunk2 Size)
- m_data->m_data = (&m_data->m_dataWithHeader[data_offset]);
+ m_data->m_data = (&m_data->m_dataWithHeader[data_offset + 8]);
__________________________________________________________________________________________________________
/src/common/bmpbndl.cpp
DoGetPreferredSize()'s lossy "GetDefaultSize()*scaleBest" calculation can be 1-pixel-off compared to real image size => superfluous + ugly-looking image shrinking!
wxSize wxBitmapBundleImplSet::GetPreferredBitmapSizeAtScale(double scale) const
{
+ //work around DoGetPreferredSize()'s flawed "GetDefaultSize()*scaleBest" calculation
+ for (const auto& entry : m_entries)
+ if (entry.bitmap.GetScaleFactor() == scale)
+ return entry.bitmap.GetSize();
+
return DoGetPreferredSize(scale);
}
__________________________________________________________________________________________________________
/src/gtk/button.cpp
now this is absurd: if we add wxTranslations for "&OK/&Cancel", wxWidgets will detect "wxIsStockLabel()",
throw away the label and do gtk_button_set_label(wxGetStockGtkID(wxID_OK/wxID_CANCEL)) instead,
which will result in *untranslated* confirmation buttons everywhere!
https://github.com/wxWidgets/wxWidgets/blob/6561ca020048de57ec28fec5b27f80b00d445cdd/src/gtk/button.cpp#L253
#ifndef __WXGTK4__
wxGCC_WARNING_SUPPRESS(deprecated-declarations)
- if (wxIsStockID(m_windowId) && wxIsStockLabel(m_windowId, label))
- {
- const char* stock = wxGetStockGtkID(m_windowId);
- if (stock)
- {
- gtk_button_set_label(GTK_BUTTON(m_widget), stock);
- gtk_button_set_use_stock(GTK_BUTTON(m_widget), TRUE);
- return;
- }
- }
wxGCC_WARNING_RESTORE()
#endif
__________________________________________________________________________________________________________
/src/common/toplvcmn.cpp
wxTopLevelWindow::Destroy() uses wxPendingDelete for deferred deletion during next idle event.
There might not be a next idle event! E.g. on GTK2 a hidden window doesn't receive idle events.
Reproduce on GTK2+KDE for toplevel window: Hide(); wxTheApp->Yield(); Destroy(); => process not exiting! https://freefilesync.org/forum/viewtopic.php?t=11935
- for ( wxWindowList::const_iterator i = wxTopLevelWindows.begin(),
- end = wxTopLevelWindows.end();
- i != end;
- ++i )
- {
- wxTopLevelWindow* const win = static_cast<wxTopLevelWindow*>(*i);
- if ( win != this && win->IsShown() )
- {
- // there remains at least one other visible TLW, we can hide this
- // one
- Hide();
-
- break;
- }
- }
+ Hide();
+ wxWakeUpIdle();
__________________________________________________________________________________________________________
Reference in New Issue View Git Blame Copy Permalink