GCC 15 will add -Wzero-as-null-pointer-constant for deprecating it, and I'm working on a paper for deprecating it from ISO C too. Let's remove any uses in our code base. I've done this change by building GCC from master, adding -Werror=zero-as-null-pointer-constant to ./autogen.sh, and fixing every error that showed up. Closes: <https://github.com/shadow-maint/shadow/issues/1120> Link: <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117059> Link: <https://software.codidact.com/posts/292718/292759#answer-292759> Signed-off-by: Alejandro Colomar <alx@kernel.org>
106 lines
2.0 KiB
C
106 lines
2.0 KiB
C
#include <config.h>
|
|
|
|
#include <dirent.h>
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <sys/wait.h>
|
|
#include <unistd.h>
|
|
#include <lib/prototypes.h>
|
|
|
|
#include "run_part.h"
|
|
#include "shadowlog_internal.h"
|
|
|
|
|
|
static int run_part(char *script_path, const char *name, const char *action)
|
|
{
|
|
pid_t pid;
|
|
int wait_status;
|
|
pid_t pid_status;
|
|
char *args[] = { script_path, NULL };
|
|
|
|
pid=fork();
|
|
if (pid==-1) {
|
|
fprintf(shadow_logfd, "fork: %s\n", strerror(errno));
|
|
return 1;
|
|
}
|
|
if (pid==0) {
|
|
setenv("ACTION",action,1);
|
|
setenv("SUBJECT",name,1);
|
|
execv(script_path,args);
|
|
fprintf(shadow_logfd, "execv: %s\n", strerror(errno));
|
|
exit(1);
|
|
}
|
|
|
|
pid_status = wait(&wait_status);
|
|
if (pid_status == pid) {
|
|
return (wait_status);
|
|
}
|
|
|
|
fprintf(shadow_logfd, "waitpid: %s\n", strerror(errno));
|
|
return (1);
|
|
}
|
|
|
|
int run_parts(const char *directory, const char *name, const char *action)
|
|
{
|
|
struct dirent **namelist;
|
|
int scanlist;
|
|
int n;
|
|
int execute_result = 0;
|
|
|
|
scanlist = scandir(directory, &namelist, NULL, alphasort);
|
|
if (scanlist<=0) {
|
|
return (0);
|
|
}
|
|
|
|
for (n=0; n<scanlist; n++) {
|
|
char *s;
|
|
struct stat sb;
|
|
|
|
if (asprintf(&s, "%s/%s", directory, namelist[n]->d_name) == -1) {
|
|
fprintf(shadow_logfd, "asprintf: %s\n", strerror(errno));
|
|
for (; n<scanlist; n++) {
|
|
free(namelist[n]);
|
|
}
|
|
free(namelist);
|
|
return (1);
|
|
}
|
|
|
|
execute_result = 0;
|
|
if (stat(s, &sb) == -1) {
|
|
fprintf(shadow_logfd, "stat: %s\n", strerror(errno));
|
|
free(s);
|
|
for (; n<scanlist; n++) {
|
|
free(namelist[n]);
|
|
}
|
|
free(namelist);
|
|
return (1);
|
|
}
|
|
|
|
if (S_ISREG(sb.st_mode) || S_ISLNK(sb.st_mode)) {
|
|
execute_result = run_part(s, name, action);
|
|
}
|
|
|
|
free(s);
|
|
|
|
if (execute_result!=0) {
|
|
fprintf(shadow_logfd,
|
|
"%s: did not exit cleanly.\n",
|
|
namelist[n]->d_name);
|
|
for (; n<scanlist; n++) {
|
|
free(namelist[n]);
|
|
}
|
|
break;
|
|
}
|
|
|
|
free(namelist[n]);
|
|
}
|
|
free(namelist);
|
|
|
|
return (execute_result);
|
|
}
|
|
|