09775d3718
If we consider simple objects as arrays of size 1, we can considerably
simplify these APIs, merging the *ARRAY and the non-array variants.
That will produce more readable code, since lines will be shorter (by
not having ARRAY in the macro names, as all macros will consistently
handle arrays), and the allocated size will be also more explicit.
The syntax will now be of the form:
p = MALLOC(42, foo_t); // allocate 42 elements of type foo_t.
p = MALLOC(1, bar_t); // allocate 1 element of type foo_t.
The _array() allocation functions should _never_ be called directly, and
instead these macros should be used.
The non-array functions (e.g., malloc(3)) still have their place, but
are limited to allocating structures with flexible array members. For
any other uses, the macros should be used.
Thus, we don't use any array or ARRAY variants in any code any more, and
they are only used as implementation details of these macros.
Link: <https://software.codidact.com/posts/285898/288023#answer-288023>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
84 lines
2.0 KiB
C
84 lines
2.0 KiB
C
/* Author: Peter Vrabec <pvrabec@redhat.com> */
|
|
|
|
#include <config.h>
|
|
#ifdef USE_SSSD
|
|
|
|
#include <stdio.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
#include <sys/types.h>
|
|
|
|
#include "alloc.h"
|
|
#include "exitcodes.h"
|
|
#include "defines.h"
|
|
#include "prototypes.h"
|
|
#include "sssd.h"
|
|
|
|
#include "shadowlog_internal.h"
|
|
|
|
#define MSG_SSSD_FLUSH_CACHE_FAILED "%s: Failed to flush the sssd cache."
|
|
|
|
int sssd_flush_cache (int dbflags)
|
|
{
|
|
int status, code, rv;
|
|
const char *cmd = "/usr/sbin/sss_cache";
|
|
struct stat sb;
|
|
char *sss_cache_args = NULL;
|
|
const char *spawnedArgs[] = {"sss_cache", NULL, NULL};
|
|
const char *spawnedEnv[] = {NULL};
|
|
int i = 0;
|
|
|
|
rv = stat(cmd, &sb);
|
|
if (rv == -1 && errno == ENOENT)
|
|
return 0;
|
|
|
|
sss_cache_args = MALLOC(4, char);
|
|
if (sss_cache_args == NULL) {
|
|
return -1;
|
|
}
|
|
|
|
sss_cache_args[i++] = '-';
|
|
if (dbflags & SSSD_DB_PASSWD) {
|
|
sss_cache_args[i++] = 'U';
|
|
}
|
|
if (dbflags & SSSD_DB_GROUP) {
|
|
sss_cache_args[i++] = 'G';
|
|
}
|
|
sss_cache_args[i++] = '\0';
|
|
if (i == 2) {
|
|
/* Neither passwd nor group, nothing to do */
|
|
free(sss_cache_args);
|
|
return 0;
|
|
}
|
|
spawnedArgs[1] = sss_cache_args;
|
|
|
|
rv = run_command (cmd, spawnedArgs, spawnedEnv, &status);
|
|
free(sss_cache_args);
|
|
if (rv != 0) {
|
|
/* run_command writes its own more detailed message. */
|
|
SYSLOG ((LOG_WARN, MSG_SSSD_FLUSH_CACHE_FAILED, shadow_progname));
|
|
return -1;
|
|
}
|
|
|
|
code = WEXITSTATUS (status);
|
|
if (!WIFEXITED (status)) {
|
|
SYSLOG ((LOG_WARN, "%s: sss_cache did not terminate normally (signal %d)",
|
|
shadow_progname, WTERMSIG (status)));
|
|
return -1;
|
|
} else if (code == E_CMD_NOTFOUND) {
|
|
/* sss_cache is not installed, or it is installed but uses an
|
|
interpreter that is missing. Probably the former. */
|
|
return 0;
|
|
} else if (code != 0) {
|
|
SYSLOG ((LOG_WARN, "%s: sss_cache exited with status %d", shadow_progname, code));
|
|
SYSLOG ((LOG_WARN, MSG_SSSD_FLUSH_CACHE_FAILED, shadow_progname));
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
#else /* USE_SSSD */
|
|
extern int ISO_C_forbids_an_empty_translation_unit;
|
|
#endif /* USE_SSSD */
|
|
|