09775d3718
If we consider simple objects as arrays of size 1, we can considerably
simplify these APIs, merging the *ARRAY and the non-array variants.
That will produce more readable code, since lines will be shorter (by
not having ARRAY in the macro names, as all macros will consistently
handle arrays), and the allocated size will be also more explicit.
The syntax will now be of the form:
p = MALLOC(42, foo_t); // allocate 42 elements of type foo_t.
p = MALLOC(1, bar_t); // allocate 1 element of type foo_t.
The _array() allocation functions should _never_ be called directly, and
instead these macros should be used.
The non-array functions (e.g., malloc(3)) still have their place, but
are limited to allocating structures with flexible array members. For
any other uses, the macros should be used.
Thus, we don't use any array or ARRAY variants in any code any more, and
they are only used as implementation details of these macros.
Link: <https://software.codidact.com/posts/285898/288023#answer-288023>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
115 lines
2.4 KiB
C
115 lines
2.4 KiB
C
/*
|
|
* SPDX-FileCopyrightText: 1989 - 1994, Julianne Frances Haugh
|
|
* SPDX-FileCopyrightText: 1996 - 1998, Marek Michałkiewicz
|
|
* SPDX-FileCopyrightText: 2001 - 2006, Tomasz Kłoczko
|
|
* SPDX-FileCopyrightText: 2007 - 2009, Nicolas François
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#if defined (HAVE_SETGROUPS) && ! defined (USE_PAM)
|
|
|
|
#include "prototypes.h"
|
|
#include "defines.h"
|
|
|
|
#include <stdio.h>
|
|
#include <grp.h>
|
|
#include <errno.h>
|
|
|
|
#include "alloc.h"
|
|
#include "shadowlog.h"
|
|
|
|
#ident "$Id$"
|
|
|
|
#define SEP ",:"
|
|
/*
|
|
* Add groups with names from LIST (separated by commas or colons)
|
|
* to the supplementary group set. Silently ignore groups which are
|
|
* already there. Warning: uses strtok().
|
|
*/
|
|
int add_groups (const char *list)
|
|
{
|
|
GETGROUPS_T *grouplist;
|
|
size_t i;
|
|
int ngroups;
|
|
bool added;
|
|
char *token;
|
|
char buf[1024];
|
|
int ret;
|
|
FILE *shadow_logfd = log_get_logfd();
|
|
|
|
if (strlen (list) >= sizeof (buf)) {
|
|
errno = EINVAL;
|
|
return -1;
|
|
}
|
|
strcpy (buf, list);
|
|
|
|
i = 16;
|
|
for (;;) {
|
|
grouplist = MALLOC(i, GETGROUPS_T);
|
|
if (NULL == grouplist) {
|
|
return -1;
|
|
}
|
|
ngroups = getgroups (i, grouplist);
|
|
if ( ( (-1 == ngroups)
|
|
&& (EINVAL != errno))
|
|
|| (i > (size_t)ngroups)) {
|
|
/* Unexpected failure of getgroups or successful
|
|
* reception of the groups */
|
|
break;
|
|
}
|
|
/* not enough room, so try allocating a larger buffer */
|
|
free (grouplist);
|
|
i *= 2;
|
|
}
|
|
if (ngroups < 0) {
|
|
free (grouplist);
|
|
return -1;
|
|
}
|
|
|
|
added = false;
|
|
for (token = strtok (buf, SEP); NULL != token; token = strtok (NULL, SEP)) {
|
|
struct group *grp;
|
|
|
|
grp = getgrnam (token); /* local, no need for xgetgrnam */
|
|
if (NULL == grp) {
|
|
fprintf (shadow_logfd, _("Warning: unknown group %s\n"),
|
|
token);
|
|
continue;
|
|
}
|
|
|
|
for (i = 0; i < (size_t)ngroups && grouplist[i] != grp->gr_gid; i++);
|
|
|
|
if (i < (size_t)ngroups) {
|
|
continue;
|
|
}
|
|
|
|
if (ngroups >= sysconf (_SC_NGROUPS_MAX)) {
|
|
fputs (_("Warning: too many groups\n"), shadow_logfd);
|
|
break;
|
|
}
|
|
grouplist = REALLOCF(grouplist, (size_t) ngroups + 1, GETGROUPS_T);
|
|
if (grouplist == NULL) {
|
|
return -1;
|
|
}
|
|
grouplist[ngroups] = grp->gr_gid;
|
|
ngroups++;
|
|
added = true;
|
|
}
|
|
|
|
if (added) {
|
|
ret = setgroups (ngroups, grouplist);
|
|
free (grouplist);
|
|
return ret;
|
|
}
|
|
|
|
free (grouplist);
|
|
return 0;
|
|
}
|
|
#else /* HAVE_SETGROUPS && !USE_PAM */
|
|
extern int ISO_C_forbids_an_empty_translation_unit;
|
|
#endif /* HAVE_SETGROUPS && !USE_PAM */
|
|
|