a5cddf243a
The maximum length of 32 wasn't being enforced in the code, and POSIX doesn't specify that maximum length either, so it seems it was an arbitrary limit of the past that doesn't exist any more. Use a regex that has no length limit. Closes: <https://github.com/shadow-maint/shadow/issues/836> Link: <https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html> Cc: Iker Pedrosa <ipedrosa@redhat.com> Cc: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Alejandro Colomar <alx@kernel.org>
101 lines
2.1 KiB
C
101 lines
2.1 KiB
C
/*
|
|
* SPDX-FileCopyrightText: 1990 - 1994, Julianne Frances Haugh
|
|
* SPDX-FileCopyrightText: 1996 - 2000, Marek Michałkiewicz
|
|
* SPDX-FileCopyrightText: 2001 - 2005, Tomasz Kłoczko
|
|
* SPDX-FileCopyrightText: 2005 - 2008, Nicolas François
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
/*
|
|
* is_valid_user_name(), is_valid_group_name() - check the new user/group
|
|
* name for validity;
|
|
* return values:
|
|
* true - OK
|
|
* false - bad name
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#ident "$Id$"
|
|
|
|
#include <ctype.h>
|
|
#include "defines.h"
|
|
#include "chkname.h"
|
|
|
|
int allow_bad_names = false;
|
|
|
|
static bool is_valid_name (const char *name)
|
|
{
|
|
if (allow_bad_names) {
|
|
return true;
|
|
}
|
|
|
|
/*
|
|
* User/group names must match BRE regex:
|
|
* [a-zA-Z0-9_.][a-zA-Z0-9_.-]*$\?
|
|
*
|
|
* as a non-POSIX, extension, allow "$" as the last char for
|
|
* sake of Samba 3.x "add machine script"
|
|
*
|
|
* Also do not allow fully numeric names or just "." or "..".
|
|
*/
|
|
int numeric;
|
|
|
|
if ('\0' == *name ||
|
|
('.' == *name && (('.' == name[1] && '\0' == name[2]) ||
|
|
'\0' == name[1])) ||
|
|
!((*name >= 'a' && *name <= 'z') ||
|
|
(*name >= 'A' && *name <= 'Z') ||
|
|
(*name >= '0' && *name <= '9') ||
|
|
*name == '_' ||
|
|
*name == '.')) {
|
|
return false;
|
|
}
|
|
|
|
numeric = isdigit(*name);
|
|
|
|
while ('\0' != *++name) {
|
|
if (!((*name >= 'a' && *name <= 'z') ||
|
|
(*name >= 'A' && *name <= 'Z') ||
|
|
(*name >= '0' && *name <= '9') ||
|
|
*name == '_' ||
|
|
*name == '.' ||
|
|
*name == '-' ||
|
|
(*name == '$' && name[1] == '\0')
|
|
)) {
|
|
return false;
|
|
}
|
|
numeric &= isdigit(*name);
|
|
}
|
|
|
|
return !numeric;
|
|
}
|
|
|
|
bool is_valid_user_name (const char *name)
|
|
{
|
|
/*
|
|
* User names length are limited by the kernel
|
|
*/
|
|
if (strlen (name) > sysconf(_SC_LOGIN_NAME_MAX)) {
|
|
return false;
|
|
}
|
|
|
|
return is_valid_name (name);
|
|
}
|
|
|
|
bool is_valid_group_name (const char *name)
|
|
{
|
|
/*
|
|
* Arbitrary limit for group names.
|
|
* HP-UX 10 limits to 16 characters
|
|
*/
|
|
if ( (GROUP_NAME_MAX_LENGTH > 0)
|
|
&& (strlen (name) > GROUP_NAME_MAX_LENGTH)) {
|
|
return false;
|
|
}
|
|
|
|
return is_valid_name (name);
|
|
}
|
|
|