98df44c5a1
Added tests for the PAM version of chpasswd.
nekral-guest
2009-05-09 22:20:43 +00:00
e5aa1773d3
* debian/login.pam: Updated support for SELinux. Closes: #527106
nekral-guest
2009-05-09 21:34:55 +00:00
f810e0a171
Fixed in next release: - pwck and grpck warn when the shadowed and non-shadowed files contain an entry for the same user or group and the non shadowed file password field is not 'x'. Closes: #501869 Other topics raised in this bug were fixed previously.
nekral-guest
2009-05-09 21:27:32 +00:00
a01499179f
* src/pwck.c: Warn if an user has an entry in passwd and shadow, and the password field in passwd is not 'x'. * src/grpck.c: Warn if a group has an entry in group and gshadow, and the password field in group is not 'x'.
nekral-guest
2009-05-09 21:20:54 +00:00
4e2e230b07
* debian/rules, debian/passwd.newusers.pam, debian/passwd.chpasswd.pam: Install the newusers and chpasswd PAM service configuration files. newusers and chpasswd now use PAM to update the passwords. Closes: #525153
nekral-guest
2009-05-09 17:03:49 +00:00
1737e6e0ec
Added notes about updated translations.
nekral-guest
2009-05-09 13:16:17 +00:00
3f649c5504
* man/login.defs.d/ENCRYPT_METHOD.xml, man/login.defs.d/MD5_CRYPT_ENAB.xml, man/login.defs.d/SHA_CRYPT_MIN_ROUNDS.xml: Updated note for PAM enabled versions. These variables are only used for group passwords in this case.
nekral-guest
2009-05-09 13:16:10 +00:00
7f9e196903
* NEWS, src/newusers.c, src/Makefile.am: Added support for changing the passwords with PAM. * src/newusers.c: Split the usage string in smaller parts to allow enabling single parts. * man/newusers.8.xml: Indicate the options and configuration variables valid for PAM and non-PAM versions. * man/newusers.8.xml: Added pointer to /etc/pam.d/chpasswd.
nekral-guest
2009-05-09 13:15:57 +00:00
d1534c53f7
* libmisc/non_interactive_pam_conv.c, libmisc/pam_pass_non_interractive.c, libmisc/Makefile.am: Renamed. * libmisc/pam_pass_non_interractive.c, lib/prototypes.h: non_interactive_password and non_interactive_pam_conv do not need to be externally visible. * libmisc/pam_pass_non_interractive.c: Added declaration of ni_conv. * libmisc/pam_pass_non_interractive.c: Only compile ifdef USE_PAM. * libmisc/pam_pass_non_interractive.c, lib/prototypes.h: Added do_pam_passwd_non_interractive(). * src/chpasswd.c: Use do_pam_passwd_non_interractive().
nekral-guest
2009-05-09 13:15:25 +00:00
19b672c3a4
* libmisc/pam_pass.c: Removed comment regarding pam_misc. This is checked by configure.in.
nekral-guest
2009-05-09 13:15:17 +00:00
a979e7d14d
* man/login.defs.5.xml: PAM enabled chpasswd do not use any configuration variable from login.defs.
nekral-guest
2009-05-09 13:15:10 +00:00
4654150518
* man/passwd.1.xml: Differentiate the files used for PAM and non-PAM versions.
nekral-guest
2009-05-09 13:15:03 +00:00
0921785ca2
* man/chpasswd.8.xml: Describe how chpasswd in case of error. * man/chpasswd.8.xml: Describe the PAM enabled chpasswd behavior. * man/chpasswd.8.xml: Differentiate the files and configurations needed for PAM and non PAM versions.
nekral-guest
2009-05-09 13:14:56 +00:00
b60e8b6b45
* src/login.c: failcount does not need to be signed.
nekral-guest
2009-05-09 13:14:50 +00:00
538336a332
* src/Makefile.am: PAM enabled chpasswd now needs to be linked to the PAM library, even if --enable-account-tools-setuid is not used.
nekral-guest
2009-05-09 13:14:44 +00:00
5c1279d803
* src/chpasswd.c: Added the line number when an error is reported instead of only the username. * src/chpasswd.c: PAM enabled chpasswd do may change the password database (for the user where the password update succeeded) even if there were a failure for one user. Do not indicate that changes were ignored.
nekral-guest
2009-05-09 13:14:37 +00:00
61939960cc
* src/passwd.c: Exit immediately when unlocking a password would result in a passwordless account. This avoid printing a success message after the warning.
nekral-guest
2009-05-09 13:14:31 +00:00
ee7af4d7e2
* src/nologin.c: Include <stdlib.h> to get EXIT_FAILURE.
nekral-guest
2009-05-09 13:14:23 +00:00
69fe59a632
* NEWS, configure.in: Fix build failure on non-PAM enabled system when --without-pam is not specified.
nekral-guest
2009-05-03 22:46:26 +00:00
ba65b06b4a
* lib/commonio.c: Ignore teh return values of fclose() and unlink() in case of failure of fopen_set_perms() or create_backup(). * lib/commonio.c: Should the backup file be unlink'ed in case of failure of create_backup()?
nekral-guest
2009-04-30 21:53:54 +00:00
a326ffa435
* lib/exitcodes.h: Define E_SUCCESS as EXIT_SUCCESS. Added FIXMEs. * libmisc/chowntty.c, libmisc/rlogin.c, libmisc/sub.c, src/newusers.c, libmisc/sulog.c, libmisc/system.c, src/logoutd.c, src/groups.c, src/id.c, lib/encrypt.c, libmisc/audit_help.c, libmisc/limits.c: Return EXIT_FAILURE instead of 1, and EXIT_SUCCESS instead of 0. * libmisc/audit_help.c: Replace an fprintf() by fputs(). * libmisc/audit_help.c: Remove documentation of the audit_logger returned values. The function returns void. * libmisc/system.c: Only return status if waitpid succeeded. Return -1 otherwise.
nekral-guest
2009-04-30 21:08:49 +00:00
d7d0b06a41
* NEWS, src/chpasswd.c: Added support for changing the passwords with PAM. * src/chpasswd.c: Split the usage string in smaller parts to allows enabling single parts. * src/chpasswd.c: Do not set a global lock on the password files. This is done by PAM each time a password is updated.
nekral-guest
2009-04-28 21:45:38 +00:00
72fa8afa07
* lib/defines.h: Include <utmpx.h> and <utmp.h> to define USER_NAME_MAX_LENGTH.
nekral-guest
2009-04-28 21:01:20 +00:00
1e75786616
* src/login.c: Change a snprintf() to strncpy(). There are no format.
nekral-guest
2009-04-28 20:59:31 +00:00
292b47c386
- passwd: Report password properties changes if the password is not actually changed. Closes: #525967
nekral-guest
2009-04-28 20:46:52 +00:00
59e1947950
* src/passwd.c: Harmonize status report at the end of passwd. Prefix the messages with "passwd: ", only indicate a password change if the password was actually changed, and password properties changed otherwise.
nekral-guest
2009-04-28 20:46:35 +00:00
f8b8aaf5e4
* src/chgpasswd.c, src/newusers.c: There is no need to test for 0 after getopt_long. No options have flag != NULL.
nekral-guest
2009-04-28 20:10:18 +00:00
613dc54ac5
* src/newusers.c: There is no need to test for 0 after getopt_long. No options have flag != NULL.
nekral-guest
2009-04-28 20:08:30 +00:00
e6b23e1431
* libmisc/chkname.c: Do not include <utmp.h> and <utmpx.h>. There are no more needed.
nekral-guest
2009-04-28 19:14:05 +00:00
b0c0a94c66
* libmisc/limits.c: Replace strtol() by getlong(). * libmisc/limits.c: Replace HAVE_UTMPX_H by USE_UTMPX.
nekral-guest
2009-04-28 19:12:48 +00:00
76b51939aa
* man/groupmod.8.xml, man/usermod.8.xml, man/groupadd.8.xml, man/useradd.8.xml: Added note to warn about insecurity in using --password. * man/groupmod.8.xml: Removed not regarding default if --password is not used. This was a cut&paste from groupadd.8.xml. * man/passwd.1.xml: Split some paragraphs. * man/passwd.1.xml: Recommend other encryption methods than DES.
nekral-guest
2009-04-27 20:29:43 +00:00
91fc51387c
* src/login.c: Move update_utmp() after the PID or session ID changed in order to get more accurate data in UTMP. This also fixes "exec login" when login in installed setuid.
nekral-guest
2009-04-27 20:25:23 +00:00
009125484e
* src/login.c: Reuse a string and avoid an untranslated message "Login incorrect".
nekral-guest
2009-04-27 20:21:48 +00:00
8112a12521
* src/login.c: Replace HAVE_UTMPX_H by USE_UTMPX. * src/login.c: Avoid name clash between global variables and the update_utmp() arguments.
nekral-guest
2009-04-27 20:20:37 +00:00
69307a1f2b
* src/groupadd.c, lib/commonio.c, lib/groupio.c: Added missing include of <assert.h>
nekral-guest
2009-04-27 20:18:00 +00:00
e68e07d095
* src/groupadd.c: Added missing include of <assert.h>
nekral-guest
2009-04-27 20:16:04 +00:00
851245107d
* lib/prototypes.h: Replace HAVE_UTMPX_H by USE_UTMPX. * lib/prototypes.h, libmisc/log.c: Added splint annotations. * libmisc/log.c: Added SYSLOG warning when lseek fails (should not happen).
nekral-guest
2009-04-27 20:15:09 +00:00
e88d1f5803
* libmisc/mail.c, libmisc/copydir.c: Added missing include of <assert.h>
nekral-guest
2009-04-27 20:09:18 +00:00
988f7334ad
* libmisc/env.c: Added assertions on the snprintf results.
nekral-guest
2009-04-27 20:07:59 +00:00
80fd2969c9
* libmisc/utmp.c: Replace HAVE_UTMPX_H by USE_UTMPX. * libmisc/utmp.c: Removed old comment on HAVE_STRUCT_UTMP_UT_ID and UTMPX support.
nekral-guest
2009-04-27 20:06:25 +00:00
13b74243a6
* NEWS, configure.in: Added configure option --enable-utmpx, disabled by default. This defines USE_UTMPX, which should be used instead of HAVE_UTMPX_H.
nekral-guest
2009-04-27 20:03:48 +00:00
4fd672c5b9
* lib/commonio.c: Added splint annotations. * lib/commonio.c: old_context should be local to commonio_close(), not global.
nekral-guest
2009-04-26 16:48:51 +00:00
fca3b5cdc9
* src/passwd.c: Do not freecon strings duplicated with strdup. Also avoid allocation of memory. * src/passwd.c: Use SYSLOG instead of syslog.
nekral-guest
2009-04-26 16:44:54 +00:00
2d99df028e
Name the release ("Rollot"). Added other bug closures.
nekral-guest
2009-04-26 12:52:05 +00:00
98e42fa944
* libmisc/copydir.c: Added splint annotations. * libmisc/copydir.c: Added assert to help splint. * libmisc/copydir.c: Free allocated structures in cas of failure. * libmisc/copydir.c: Avoid implicit conversion of pointers to booleans. * libmisc/copydir.c: Use buffers of size PATH_MAX instead of 1024 for filenames. * libmisc/copydir.c: Use fchmod and fchown to change the mode of the opened file. * libmisc/copydir.c: Indicate the mode to open(), even if we chmod later.
nekral-guest
2009-04-24 23:41:28 +00:00
ab6c366668
* lib/prototypes.h: Added prototypes of getulong() and get_pid(). * lib/prototypes.h: Added splint annotations.
nekral-guest
2009-04-24 23:35:57 +00:00
fc656ad7bd
* lib/commonio.c: Use get_pid() instead of strtol. * lib/commonio.c: Replace an int by a size_t.
nekral-guest
2009-04-24 23:35:01 +00:00
e8dd48ac09
* lib/getlong.c: Do not check for NULL string but empty string.
nekral-guest
2009-04-24 23:27:12 +00:00
08b4253001
* lib/groupio.c: Updated splint annotations. * lib/groupio.c: Added assert to help splint.
nekral-guest
2009-04-24 23:26:31 +00:00
1a87c69854
* src/useradd.c: Check assumptions on snprintf(). * src/useradd.c: Replace peror by an strerror and avoid an intermediate buffer. * src/useradd.c: Save errno between the failure and the report by perror/strerror. * src/useradd.c: Prefer xmalloc to malloc.
nekral-guest
2009-04-24 23:23:51 +00:00
861773bf77
* src/lastlog.c: Remove function calls from within assert().
nekral-guest
2009-04-24 23:05:29 +00:00
01e88bda16
* libmisc/obscure.c: Change some int to size_t.
nekral-guest
2009-04-24 23:04:27 +00:00
5e45ac1688
* libmisc/console.c: Use a less disturbing construct for splint.
nekral-guest
2009-04-24 23:03:14 +00:00
10396f9536
* libmisc/limits.c: Parse the limits, umask, nice, maxlogin, file limit with getlog() / getulong(). This also means, in case of non-PAM enabled systems, that the umask specified on the GECOS fields should start with a 0 if specified in octal. (it used to be force to octal). Do the appropriate cast and range checking.
nekral-guest
2009-04-24 22:56:42 +00:00
0c571784a3
* libmisc/salt.c: In case gettimeofday() fails, get some entropy from the PID.
nekral-guest
2009-04-24 22:49:20 +00:00
7646230de2
* libmisc/setupenv.c: Prefer snprintf to sprintf, even if a small context indicates no issues. * libmisc/setupenv.c: Avoid implicit conversion of pointers to booleans.
nekral-guest
2009-04-24 22:46:06 +00:00
nekral-guest
bubulle