d1534c53f7
* libmisc/non_interactive_pam_conv.c,
...
libmisc/pam_pass_non_interractive.c, libmisc/Makefile.am: Renamed.
* libmisc/pam_pass_non_interractive.c, lib/prototypes.h:
non_interactive_password and non_interactive_pam_conv do not need
to be externally visible.
* libmisc/pam_pass_non_interractive.c: Added declaration of
ni_conv.
* libmisc/pam_pass_non_interractive.c: Only compile ifdef USE_PAM.
* libmisc/pam_pass_non_interractive.c, lib/prototypes.h:
Added do_pam_passwd_non_interractive().
* src/chpasswd.c: Use do_pam_passwd_non_interractive().
2009-05-09 13:15:25 +00:00
b60e8b6b45
* src/login.c: failcount does not need to be signed.
2009-05-09 13:14:50 +00:00
538336a332
* src/Makefile.am: PAM enabled chpasswd now needs to be linked to
...
the PAM library, even if --enable-account-tools-setuid is not
used.
2009-05-09 13:14:44 +00:00
5c1279d803
* src/chpasswd.c: Added the line number when an error is reported
...
instead of only the username.
* src/chpasswd.c: PAM enabled chpasswd do may change the password
database (for the user where the password update succeeded) even
if there were a failure for one user. Do not indicate that changes
were ignored.
2009-05-09 13:14:37 +00:00
61939960cc
* src/passwd.c: Exit immediately when unlocking a password would
...
result in a passwordless account. This avoid printing a success
message after the warning.
2009-05-09 13:14:31 +00:00
ee7af4d7e2
* src/nologin.c: Include <stdlib.h> to get EXIT_FAILURE.
2009-05-09 13:14:23 +00:00
4da0573bf7
* lib/getulong.c: Added splint annotations.
2009-04-30 21:44:35 +00:00
4e75bb57bb
* src/newgrp.c, src/chfn.c, src/groupmems.c, src/usermod.c,
...
src/userdel.c, src/chpasswd.c, src/grpck.c, src/gpasswd.c,
src/groupdel.c, src/chgpasswd.c, src/vipw.c, src/useradd.c,
src/su.c, src/groupmod.c, src/passwd.c, src/pwck.c,
src/groupadd.c, src/chage.c, src/login.c, src/faillog.c,
src/sulogin.c, src/chsh.c, src/pwconv.c: Added splint annotations.
* src/userdel.c, src/pwconv.c, src/lastlog.c, src/grpck.c,
src/vipw.c, src/groupmod.c, src/passwd.c, src/pwck.c, src/login.c,
src/sulogin.c, src/usermod.c: Use return instead of exit at the
end of main().
* src/gpasswd.c, src/passwd.c, src/faillog.c: Use the exitcodes.h
exit codes.
* src/chpasswd.c: Added missing ||.
* src/nologin.c: Do not include exitcodes.h.
* src/nologin.c: Added brackets.
* src/nologin.c: Avoid assignments in comparisons.
2009-04-30 21:39:38 +00:00
a326ffa435
* lib/exitcodes.h: Define E_SUCCESS as EXIT_SUCCESS. Added FIXMEs.
...
* libmisc/chowntty.c, libmisc/rlogin.c, libmisc/sub.c,
src/newusers.c, libmisc/sulog.c, libmisc/system.c, src/logoutd.c,
src/groups.c, src/id.c, lib/encrypt.c, libmisc/audit_help.c,
libmisc/limits.c: Return EXIT_FAILURE instead of 1, and
EXIT_SUCCESS instead of 0.
* libmisc/audit_help.c: Replace an fprintf() by fputs().
* libmisc/audit_help.c: Remove documentation of the audit_logger
returned values. The function returns void.
* libmisc/system.c: Only return status if waitpid succeeded.
Return -1 otherwise.
2009-04-30 21:08:49 +00:00
9b6b06cd03
Restore string.
2009-04-28 21:46:06 +00:00
d7d0b06a41
* NEWS, src/chpasswd.c: Added support for changing the passwords
...
with PAM.
* src/chpasswd.c: Split the usage string in smaller parts to
allows enabling single parts.
* src/chpasswd.c: Do not set a global lock on the password files.
This is done by PAM each time a password is updated.
2009-04-28 21:45:38 +00:00
1e75786616
* src/login.c: Change a snprintf() to strncpy(). There are no
...
format.
2009-04-28 20:59:31 +00:00
1db4402dbb
Re-indent, reformat #ifndef blocks.
2009-04-28 20:55:10 +00:00
59e1947950
* src/passwd.c: Harmonize status report at the end of passwd.
...
Prefix the messages with "passwd: ", only indicate a password
change if the password was actually changed, and password
properties changed otherwise.
2009-04-28 20:46:35 +00:00
f8b8aaf5e4
* src/chgpasswd.c, src/newusers.c: There is no need to test for 0
...
after getopt_long. No options have flag != NULL.
2009-04-28 20:10:18 +00:00
613dc54ac5
* src/newusers.c: There is no need to test for 0 after
...
getopt_long. No options have flag != NULL.
2009-04-28 20:08:30 +00:00
dd85562fac
* libmisc/utmp.c, src/userdel.c, src/logoutd.c: Replace #if by #ifdef
2009-04-28 20:03:23 +00:00
90cc7f0f1d
* src/vipw.c: Harmonize messages.
2009-04-28 19:26:27 +00:00
bb00d1630a
* src/lastlog.c: Replace atoi() by getulong().
2009-04-28 19:25:15 +00:00
91fc51387c
* src/login.c: Move update_utmp() after the PID or session ID
...
changed in order to get more accurate data in UTMP. This also
fixes "exec login" when login in installed setuid.
2009-04-27 20:25:23 +00:00
009125484e
* src/login.c: Reuse a string and avoid an untranslated message
...
"Login incorrect".
2009-04-27 20:21:48 +00:00
8112a12521
* src/login.c: Replace HAVE_UTMPX_H by USE_UTMPX.
...
* src/login.c: Avoid name clash between global variables and the
update_utmp() arguments.
2009-04-27 20:20:37 +00:00
e68e07d095
* src/groupadd.c: Added missing include of <assert.h>
2009-04-27 20:16:04 +00:00
8f78169a52
* src/newgrp.c: Close the databases before changing the UDI and
...
GID.
2009-04-26 17:11:38 +00:00
fca3b5cdc9
* src/passwd.c: Do not freecon strings duplicated with strdup.
...
Also avoid allocation of memory.
* src/passwd.c: Use SYSLOG instead of syslog.
2009-04-26 16:44:54 +00:00
1a87c69854
* src/useradd.c: Check assumptions on snprintf().
...
* src/useradd.c: Replace peror by an strerror and avoid an
intermediate buffer.
* src/useradd.c: Save errno between the failure and the report by
perror/strerror.
* src/useradd.c: Prefer xmalloc to malloc.
2009-04-24 23:23:51 +00:00
861773bf77
* src/lastlog.c: Remove function calls from within assert().
2009-04-24 23:05:29 +00:00
37eec13774
* src/faillog.c: Remove function calls from within assert().
2009-04-24 22:27:09 +00:00
916977c5bb
* src/groupmod.c: Cast ID to ulongs and use ulong formats for IDs.
2009-04-23 20:39:29 +00:00
af8ff8c1ca
* src/newgrp.c: Added splint annotations.
...
* src/newgrp.c: audit_buf is only used in newgrp. Make it static.
* src/newgrp.c: Ignore the return value of fputs().
* src/newgrp.c: Use exit(EXIT_FAILURE) instead of exit(1).
2009-04-23 20:37:00 +00:00
7f165aab7f
* libmisc/find_new_gid.c, libmisc/find_new_uid.c,
...
libmisc/isexpired.c, src/groupadd.c, lib/pwauth.h, lib/groupmem.c,
lib/shadowmem.c, lib/pwmem.c, lib/prototypes.h: Added splint
annotations.
2009-04-23 17:43:27 +00:00
7b562d96b3
* src/faillog.c: Added splint annotations.
...
* src/faillog.c: Cast ID to ulongs and use ulong formats for IDs.
* src/faillog.c: Ignore fflush() return value.
* src/faillog.c: Added parenthesis.
2009-04-23 11:23:53 +00:00
988ec76cf8
* src/grpck.c: Ignore puts return value.
...
* src/grpck.c: Avoid variable format string.
2009-04-23 11:21:57 +00:00
87e15d7b82
* src/lastlog.c: Use EXIT_FAILURE / EXIT_SUCCESS for exit()
...
* src/lastlog.c: Added splint annotations.
* src/lastlog.c: Avoid global pwent.
* src/lastlog.c: Cast ID to ulongs and use ulong formats for IDs.
* src/lastlog.c: Avoid assignment in comparisons.
* src/lastlog.c: Ignore fclose() return value since the file is
only opened for reading.
2009-04-23 11:21:01 +00:00
77c1b2a369
* src/newgrp.c: Added assertion to guide splint (and me).
2009-04-23 11:17:22 +00:00
614c79defc
* libmisc/xgetXXbyYY.c, libmisc/myname.c, libmisc/getgr_nam_gid.c,
...
libmisc/salt.c, libmisc/list.c, libmisc/cleanup.c, src/login.c,
lib/getdef.h, lib/groupio.c, lib/getlong.c, lib/gshadow_.h,
lib/sgroupio.c, lib/shadowio.c, lib/pwio.c, lib/commonio.h,
lib/fputsx.c, lib/prototypes.h: Added splint annotations.
* lib/groupio.c: Avoid implicit conversion of pointers to
booleans.
* lib/groupio.c: Free allocated buffers in case of failure.
2009-04-23 09:57:03 +00:00
54302f6006
* src/login.c: Added splint annotations.
2009-04-22 20:53:15 +00:00
2a32262725
* src/login.c: Added assert()s for NULL (or ! NULL) username, and
...
pwd. This helps splint.
2009-04-22 20:51:13 +00:00
e35a7fbd89
Re-indent.
2009-04-22 20:48:42 +00:00
c55311aa6d
* src/login.c: After login_prompt(), do not check for unset
...
username, but for empty username.
2009-04-22 20:46:49 +00:00
3704745289
* lib/defines.h: Define USER_NAME_MAX_LENGTH, based on utmp and
...
default to 32.
* libmisc/chkname.c: Use USER_NAME_MAX_LENGTH.
* src/login.c: Use USER_NAME_MAX_LENGTH instead of the default 32.
username also needs to be bigger than USER_NAME_MAX_LENGTH because
it has to be nul-terminated.
2009-04-22 20:42:48 +00:00
eae8b63d4f
* src/login.c: Use xmalloc() instead of malloc().
2009-04-22 20:21:17 +00:00
349efcb0a6
* src/login.c: Ignore the return value of puts(), fputs(),
...
strftime().
2009-04-22 20:17:11 +00:00
46d697cded
* src/login.c: timeout, delay, and retries should be unsigned.
...
* src/login.c: Ignore the return value of alarm() and sleep().
2009-04-22 20:15:21 +00:00
53e0ff91d3
* src/login.c: If we cannot get the terminal configuration, do not
...
change the terminal configuration. setup_tty() is just a best
effort configuration of the terminal.
* src/login.c: Ignore failures when setting the terminal
configuration.
* src/login.c: Fail if the ERASECHAR or KILLCHAR configurations
are not compatible with a cc_t type.
2009-04-22 20:12:06 +00:00
a362a68f53
* src/login.c: utent might be NULL after get_current_utmp().
2009-04-22 20:07:34 +00:00
332a50c273
* src/login.c: Removed temp_shell. No more used.
...
* src/login.c: lastlog is only used #ifndef USE_PAM
* src/login.c: Rename lastlog to ll to avoid name clash with the
lastlog type.
2009-04-22 20:03:26 +00:00
790dbb07fc
* src/login.c: Added update_utmp() to group the prepare_utmp and
...
setutmp (and the utmpx versions).
2009-04-22 19:58:39 +00:00
f59a69f4b6
* src/login.c: Do not include netdb.h. gethostbyname() is no more
...
called from within login.c. Also UT_ADDR does not exist anymore.
2009-04-22 19:54:28 +00:00
efcbbc3d74
* src/login.c: Check if login is run with effective root
...
privileges. This should be more helpful to users than a failure to
find an utmp entry or failure to access a file.
2009-04-21 22:46:01 +00:00
nekral-guest