32f10c3dec
lib/fs/readlink/, lib/: areadlink(): Move and rename function
...
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2024-11-01 21:25:50 -05:00
5d5ab18890
lib/: Use readlinknul() instead of its pattern
...
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2024-11-01 21:25:50 -05:00
59e5eef38f
contrib, lib/, src/, tests/: Use stpcpy(3) instead of its pattern
...
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2024-07-03 10:03:12 -05:00
3049bef9c3
lib/alloc/, lib/, src/, tests/: Organize the allocation APIs in a new subdirectory
...
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2024-07-01 21:40:11 -05:00
22272347b6
lib/string/sprintf/, lib/, src/, tests/: Move all sprintf(3)-like APIs to a subdirectory
...
And have a separate file for each pair of APIs.
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2024-07-01 21:40:11 -05:00
000619344d
lib/copydir:copy_entry(): use temporary stat buffer
...
There are no guarantees that fstatat() does not clobber the stat
buffer on errors.
Use a temporary buffer so that the following code sees correct
attributes of the source entry.
Issue #973
Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de >
2024-03-21 02:44:12 +01:00
5d5d212764
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
...
Related-To: https://github.com/shadow-maint/shadow/issues/918
Suggested-by: Alejandro Colomar <alx@kernel.org >
Signed-off-by: Pablo Saavedra <psaavedra@igalia.com >
2024-01-30 16:19:56 +01:00
cdb2490ab6
Update close(2) checking
...
Check for close(2) failure at more places closing a file descriptor
written to.
Also ignore failures with errno set to EINTR (see man:close(2) for
details).
2023-12-14 07:40:40 -06:00
00e4e0c735
lib/copydir.c: Cosmetic
...
I was investigating a warning in this function, but the code was
inscrutable.
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-12-04 11:45:09 +01:00
dbb37b1b31
lib/string/: Move string-related files to string/ subdir
...
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-12-03 12:22:11 -06:00
44b8f7b3ef
lib/attr.h, lib/, src/: Move attributes to new header file
...
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-12-03 09:56:13 -06:00
2fa907a522
libmisc/copydir: do not forget errors from directory copy
...
copydir.c:429:4: warning: Value stored to 'err' is never read [deadcode.DeadStores]
Also reduce indentation by bailing out early.
(cherry picked from commit d89f2fb06d1b81b56299f9d0bfe7a927a2282f19)
2023-10-21 21:37:38 -05:00
d5e1c1e475
lib/, src/: Use xasprintf() instead of its pattern
...
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com >
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-10-20 21:05:33 +02:00
ad3b31a59e
lib/, src/: Use asprintf(3) instead of strlen(3)+malloc(3)+snprintf(3)
...
asprintf(3) is non-standard, but is provided by GNU, the BSDs, and musl.
That makes it portable enough for us to use.
This function is much simpler than the burdensome code for allocating
the right size. Being simpler, it's thus safer.
I took the opportunity to fix the style to my preferred one in the
definitions of variables used in these calls, and also in the calls to
free(3) with these pointers. That isn't gratuituous, but has a reason:
it makes those appear in the diff for this patch, which helps review it.
Oh, well, I had an excuse :)
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com >
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-10-20 21:05:33 +02:00
c5e5fee606
lib/copydir.c: Use goto to reduce a conditional branch
...
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com >
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-10-20 21:05:33 +02:00
7c93e1cdce
lib/copydir.c: Invert conditional to reduce nesting
...
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com >
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-10-20 21:05:33 +02:00
093fb605f9
lib: Merge libmisc into libshadow
...
The separation was unnecessary, and caused build problems. Let's go
wild and obliterate the library. The files are moved to libshadow.
Scripted change:
$ find libmisc/ -type f \
| grep '\.[chy]$' \
| xargs mv -t lib;
Plus updating the Makefile and other references. While at it, I've
sorted the sources lists.
Link: <https://github.com/shadow-maint/shadow/pull/792 >
Reported-by: David Seifert <soap@gentoo.org >
Cc: Sam James <sam@gentoo.org >
Cc: Christian Bricart <christian@bricart.de >
Cc: Michael Vetter <jubalh@iodoru.org >
Cc: Robert Förster <Dessa@gmake.de >
[ soap tested the Gentoo package ]
Tested-by: David Seifert <soap@gentoo.org >
Acked-by: David Seifert <soap@gentoo.org >
Acked-by: Serge Hallyn <serge@hallyn.com >
Acked-by: Iker Pedrosa <ipedrosa@redhat.com >
Acked-by: <lslebodn@fedoraproject.org >
Signed-off-by: Alejandro Colomar <alx@kernel.org >
2023-08-31 08:55:26 +02:00
Alejandro Colomar
Enrico Scholz
Pablo Saavedra
Christian Göttsche