bb67476209
* src/expiry.c: Remove dead code.
...
* src/expiry.c: Improve comments.
2011-07-22 22:39:30 +00:00
e8373305b4
* src/grpck.c: Added comments.
...
* src/grpck.c: Avoid implicit conversion of pointer to boolean.
* src/grpck.c: Remove dead code. argc cannot be lower than optind.
Avoid checking twice in a row for NULL != list[i].
2011-07-22 22:07:23 +00:00
8bce7fc016
* src/passwd.c: Overflow when computing the number of days based
...
on the scaling. Use of long long needed.
2011-07-14 14:03:19 +00:00
a7fee9db00
* NEWS, src/groupmod.c: When the gshadow file exists but there are
...
no gshadow entries, an entry is created if the password is changed
and group requires a shadow entry.
2011-07-14 13:30:05 +00:00
d4e630b8cc
* src/usermod.c (process_flags): Indicate that the user name is
...
invalid, instead of just a 'field'.
2011-07-14 13:29:59 +00:00
82b92af086
* src/usermod.c (process_flags): Do not display the usage in case
...
of an invalid -f value (similar to -e).
2011-07-14 13:29:54 +00:00
c23e851074
* src/usermod.c (new_pwent): Document that pw_locate will not fail
...
because getpwnam returned successfully.
2011-07-14 13:29:48 +00:00
2c6782b501
* NEWS, src/usermod.c; man/usermod.8.xml: When the shadow file
...
exists but there are no shadow entries, an entry has to be created
if the password is changed and passwd requires a shadow entry, or
if aging features are used (-e or -f). Document this and also that
-e and -f require a shadow file.
2011-07-14 13:29:37 +00:00
c2f5088067
* src/usermod.c (update_group, update_gshadow): Reduce complexity
...
and document checks. Some checks were always true/false within
their call context.
2011-07-14 13:29:32 +00:00
8195a2b5d8
* src/usermod.c (update_gshadow): is_member was computed twice.
2011-07-14 13:29:27 +00:00
2798e35d86
* src/usermod.c: usage() does not return. Add annotations.
2011-07-14 13:29:22 +00:00
d1753cc25d
* src/usermod.c (process_flags): Check for oflg is not needed to
...
check if changes are needed.
2011-07-14 13:29:16 +00:00
a5ded26850
* src/usermod.c (process_flags): Report usage if no options are
...
provided. Update the error message.
* src/usermod.c (process_flags): Check option compatibility and
dependency before options are discarded when no changes are
requested.
2011-07-14 13:29:10 +00:00
d51420bb01
* src/usermod.c (move_home): It is always an error to use -m if
...
the new home directory already exist (independently from the
existence of the old home directory did not exist)
2011-07-14 13:29:05 +00:00
aec025dbf6
* src/usermod.c: Fix typo in comment.
2011-07-14 13:28:59 +00:00
95257d63a1
* src/groupmod.c: Avoid implicit conversion of pointer to boolean.
...
* src/groupmod.c: osgrp can be set only if pflg || nflg. No need
to check for pflg || nflg again
2011-07-08 19:58:40 +00:00
13873a8799
* lib/fields.c: Fixed typo from 2010-02-15. field insteadof cp
...
ought to be checked.
* src/vipw.c: Use Prog instead of progname. This is needed since
Prog is used in the library.
2011-07-08 19:56:18 +00:00
cc6eaf9584
Fix typo in comment.
2011-07-08 19:51:32 +00:00
1a164919f1
Fixed typo. user_home -> mailfile.
2011-07-08 19:50:42 +00:00
907025eb40
* src/su.c: environ is provided by <unistd.h>.
...
* src/su.c: Added function prototypes.
* src/su.c: Rename shellstr parameter to shellname to avoid
collision with static variable.
* NEWS, src/su.c: Added support for PAM modules which change
PAM_USER.
2011-06-16 21:21:29 +00:00
66d71aafb7
Cleanup.
2011-06-13 18:27:51 +00:00
317939e821
* src/su.c: After prepare_pam_close_session() there is no need to
...
close the session in the child. Added pam_setcred to
prepare_pam_close_session().
2011-06-13 18:27:46 +00:00
1340beed16
* src/su.c: Also drop the controlling terminal when PAM is not
...
used.
* src/su.c: Remove run_shell().
2011-06-13 18:27:40 +00:00
e9045e9f55
* src/su.c (prepare_pam_close_session): Extract the creation of a
...
child and listening for signal in the parent from run_shell().
prepare_pam_close_session() is now executed before the creation of
the pam session and before the UID is changed. This allows to
close the session as root.
2011-06-13 18:27:34 +00:00
69371ba2c2
* src/su.c: Extract export of environment from main().
2011-06-13 18:27:28 +00:00
dbe0b96404
* src/su.c: Extract command line processing from main().
2011-06-13 18:27:23 +00:00
43e65fdd46
* src/su.c: Close the password databases together with syslog.
2011-06-13 18:27:17 +00:00
5d6f4f8ea4
* src/su.c: Merge environment setting blocks after the creation of
...
the session.
2011-06-13 18:27:12 +00:00
b63c830547
* src/su.c: Cleanup check_perms_nopam().
2011-06-13 18:27:06 +00:00
927c2f06a3
* src/su.c: Split check_perms() in to a PAM (check_perms_pam) and
...
a non-PAM (check_perms_nopam) version.
2011-06-13 18:26:58 +00:00
40a16a1b04
Compile fixes & cleanups.
2011-06-13 18:26:52 +00:00
6be3ac560b
* src/su.c (save_caller_context): Extract from main() the code
...
used to save the caller's context.
2011-06-13 18:26:47 +00:00
b661b913b5
* src/su.c: Cleanup local variables.
2011-06-13 18:26:36 +00:00
b273c4d19f
Cleanup comments.
2011-06-13 18:26:31 +00:00
7ebfb5c90f
* lib/prototypes.h, src/suauth.c, src/su.c (check_su_auth): Do not
...
use the pwent global variable to communicate between APIs of
different files. Added boolean parameter su_to_root to
check_su_auth().
* src/su.c (check_perms): Return the passwd entry of the finally
authenticated user. Remove usage of the pwent variable.
* src/su.c: The password of the caller is the one from the
spwd structure only if the passwd's password is 'x'.
2011-06-13 18:26:26 +00:00
3abd71c526
* src/su.c: Extract the authentication from the main function.
2011-06-13 18:26:16 +00:00
dc90c77285
* src/su.c: Define shellstr before the environment so that
...
restricted_shell is called only once. This will allow moving the
environment definition after the switch to the new user.
2011-06-13 18:26:10 +00:00
2f71935616
* src/su.c: Move definition of change_environment and shellstr
...
after the switch to the final subsystem. The previous architecture
forced to always change the environment (the shell starts with a
'*' and was thus restricted, and change_environment could not be
reset to false).
2011-06-13 18:25:57 +00:00
941e94f1d2
* src/su.c: No need to change the user's shell in case of
...
subsystem root. Update the comments.
2011-06-13 18:25:51 +00:00
4be8077a56
* src/su.c: Group some of the environment processing blocks. The
...
definition of shellstr, PATH and IFS is not influenced (getenv,
getdef, restricted_shell) by and does not influence (addenv does
not change environ) the authentication. And the authentication
does not overwrite those definitions. This will ease an extraction
from the big main() function.
2011-06-13 18:25:45 +00:00
aef33a89c2
* src/su.c: No need to call expire() if there are no shadow entry.
...
No need to convert a passwd entry into an spwd entry in that case.
2011-06-13 18:25:40 +00:00
1ddde00b1d
* src/su.c: Updating pwent after expire() is not useful. Only the
...
password information may have changed and they are not used
anymore afterwards.
2011-06-13 18:25:34 +00:00
b5403415f7
* NEWS, src/su.c: Do not forward the controlling terminal to
...
commands executed with -c. This prevents tty hijacking which could
lead to execution with the caller's privileges. This required to
forward signals from the terminal (SIGINT, SIGQUIT, SIGTSTP) to
the executed command.
2011-06-05 14:41:15 +00:00
a8ca723277
* NEWS, src/userdel.c: Do not remove a group with the same name as
...
the user (usergroup) if this group isn't the user's primary group.
2011-06-05 12:23:59 +00:00
14f44bd9c9
* NEWS, src/userdel.c: Check the existence of the user's mail
...
spool before trying to remove it. If it does not exist, a warning
is issued, but no failure.
2011-06-04 22:38:57 +00:00
ce737cf543
* src/sulogin.c: Added Prog, needed because of the last xmalloc()
...
change.
2011-06-03 21:08:56 +00:00
597bb764f1
* src/lastlog.c, src/faillog.c: Fix underflows causing wrong entry
...
to be displayed.
2011-06-02 20:26:30 +00:00
ee163bed33
* libmisc/user_busy.c, src/userdel.c, src/usermod.c: Warn in
...
user_busy() rather than in src/userdel.c or src/usermod.c to
provide more accurate failure cause (user is logged in or user
still executes processes).
2011-02-16 20:46:27 +00:00
0419fc4f5f
* NEWS, src/chfn.c, src/chsh.c: Fix CVE-2011-0721: forbid \n in
...
gecos or shell.
2011-02-16 00:18:45 +00:00
229f243ca0
* NEWS, src/usermod.c: Accept options in any order (username not
...
necessarily at the end)
2010-08-29 19:02:41 +00:00
nekral-guest