diff --git a/lib/idmapping.c b/lib/idmapping.c index d9f9cd52..a2e74380 100644 --- a/lib/idmapping.c +++ b/lib/idmapping.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "alloc.h" #include "prototypes.h" @@ -176,7 +177,7 @@ void write_mapping(int proc_dir_fd, int ranges, const struct map_range *mappings } /* Lockdown new{g,u}idmap by dropping all unneeded capabilities. */ - memset(data, 0, sizeof(data)); + bzero(data, sizeof(data)); data[0].effective = CAP_TO_MASK(cap); /* * When uid 0 from the ancestor userns is supposed to be mapped into diff --git a/lib/memzero.h b/lib/memzero.h index 99e2beca..1137e830 100644 --- a/lib/memzero.h +++ b/lib/memzero.h @@ -33,7 +33,7 @@ memzero(void *ptr, size_t size) #elif defined(HAVE_EXPLICIT_BZERO) explicit_bzero(ptr, size); #else - memset(ptr, '\0', size); + bzero(ptr, size); __asm__ __volatile__ ("" : : "r"(ptr) : "memory"); #endif } diff --git a/lib/pam_pass_non_interactive.c b/lib/pam_pass_non_interactive.c index cd4d78e0..aec02ad8 100644 --- a/lib/pam_pass_non_interactive.c +++ b/lib/pam_pass_non_interactive.c @@ -13,6 +13,8 @@ #include #include #include +#include + #include #include "alloc.h" @@ -94,8 +96,8 @@ static int ni_conv (int num_msg, failed_conversation: for (count=0; count < num_msg; count++) { if (NULL != responses[count].resp) { - memset (responses[count].resp, 0, - strlen (responses[count].resp)); + bzero(responses[count].resp, + strlen(responses[count].resp)); free (responses[count].resp); responses[count].resp = NULL; } diff --git a/lib/salt.c b/lib/salt.c index dc242ffa..529d59ca 100644 --- a/lib/salt.c +++ b/lib/salt.c @@ -20,6 +20,8 @@ #include #include #include +#include + #include "prototypes.h" #include "defines.h" #include "getdef.h" @@ -319,7 +321,7 @@ static /*@observer@*/const char *gensalt (size_t salt_size) { static char salt[MAX_SALT_SIZE + 6]; - memset (salt, '\0', MAX_SALT_SIZE + 6); + bzero(salt, MAX_SALT_SIZE + 6); assert (salt_size >= MIN_SALT_SIZE && salt_size <= MAX_SALT_SIZE); @@ -358,7 +360,7 @@ static /*@observer@*/const char *gensalt (size_t salt_size) const char *method; unsigned long rounds = 0; - memset (result, '\0', GENSALT_SETTING_SIZE); + bzero(result, GENSALT_SETTING_SIZE); if (NULL != meth) method = meth; @@ -406,7 +408,7 @@ static /*@observer@*/const char *gensalt (size_t salt_size) method); salt_len = MAX_SALT_SIZE; rounds = 0; - memset (result, '\0', GENSALT_SETTING_SIZE); + bzero(result, GENSALT_SETTING_SIZE); } #if USE_XCRYPT_GENSALT @@ -418,7 +420,7 @@ static /*@observer@*/const char *gensalt (size_t salt_size) /* Avoid -Wunused-but-set-variable. */ salt_len = GENSALT_SETTING_SIZE - 1; rounds = 0; - memset (result, '.', salt_len); + memset(result, '.', salt_len); result[salt_len] = '\0'; } diff --git a/src/groupmod.c b/src/groupmod.c index 7fd02d6f..11aca7f0 100644 --- a/src/groupmod.c +++ b/src/groupmod.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #ifdef ACCT_TOOLS_SETUID #ifdef USE_PAM @@ -229,7 +230,7 @@ static void grp_update (void) * shadowed password, we force the creation of a * gshadow entry when a new password is requested. */ - memset (&sgrp, 0, sizeof sgrp); + bzero(&sgrp, sizeof sgrp); sgrp.sg_name = xstrdup (grp.gr_name); sgrp.sg_passwd = xstrdup (grp.gr_passwd); sgrp.sg_adm = ∅ diff --git a/src/grpconv.c b/src/grpconv.c index 57d8d58e..34ed7ad3 100644 --- a/src/grpconv.c +++ b/src/grpconv.c @@ -21,9 +21,11 @@ #include #include #include +#include #include #include #include + #include "nscd.h" #include "sssd.h" #include "prototypes.h" @@ -198,7 +200,7 @@ int main (int argc, char **argv) static char *empty = 0; /* add new shadow group entry */ - memset (&sgent, 0, sizeof sgent); + bzero(&sgent, sizeof sgent); sgent.sg_name = gr->gr_name; sgent.sg_passwd = gr->gr_passwd; sgent.sg_adm = ∅ diff --git a/src/pwconv.c b/src/pwconv.c index 356802c4..4f388d25 100644 --- a/src/pwconv.c +++ b/src/pwconv.c @@ -40,9 +40,11 @@ #include #include #include +#include #include #include #include + #include "defines.h" #include "getdef.h" #include "prototypes.h" @@ -237,7 +239,7 @@ int main (int argc, char **argv) spent = *sp; } else { /* add new shadow entry */ - memset (&spent, 0, sizeof spent); + bzero(&spent, sizeof spent); spent.sp_namp = pw->pw_name; spent.sp_min = getdef_num ("PASS_MIN_DAYS", -1); spent.sp_max = getdef_num ("PASS_MAX_DAYS", -1); diff --git a/src/usermod.c b/src/usermod.c index 72a98f1f..63e1eb9b 100644 --- a/src/usermod.c +++ b/src/usermod.c @@ -27,6 +27,7 @@ #endif /* USE_PAM */ #endif /* ACCT_TOOLS_SETUID */ #include +#include #include #include #include @@ -1737,7 +1738,7 @@ static void usr_update (void) * a shadowed password * + aging information is requested */ - memset (&spent, 0, sizeof spent); + bzero(&spent, sizeof spent); spent.sp_namp = user_name; /* The user explicitly asked for a shadow feature.