lib/alloc/realloc*.h: Always reallocate at least 1 byte

glibc's realloc(3) is broken.  It was originally good (I believe) until
at some point, when it was changed to conform to C89, which had a bogus
specification that required that it returns NULL.  C99 fixed the mistake
from C89, and so glibc's realloc(3) is non-conforming to
C99/C11/POSIX.1-2008.  C17 broke again the definition of realloc(3).

Link: <https://github.com/shadow-maint/shadow/pull/1095>
Link: <https://nabijaczleweli.xyz/content/blogn_t/017-malloc0.html>
Link: <https://inbox.sourceware.org/libc-alpha/5gclfbrxfd7446gtwd2x2gfuquy7ukjdbrndphyfmfszxlft76@wwjz7spd4vd7/T/#t>
Co-developed-by: наб <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: наб <nabijaczleweli@nabijaczleweli.xyz>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Acked-by: Paul Eggert <eggert@cs.ucla.edu>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
Alejandro Colomar
2024-10-16 20:31:25 +02:00
committed by Iker Pedrosa
parent 12aa29b576
commit afc4b574b7
2 changed files with 4 additions and 5 deletions
+1 -1
View File
@@ -13,7 +13,7 @@
#define REALLOC(p, n, type) \
( \
_Generic(p, type *: (type *) reallocarray(p, n, sizeof(type))) \
_Generic(p, type *: (type *) reallocarray(p, (n) ?: 1, sizeof(type))) \
)