From 84f0ae00d21e7c8c58603271cd3a111226914152 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 5 Dec 2016 15:43:20 -0500 Subject: [PATCH 1/5] configure: avoid deprecated AC_INIT/AM_INIT_AUTOMAKE invocation The autoconf/automake guys want AC_INIT to be passed the details of the package directly rather than going through AM_INIT_AUTOMAKE. Update them both to use the newer style. This also allows us to pass in contact details for the project. We set the minimum autoconf version to 2.64 as that's the first one to support passing the homepage URL in to AC_INIT. That's a pretty old release by now, so it shouldn't be a problem. --- configure.ac | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b389838a..cf774e03 100644 --- a/configure.ac +++ b/configure.ac @@ -1,6 +1,8 @@ dnl Process this file with autoconf to produce a configure script. -AC_INIT -AM_INIT_AUTOMAKE(shadow, 4.4) +AC_PREREQ([2.64]) +AC_INIT([shadow], [4.4], [pkg-shadow-devel@lists.alioth.debian.org], [], + [https://github.com/shadow-maint/shadow]) +AM_INIT_AUTOMAKE AC_CONFIG_HEADERS([config.h]) dnl Some hacks... From 10bd7bab1443780e69592292e83c1210b84edf23 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 5 Dec 2016 15:48:10 -0500 Subject: [PATCH 2/5] ignore config.cache & dist files config.cache is generated when running `./configure -C`. The tarballs are generated when running `make dist`. --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 960696cd..80cc16c4 100644 --- a/.gitignore +++ b/.gitignore @@ -18,6 +18,7 @@ Makefile.in /aclocal.m4 /autom4te.cache /compile +/config.cache /config.guess /config.h /config.h.in @@ -45,4 +46,5 @@ Makefile.in /po/stamp-po /shadow.spec +/shadow-*.tar.* /libmisc/getdate.c From e33cb8ae1271c05fe1810fab70e649eb8b8bea65 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 5 Dec 2016 15:57:34 -0500 Subject: [PATCH 3/5] switch bz2 dist to xz Since xz is fairly common nowadays, and is typically smaller/faster than bzip2 for people to decompress, switch shadow over too. We also merge the two init locations into configure.ac to match newer autotools style. The min automake version is bumped to 1.11 too since that's when xz was released. --- Makefile.am | 2 -- configure.ac | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 7492f07f..8851f5d6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -2,7 +2,5 @@ EXTRA_DIST = NEWS README TODO shadow.spec.in -AUTOMAKE_OPTIONS = 1.5 dist-bzip2 foreign - SUBDIRS = po man libmisc lib src \ contrib doc etc diff --git a/configure.ac b/configure.ac index cf774e03..7e3f246d 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ dnl Process this file with autoconf to produce a configure script. AC_PREREQ([2.64]) AC_INIT([shadow], [4.4], [pkg-shadow-devel@lists.alioth.debian.org], [], [https://github.com/shadow-maint/shadow]) -AM_INIT_AUTOMAKE +AM_INIT_AUTOMAKE([1.11 foreign dist-xz]) AC_CONFIG_HEADERS([config.h]) dnl Some hacks... From 752ca15da4e0cdf75a6bdc5ad57b60f7f49cc65f Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 5 Dec 2016 16:02:19 -0500 Subject: [PATCH 4/5] man: make clean-local more robust If the subdirs aren't empty, the rmdir calls can fail. Simplify this code by just using `rm -rf` since that matches what we really want. --- man/generate_mans.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/generate_mans.mak b/man/generate_mans.mak index 28694667..f0812969 100644 --- a/man/generate_mans.mak +++ b/man/generate_mans.mak @@ -42,7 +42,7 @@ man1/% man3/% man5/% man8/%: %.xml-config Makefile config.xml -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/profile-docbook.xsl $< clean-local: - for d in man1 man3 man5 man8; do [ -d $$d ] && rmdir $$d; done + rm -rf man1 man3 man5 man8 else $(man_MANS): From 6e91297fa2418c78d5c7116d5987aa8d69efd2d1 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 5 Dec 2016 16:02:55 -0500 Subject: [PATCH 5/5] enable silent build output by default Enable the automake feature to produce silent output by default. When compiling code, we now see things like: $ make CC addgrps.o CC age.o CC audit_help.o ... This can be disabled via configure's --disable-silent-rules or by passing V=1 to make. Custom output (like in the man subdirs) don't (yet) respect this feature. More work will be needed to clean those up. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 7e3f246d..652a2133 100644 --- a/configure.ac +++ b/configure.ac @@ -3,6 +3,7 @@ AC_PREREQ([2.64]) AC_INIT([shadow], [4.4], [pkg-shadow-devel@lists.alioth.debian.org], [], [https://github.com/shadow-maint/shadow]) AM_INIT_AUTOMAKE([1.11 foreign dist-xz]) +AM_SILENT_RULES([yes]) AC_CONFIG_HEADERS([config.h]) dnl Some hacks...