From 813c3ec6c5cc0670f9b5762b17daaafe1596b385 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Sat, 18 May 2024 22:03:08 +0200 Subject: [PATCH] src/login_nopam.c: login_access(): Simplify, calling strchr(3) Signed-off-by: Alejandro Colomar --- src/login_nopam.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/login_nopam.c b/src/login_nopam.c index e6f77d1c..1a2b1736 100644 --- a/src/login_nopam.c +++ b/src/login_nopam.c @@ -100,10 +100,8 @@ int login_access (const char *user, const char *from) int lineno = 0; /* for diagnostics */ while ( !match && (fgets (line, sizeof (line), fp) == line)) { - ptrdiff_t end; lineno++; - end = strlen (line) - 1; - if (line[0] == '\0' || line[end] != '\n') { + if (line[0] == '\0' || strchr(line, '\n') == NULL) { SYSLOG ((LOG_ERR, "%s: line %d: missing newline or line too long", TABLE, lineno));