VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utmp: call prepare_utmp() even if utent is NULL

Browse Source 
update_utmp() should also return 0 when success.

Fixes: 1f368e1c18 ("utmp: update
`update_utmp()")
Resolves: https://github.com/shadow-maint/shadow/issues/805

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This commit is contained in:
Iker Pedrosa
2023-09-15 09:55:02 +02:00
committed by Serge Hallyn
parent bef4da47be
commit 5178f8c5af
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/utmp.c
+5 -6
View File
@@ -370,17 +370,16 @@ int update_utmp (const char *user,
struct utmp *utent, *ut; struct utmp *utent, *ut;
utent = get_current_utmp (); utent = get_current_utmp ();
if (utent == NULL) {
return -1;
}
ut = prepare_utmp (user, tty, host, utent); ut = prepare_utmp (user, tty, host, utent);
(void) setutmp (ut); /* make entry in the utmp & wtmp files */ (void) setutmp (ut); /* make entry in the utmp & wtmp files */
free (utent);
if (utent != NULL) {
free (utent);
}
free (ut); free (ut);
return 1; return 0;
} }
void record_failure(const char *failent_user, void record_failure(const char *failent_user,