From 2b67dc77651874999258c9ca4ebd57ed03cabe37 Mon Sep 17 00:00:00 2001 From: Samanta Navarro Date: Tue, 23 Jan 2024 12:04:05 +0000 Subject: [PATCH] lib/pam_pass_non_interactive.c: use strzero/free The combination of bzero and free could be optimized away. Reviewed-by: Alejandro Colomar Signed-off-by: Samanta Navarro --- lib/pam_pass_non_interactive.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/pam_pass_non_interactive.c b/lib/pam_pass_non_interactive.c index 12dad4dd..3d10908b 100644 --- a/lib/pam_pass_non_interactive.c +++ b/lib/pam_pass_non_interactive.c @@ -19,6 +19,7 @@ #include "alloc.h" #include "attr.h" +#include "memzero.h" #include "prototypes.h" #include "shadowlog.h" @@ -97,9 +98,8 @@ static int ni_conv (int num_msg, failed_conversation: for (count=0; count < num_msg; count++) { if (NULL != responses[count].resp) { - bzero(responses[count].resp, - strlen(responses[count].resp)); - free (responses[count].resp); + strzero(responses[count].resp); + free(responses[count].resp); responses[count].resp = NULL; } }