From 1faf4d6469ac440e18f049fcee5a5616483e9b80 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Wed, 17 Jan 2024 16:57:02 +0100 Subject: [PATCH] src/sulogin.c: Make static variables local to main() Those variables are only used in main(). Restrict their scope. Keep them static (.bss), as changing that may be dangerous. Suggested-by: Samanta Navarro Cc: Serge Hallyn Signed-off-by: Alejandro Colomar --- src/sulogin.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sulogin.c b/src/sulogin.c index f6bb5f6c..77f4fdde 100644 --- a/src/sulogin.c +++ b/src/sulogin.c @@ -37,9 +37,6 @@ */ const char *Prog; -static char pass[BUFSIZ]; - -static struct passwd pwent; extern char **newenvp; extern size_t newenvc; @@ -58,7 +55,7 @@ static void catch_signals (unused int sig) _exit (1); } - /*ARGSUSED*/ int main (int argc, char **argv) +/*ARGSUSED*/ int main (int argc, char **argv) { #ifndef USE_PAM const char *env; @@ -67,6 +64,9 @@ static void catch_signals (unused int sig) TERMIO termio; int err = 0; + static char pass[BUFSIZ]; + static struct passwd pwent; + tcgetattr (0, &termio); termio.c_iflag |= (ICRNL | IXON); termio.c_oflag |= (CREAD);