VesperOS/shadow
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

src/useradd: avoid usage of sprintf

Browse Source 
sprintf(3) does not take the destination buffer into account. Although
the destination in these case is large enough, sprintf(3) indicates a
code smell.

Use the xasprintf() wrapper.
This commit is contained in:
Christian Göttsche
2023-12-11 17:13:43 +01:00
committed by Serge Hallyn
parent 95a8de2a0a
commit 0d7cb003b7
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/useradd.c
+2 -5
View File
@@ -2387,7 +2387,6 @@ static void create_mail (void)
char *file;
gid_t gid;
mode_t mode;
size_t size;
const char *spool;
struct group *gr;
@@ -2403,12 +2402,10 @@ static void create_mail (void)
if (NULL == spool) {
return;
}
size = strlen(prefix) + strlen(spool) + strlen(user_name) + 3;
file = XMALLOC(size, char);
if (prefix[0])
sprintf(file, "%s/%s/%s", prefix, spool, user_name);
xasprintf(&file, "%s/%s/%s", prefix, spool, user_name);
else
sprintf(file, "%s/%s", spool, user_name);
xasprintf(&file, "%s/%s", spool, user_name);
#ifdef WITH_SELINUX
if (set_selinux_file_context(file, S_IFREG) != 0) {