5a30ebe403
window-list: Refactor workspace signal handlers
...
We are about to support a separate representation if horizontal
workspaces are used. To prepare for that, rename the handlers to
something more generic and split out menu-specific bits into a
dedicated helper function.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:15 +02:00
a5f347ba10
window-list: Improve workspace label styling
...
The border currently looks off - it extends all the way vertically
and leaves zero spacing to the label horizontally. Fix both issues
by setting appropriate padding/margins.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:09 +02:00
dab326c17e
window-list: Minor cleanup
...
Mutter has a dedicated method for getting the index of the active
workspace, use that instead of getting first the active workspace
and then its index.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:09 +02:00
bdf6af3ee3
window-list: Update workspace names in-place
...
There's no good reason to rebuild the entire menu on workspace names
changes, we can simply update the labels in-place.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:09 +02:00
1532c15325
window-list: Make some properties private
...
There's no reason why they should be public.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:09 +02:00
cbd1b7d983
window-list: Use a more specific GTypeName for workspace indicator
...
Now that the class inherits from GObject, the generic name easily
conflicts with other classes otherwise, for example with the one
from the workspace-indicator extension.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:09 +02:00
4b9c53ff2e
window-list: Split out workspaceIndicator
...
The extension has grown unwieldily big, so before starting to improve
on the workspace indicator, move it to its own source file.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/70
2019-07-19 13:11:09 +02:00
6eb3a62e2b
apps-menu: Add drop-shadow to application icons
...
... to make sure they are readable on light backgrounds.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/168
2019-07-18 11:17:04 +00:00
ae1b17d29c
classic: Update window-list styling
...
Make buttons flatter, rounder to match default styling.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/82
2019-07-16 11:17:11 +02:00
f2b261c573
window-list: Handle closing window picker with Escape
...
Just like the overview can be closed with Escape, it makes sense to
allow the same for the window picker (in addition to pressing super
repeatedly).
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/80
2019-07-02 21:20:01 +02:00
6c49ca825c
window-list: Move super-key handling into WindowPicker
...
We have an option to put a window list on each monitor, so we may have
more than one window picker toggle. We don't want each of those try to
toggle the window picker simultanuously, so move handling of the super
key directly into the picker.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/80
2019-07-02 21:20:01 +02:00
2ef6dba0a5
window-list: Fix resetting handler ID
...
This is embarrassing, although destroy() is expected to only run once,
so the bug shouldn't have an effect in practice.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/78
2019-06-29 02:56:33 +02:00
92db87f7cb
window-list: Add window picker button
...
With the latest changes, GNOME Classic has become so classic that it
is bordering dull. Salvage at least a tiny piece of GNOME 3 in form
of a window-pick button which toggles an exposé-like reduced overview.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/73
2019-06-28 23:02:58 +02:00
545b811562
apps-menu: Hide overview when launching app
...
Now that we no longer hide the overview when the menu is opened,
it is possible to activate menu entries from the overview. Start
hiding the overview in that case, which is consistent with app
launching elsewhere.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/69
2019-06-28 20:55:28 +00:00
d99d0a06bd
apps-menu: Stop hiding the overview when toggled
...
Now that the extension no longer doubles as the "Activities" button,
that behavior is confusing.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/69
2019-06-28 20:55:28 +00:00
6105eecff2
apps-menu: Stop taking over Activities button
...
We don't want the "Activities" button in GNOME Classic, but the current
way of handling it is confusing:
- the button is hidden, but the corresponding hot corner
sometimes works (when the application menu isn't open)
- the button is effectively moved inside the menu, although
it's clearly not an app or category
- the apps-menu can be used independent from classic mode, in
which case removing the "Activities" button may not be wanted
Address those points by removing any handling of the activities button
from the apps-menu extension. We will remove it again from the classic
session via a session mode tweak.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/69
2019-06-28 20:55:28 +00:00
d1254d9b57
places-menu: Don't hardcode position
...
The extension currently assumes that we have the "Activities" button
at the left of the top bar. This is currently true, not only in the
regular session, but also in GNOME classic where the button is hidden
(but still present).
However this is about to change: We will stop taking over the button
from the apps-menu extension, and instead disable "Activities" from
the session mode definition.
Prepare for this by adding the places menu before the application menu
instead of assuming a hardcoded position.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/69
2019-06-28 20:55:28 +00:00
2db4589dea
cleanup: Re-order imports
...
They should be grouped between external (GI/gjs) and shell and in
alphabetical order. Until commit bab4be1ahttps://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/76
2019-06-28 21:51:38 +02:00
dfeb99fc0a
apps-menu: Add missing chain-up
...
PanelMenu.Button is a bit weird in that it also "contains" its parent
actor. That container is supposed to be destroyed with the button, but
as we currently don't chain up to the parent class' _onDestroy(), we
leave behind an empty container every time the extension is disabled.
Fix this by adding the missing chain-up.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/75
2019-06-27 04:26:35 +02:00
14859b4009
window-list: Pass the actor as PopupMenuManager owner
...
PopupMenuManager's grabHelper starting from gnome-shell@7bb84da must be
an actor, so pass it explicitly instead of expecting the shell to do it
for us.
This fixes an error during pushModal that was causing a grab not to be
released.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/68
2019-05-29 14:45:43 -05:00
3a596054ad
places-menu: Adjust to GObject-ification of menu items
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/67
2019-05-29 09:38:21 +00:00
65191d83b4
drive-menu: Adjust to GObject-ification of menu items
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/67
2019-05-29 09:38:21 +00:00
8499b0e254
apps-menu: Adjust to GObject-ification of menu items
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/67
2019-05-29 09:38:21 +00:00
f166ca501f
window-list: Stop using deprecated actor property
...
Since PanelMenu.Button was changed to inherit from St.Widget, its actor
property is deprecated and points to itself. Stop using it to avoid the
corresponding warning.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/67
2019-05-29 09:38:21 +00:00
ad914441a2
window-list: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:19 +02:00
200d337769
apps-menu: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:19 +02:00
e56f1a976e
native-window-placement: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:19 +02:00
6a66cd4fa6
places-menu: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:19 +02:00
55c493389a
auto-move-windows: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:18 +02:00
06f1303834
drive-menu: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:18 +02:00
3d5687ae3c
workspace-indicator: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:18 +02:00
cdd3fba593
screenshot-window-sizer: Reindent to conform with new style
...
Instead of aligning arguments like we used to do, use a consistent
four-space indent as mandated by gjs' current style guide.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/66
2019-05-22 20:40:18 +02:00
7c412ca7d9
window-list: Don't use anchor point
...
It is deprecated and we can easily replace it with a translation.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/64
2019-04-28 11:08:02 +00:00
5b43d4733c
screenshot-window-sizer: Add phone screenshot sizes
...
This is going to be convenient to take fake screenshots for phones like
the Librem 5.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/65
2019-04-12 14:31:53 +02:00
3671d5a299
cleanup: Use an extension object instead of globals
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/143
2019-04-08 06:00:29 +00:00
a024d9f005
windowsNavigator: Use subclasses instead of injections
...
gnome-shell moved to ES6 classes, which means the constructor is
no longer a regular method that we can swap out with an injected
version.
Instead, do our modifications in subclasses and use them to replace
the original classes.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/143
2019-04-08 06:00:29 +00:00
a26380d56e
user-theme: Clarify some code
...
Commit 2582ab accidentally pointed out that the current theme loading code
obfuscates which directories are searched for themes. Rewrite it with modern
JS features to make it more obvious.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:18 +01:00
ab334d95e0
Revert "User theme: compatibility with XDG Base Directory"
...
We already handled themes in XDG_DATA_HOME before commit 2582ab
by prepending it to the system dirs.
This reverts commit 2582ab4fd0https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
7e5726e632
apps-menu: Promisify marking file as trusted
...
Use async/await to make nested operations easier to read.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
95b40069bf
apps-menu: Remove unnecessary check
...
The function is always called with an array parameter (albeit it may
be empty), so remove the unnecessary check and cut down on indentation.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
bd9f1cfd91
apps-menu: Avoid deep nesting
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
81548ced69
native-window-placement: Clarify some code
...
Add some intermediate variables for better legibility.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
a378e5fc34
placesDisplay: Promisify launching
...
Use async/await to make nested async operations easier to read.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
56d19ad480
placesMenu: Add early return to reduce indentation level
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
a071685c13
auto-move-windows: Clarify some code
...
Apply some tricks to align column numbers with their corresponding
values for better legibility.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
599428d292
auto-move-windows: De-duplicate row appending
...
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
1f1f9664a6
cleanup: Share unmount/eject arugments
...
Besides the callback, eject and unmount share the same arguments.
Make this explicit by sharing the common arguments between branches.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
fb039c0fb5
cleanup: Use Meta.MaximizeFlags.BOTH
...
This shorthand has been around for a long time, use it make (un)maximize
code more readable.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60
2019-03-04 19:35:10 +01:00
d83d6e857a
style: Use single-quotes for translated strings
...
The coding style of using double quotes for translatable strings
and single quotes otherwise is unnecessarily complex and cannot
be enforced with an eslint rule.
Simply use single quotes consistently for all strings.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
2019-02-28 23:29:31 +01:00
db35d7ae7c
style: Change indentation style of object literals
...
Instead of keeping the first property on the same line as the opening
brace and aligning the properties, use a four-space indent. This brings
us closer to gjs' coding style, and as a bonus helps keeping lines in
the soft 80 character limit.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/57
2019-02-28 23:29:24 +01:00
Florian Müllner
Jakub Steiner
Marco Trevisan (Treviño)
Adrien Plazas