From f6f34c634174845d0ef1b0dc1ea8293f0f62f88d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 14 Feb 2022 18:39:13 +0100 Subject: [PATCH] ci: Replace js78 job Provided we use the correct version of the SpiderMonkey shell, we can perform checks using the same engine that is used by gjs. However some engine features are opt-in, so the set of features enabled by gjs and js91 may differ. The obvious option for avoiding this is replacing js91 with gjs for tests. Switch to the newly added gjs-check-syntax script, which does precisely that. Part-of: --- .gitlab-ci.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b4a0f7f9..9a9ba426 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -26,7 +26,6 @@ default: variables: FDO_UPSTREAM_REPO: GNOME/gnome-shell-extensions LINT_LOG: "eslint-report.xml" - JS_LOG: "js-report.txt" workflow: rules: @@ -103,12 +102,7 @@ js_check: stage: review <<: *prereview_req script: - - find extensions -name '*.js' -exec js78 -c '{}' ';' 2>&1 | tee $JS_LOG - - (! grep -q . $JS_LOG) - artifacts: - paths: - - ${JS_LOG} - when: on_failure + - gjs-check-syntax eslint: stage: review