From f59ab1272d1ca8d599f0c2591286e8c54ff9f2b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 10 May 2018 18:56:23 +0200 Subject: [PATCH] drive-menu: Disconnect volume monitor signals The handler IDs were renamed at some point, resulting in the signals not being disconnected on disable. --- extensions/drive-menu/extension.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/drive-menu/extension.js b/extensions/drive-menu/extension.js index 3c3dbe8c..d4135428 100644 --- a/extensions/drive-menu/extension.js +++ b/extensions/drive-menu/extension.js @@ -175,11 +175,11 @@ class DriveMenu extends PanelMenu.Button { } destroy() { - if (this._connectedId) { - this._monitor.disconnect(this._connectedId); - this._monitor.disconnect(this._disconnectedId); - this._connectedId = 0; - this._disconnectedId = 0; + if (this._addedId) { + this._monitor.disconnect(this._addedId); + this._monitor.disconnect(this._removedId); + this._addedId = 0; + this._removedId = 0; } super.destroy();