From ee85839d607ca71a9e3b8e7a356d83f79d407d96 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 10 Oct 2018 20:50:54 +0200 Subject: [PATCH] drive-menu: Don't override ClutterActor.destroy() Now that PanelMenu.Button was made an StWidget subclass, the destroy() method actually maps to the ClutterActor method, and overriding it results in warnings when the extension is disabled. So instead, use the existing ::destroy handler. https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/113 --- extensions/drive-menu/extension.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/drive-menu/extension.js b/extensions/drive-menu/extension.js index eaa15dfe..c8ec0c34 100644 --- a/extensions/drive-menu/extension.js +++ b/extensions/drive-menu/extension.js @@ -176,7 +176,7 @@ class DriveMenu extends PanelMenu.Button { log ('Removing a mount that was never added to the menu'); } - destroy() { + _onDestroy() { if (this._addedId) { this._monitor.disconnect(this._addedId); this._monitor.disconnect(this._removedId); @@ -184,7 +184,7 @@ class DriveMenu extends PanelMenu.Button { this._removedId = 0; } - super.destroy(); + super._onDestroy(); } });