VesperOS/gnome-shell-extensions
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

workspace-indicator: Simplify scroll handling

Browse Source 
gnome-shell already includes a method for switching workspaces
via scroll events. Use that instead of implementing our own.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/316>
This commit is contained in:
Florian Müllner
2024-02-20 17:39:49 +01:00
parent 0c42f162d3
commit b55e7a4dc8
1 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/workspace-indicator/workspaceIndicator.js
+4 -17
View File
@@ -300,8 +300,10 @@ export class WorkspaceIndicator extends PanelMenu.Button {
'notify::layout-rows', this._updateThumbnailVisibility.bind(this),
this);
this.connect('scroll-event', this._onScrollEvent.bind(this));
this._thumbnailsBox.connect('scroll-event', this._onScrollEvent.bind(this));
this.connect('scroll-event',
(a, event) => Main.wm.handleWorkspaceScroll(event));
this._thumbnailsBox.connect('scroll-event',
(a, event) => Main.wm.handleWorkspaceScroll(event));
this._inTopBar = false;
this.connect('notify::realized', () => {
@@ -445,19 +447,4 @@ export class WorkspaceIndicator extends PanelMenu.Button {
metaWorkspace.activate(global.get_current_time());
}
}
_onScrollEvent(actor, event) {
let direction = event.get_scroll_direction();
let diff = 0;
if (direction === Clutter.ScrollDirection.DOWN)
diff = 1;
else if (direction === Clutter.ScrollDirection.UP)
diff = -1;
else
return;
const newIndex = this._currentWorkspace + diff;
this._activate(newIndex);
}
}