From a071685c1336538e888e643b7f3f9b2ae7e73bec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sun, 3 Mar 2019 00:07:42 +0100 Subject: [PATCH] auto-move-windows: Clarify some code Apply some tricks to align column numbers with their corresponding values for better legibility. https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/60 --- extensions/auto-move-windows/prefs.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/extensions/auto-move-windows/prefs.js b/extensions/auto-move-windows/prefs.js index 57628097..f9c4699e 100644 --- a/extensions/auto-move-windows/prefs.js +++ b/extensions/auto-move-windows/prefs.js @@ -221,17 +221,20 @@ const Widget = GObject.registerClass({ this._settings.set_strv(SETTINGS_KEY, validItems); } - _appendRow(appInfo, index) { + _appendRow(appInfo, workspace) { let iter = this._store.append(); + let icon = appInfo.get_icon(); + let displayName = appInfo.get_display_name(); let adj = new Gtk.Adjustment({ lower: 1, upper: WORKSPACE_MAX, step_increment: 1, - value: index + value: workspace }); + let { APPINFO, ICON, DISPLAY_NAME, WORKSPACE, ADJUSTMENT } = Columns; this._store.set(iter, - [Columns.APPINFO, Columns.ICON, Columns.DISPLAY_NAME, Columns.WORKSPACE, Columns.ADJUSTMENT], - [appInfo, appInfo.get_icon(), appInfo.get_display_name(), index, adj]); + [APPINFO, ICON, DISPLAY_NAME, WORKSPACE, ADJUSTMENT], + [appInfo, icon, displayName, workspace, adj]); } _checkId(id) {