From 91c9982d7fc058891a9a3bf6b28c84797ba36b40 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sat, 10 Aug 2019 17:04:05 +0200 Subject: [PATCH] workspace-indicator: Remove some inactive code This code has been commented out since it was added, presumably due to difficulty in avoiding a cycle of reloading rows on settings changes and writing settings on row changes. Considering that the setting changing while the preference dialog is up is extremely unlikely, don't bother with making it work and just remove the dead code. https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/91 --- extensions/workspace-indicator/prefs.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/extensions/workspace-indicator/prefs.js b/extensions/workspace-indicator/prefs.js index d8640559..cf23621c 100644 --- a/extensions/workspace-indicator/prefs.js +++ b/extensions/workspace-indicator/prefs.js @@ -23,8 +23,6 @@ class WorkspaceNameModel extends Gtk.ListStore { }; this._settings = new Gio.Settings({ schema_id: WORKSPACE_SCHEMA }); - //this._settings.connect('changed::workspace-names', this._reloadFromSettings.bind(this)); - this._reloadFromSettings(); // overriding class closure doesn't work, because GtkTreeModel