From 132b3b0509e534babec7976be0af820e74441f75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 10 Oct 2018 16:23:05 +0200 Subject: [PATCH] places-menu: Don't override ClutterActor.destroy() Now that PanelMenu.Button was made an StWidget subclass, the destroy() method actually maps to the ClutterActor method, and overriding it results in warnings when the extension is disabled. So instead, use the existing ::destroy handler. https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/113 --- extensions/places-menu/extension.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/places-menu/extension.js b/extensions/places-menu/extension.js index 94747b17..a83513ab 100644 --- a/extensions/places-menu/extension.js +++ b/extensions/places-menu/extension.js @@ -105,10 +105,10 @@ class PlacesMenu extends PanelMenu.Button { } } - destroy() { + _onDestroy() { this.placesManager.destroy(); - super.destroy(); + super._onDestroy(); } _redisplay(id) {