From 789dc7d737ed9207a69657449ddddf07823912cc Mon Sep 17 00:00:00 2001 From: Gabriele M Date: Mon, 3 Jul 2017 16:08:32 +0200 Subject: [PATCH] Rename DownloadController's newInstance() to getInstance() Also, make both the instance getters synchronized. --- src/org/lineageos/updater/DownloadController.java | 4 ++-- src/org/lineageos/updater/DownloadService.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/org/lineageos/updater/DownloadController.java b/src/org/lineageos/updater/DownloadController.java index b5e9afb8..2aaef056 100644 --- a/src/org/lineageos/updater/DownloadController.java +++ b/src/org/lineageos/updater/DownloadController.java @@ -51,11 +51,11 @@ public class DownloadController implements DownloadControllerInt { private final File mDownloadRoot; - public static DownloadController getInstance() { + public static synchronized DownloadController getInstance() { return sDownloadController; } - public static synchronized DownloadController newInstance(Context context) { + public static synchronized DownloadController getInstance(Context context) { if (sDownloadController == null) { sDownloadController = new DownloadController(context); } diff --git a/src/org/lineageos/updater/DownloadService.java b/src/org/lineageos/updater/DownloadService.java index c4815a99..c9a46084 100644 --- a/src/org/lineageos/updater/DownloadService.java +++ b/src/org/lineageos/updater/DownloadService.java @@ -52,7 +52,7 @@ public class DownloadService extends Service { public void onCreate() { super.onCreate(); - mDownloadController = DownloadController.newInstance(this); + mDownloadController = DownloadController.getInstance(this); mNotificationManager = (NotificationManager) getSystemService(NOTIFICATION_SERVICE); mNotificationBuilder = new NotificationCompat.Builder(this);