PawletOS/lineageos_updater
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gen-keystore.sh: Don't pass the passwords as args

Browse Source 
Also mention that the password is saved in clear text.

Change-Id: Ia7bf8b1b85193aa76b541dc5c6ee99a471d12f92
This commit is contained in:
Gabriele M
2018-04-09 12:41:30 +02:00
parent d5f4c1bcec
commit 6c0aa8118e
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
gen-keystore.sh
View File

@@ -1,30 +1,33 @@
#!/bin/sh #!/bin/bash
if [ $# -ne 6 ]; then if [ $# -ne 4 ]; then
echo "Usage: `basename $0` PRIVATE_KEY CERTIFICATE \\" echo "Usage: `basename $0` PRIVATE_KEY CERTIFICATE \\"
echo " KEYSTORE_PASSWRD KEY_PASSWORD KEY_ALIAS \\" echo " KEY_ALIAS OUTPUT_KEYSTORE_PATH"
echo " OUTPUT_KEYSTORE_PATH"
echo echo
echo "Example:" echo "Example:"
echo " `basename $0` \\" echo " `basename $0` \\"
echo " ../../../build/target/product/security/testkey.pk8 \\" echo " ../../../build/target/product/security/testkey.pk8 \\"
echo " ../../../build/target/product/security/testkey.x509.pem \\" echo " ../../../build/target/product/security/testkey.x509.pem \\"
echo " keystore-password key-password android testkey.jks" echo " android testkey.jks"
exit 0 exit 0
fi fi
PRIVATE_KEY="$1" PRIVATE_KEY="$1"
CERTIFICATE="$2" CERTIFICATE="$2"
KEYSTORE_PASSWORD="$3" KEY_ALIAS="$3"
KEY_PASSWORD="$4" KEYSTORE_PATH="$4"
KEY_ALIAS="$5"
KEYSTORE_PATH="$6"
if [ -f "$KEYSTORE_PATH" ]; then if [ -f "$KEYSTORE_PATH" ]; then
echo "$KEYSTORE_PATH already exists" echo "$KEYSTORE_PATH already exists"
exit 1 exit 1
fi fi
echo "The passwords will be stored in clear text"
read -p "Enter new keystore password: " -s KEYSTORE_PASSWORD
echo
read -p "Enter new key password: " -s KEY_PASSWORD
echo
tmpdir=`mktemp -d` tmpdir=`mktemp -d`
trap 'rm -rf $tmpdir;' 0 trap 'rm -rf $tmpdir;' 0