We were using the SubBaseActivity class for two different kind of
activities:
(1) "Wrapper" activities, where we define an activity that on
start simply launches another one
(2) "Interactive" activities, where the user has to manually
trigger the start of the subactivity, or skip the step.
When the subactivity ends, only in case (1) we want to finish our
activity as well, since we wouldn't have anything to show.
Change-Id: I1a3ae51f6146ac32b5e7542d9a18b0b032efe144
Set slide animation by default and use it in all pages.
Fix wrong/missing slide animations on various transitions like WiFi
and the backup subpage.
Change-Id: I78c87f38eb615379d39c89b43a016ed2ffb98695
The captive_portal_server setting is deprecated, and hard-wiring it as a
string is also probably a bad idea. Since it's deprecated, this code
will miss an override via the modern settings. This also hard-wired a
slightly different fallback than ConnectivityService, and simply
adjusting it here wouldn't stop that from happening again. It's best to
just use the privileged API for obtaining the proper value. The choice
of LOCAL_MAC_ADDRESS as the permission for this is a bit strange, but
that's what is required, probably because a better fit didn't exist.
Change-Id: I78d07d5ff96598cebf6d4ed032fe1516791836fe
