From 34f8727f28700e9b01efc21f540be15d2b625a70 Mon Sep 17 00:00:00 2001 From: illiliti Date: Sun, 6 Jun 2021 09:14:56 +0300 Subject: [PATCH] udev_device.c: use strrchr to trim newline --- udev_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/udev_device.c b/udev_device.c index e48f9b6..c61aab2 100644 --- a/udev_device.c +++ b/udev_device.c @@ -243,6 +243,7 @@ const char *udev_device_get_sysattr_value(struct udev_device *udev_device, const struct stat st; size_t len; FILE *file; + char *pos; if (!udev_device || !sysattr) { return NULL; @@ -277,9 +278,8 @@ const char *udev_device_get_sysattr_value(struct udev_device *udev_device, const fclose(file); data[len] = '\0'; - // TODO strrchr? - while (len-- > 0 && data[len] == '\n') { - data[len] = '\0'; + if ((pos = strrchr(data, '\n'))) { + *pos = '\0'; } list_entry = udev_list_entry_add(&udev_device->sysattrs, sysattr, data, 0);