ff2ee0174c
The fromEntityName() function returns a pointer to a newly allocated V4L2Subdevice instance, which must be deleted by the caller. This opens the door to memory leaks. Return a unique pointer instead, which conveys the API semantics better than a sentence in the documentation. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
81 lines
1.9 KiB
C++
81 lines
1.9 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* v4l2_subdevice.h - V4L2 Subdevice
|
|
*/
|
|
#ifndef __LIBCAMERA_INTERNAL_V4L2_SUBDEVICE_H__
|
|
#define __LIBCAMERA_INTERNAL_V4L2_SUBDEVICE_H__
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include <libcamera/geometry.h>
|
|
|
|
#include "libcamera/internal/formats.h"
|
|
#include "libcamera/internal/log.h"
|
|
#include "libcamera/internal/media_object.h"
|
|
#include "libcamera/internal/v4l2_device.h"
|
|
|
|
namespace libcamera {
|
|
|
|
class MediaDevice;
|
|
|
|
struct V4L2SubdeviceFormat {
|
|
uint32_t mbus_code;
|
|
Size size;
|
|
|
|
const std::string toString() const;
|
|
uint8_t bitsPerPixel() const;
|
|
};
|
|
|
|
class V4L2Subdevice : public V4L2Device
|
|
{
|
|
public:
|
|
using Formats = std::map<unsigned int, std::vector<SizeRange>>;
|
|
|
|
enum Whence {
|
|
ActiveFormat,
|
|
TryFormat,
|
|
};
|
|
|
|
explicit V4L2Subdevice(const MediaEntity *entity);
|
|
V4L2Subdevice(const V4L2Subdevice &) = delete;
|
|
V4L2Subdevice &operator=(const V4L2Subdevice &) = delete;
|
|
~V4L2Subdevice();
|
|
|
|
int open();
|
|
|
|
const MediaEntity *entity() const { return entity_; }
|
|
|
|
int getSelection(unsigned int pad, unsigned int target,
|
|
Rectangle *rect);
|
|
int setSelection(unsigned int pad, unsigned int target,
|
|
Rectangle *rect);
|
|
|
|
Formats formats(unsigned int pad);
|
|
|
|
int getFormat(unsigned int pad, V4L2SubdeviceFormat *format,
|
|
Whence whence = ActiveFormat);
|
|
int setFormat(unsigned int pad, V4L2SubdeviceFormat *format,
|
|
Whence whence = ActiveFormat);
|
|
|
|
static std::unique_ptr<V4L2Subdevice>
|
|
fromEntityName(const MediaDevice *media, const std::string &entity);
|
|
|
|
protected:
|
|
std::string logPrefix() const override;
|
|
|
|
private:
|
|
std::vector<unsigned int> enumPadCodes(unsigned int pad);
|
|
std::vector<SizeRange> enumPadSizes(unsigned int pad,
|
|
unsigned int code);
|
|
|
|
const MediaEntity *entity_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|
|
|
|
#endif /* __LIBCAMERA_INTERNAL_V4L2_SUBDEVICE_H__ */
|