Laurent Pinchart
626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
95 lines
2.5 KiB
C++
95 lines
2.5 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2021-2022, Ideas On Board
|
|
*
|
|
* RkISP1 Black Level Correction control
|
|
*/
|
|
|
|
#include "blc.h"
|
|
|
|
#include <libcamera/base/log.h>
|
|
|
|
#include "libcamera/internal/yaml_parser.h"
|
|
|
|
/**
|
|
* \file blc.h
|
|
*/
|
|
|
|
namespace libcamera {
|
|
|
|
namespace ipa::rkisp1::algorithms {
|
|
|
|
/**
|
|
* \class BlackLevelCorrection
|
|
* \brief RkISP1 Black Level Correction control
|
|
*
|
|
* The pixels output by the camera normally include a black level, because
|
|
* sensors do not always report a signal level of '0' for black. Pixels at or
|
|
* below this level should be considered black. To achieve that, the RkISP BLC
|
|
* algorithm subtracts a configurable offset from all pixels.
|
|
*
|
|
* The black level can be measured at runtime from an optical dark region of the
|
|
* camera sensor, or measured during the camera tuning process. The first option
|
|
* isn't currently supported.
|
|
*/
|
|
|
|
LOG_DEFINE_CATEGORY(RkISP1Blc)
|
|
|
|
BlackLevelCorrection::BlackLevelCorrection()
|
|
: tuningParameters_(false)
|
|
{
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::init
|
|
*/
|
|
int BlackLevelCorrection::init([[maybe_unused]] IPAContext &context,
|
|
const YamlObject &tuningData)
|
|
{
|
|
blackLevelRed_ = tuningData["R"].get<int16_t>(256);
|
|
blackLevelGreenR_ = tuningData["Gr"].get<int16_t>(256);
|
|
blackLevelGreenB_ = tuningData["Gb"].get<int16_t>(256);
|
|
blackLevelBlue_ = tuningData["B"].get<int16_t>(256);
|
|
|
|
tuningParameters_ = true;
|
|
|
|
LOG(RkISP1Blc, Debug)
|
|
<< "Black levels: red " << blackLevelRed_
|
|
<< ", green (red) " << blackLevelGreenR_
|
|
<< ", green (blue) " << blackLevelGreenB_
|
|
<< ", blue " << blackLevelBlue_;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::prepare
|
|
*/
|
|
void BlackLevelCorrection::prepare([[maybe_unused]] IPAContext &context,
|
|
const uint32_t frame,
|
|
[[maybe_unused]] IPAFrameContext &frameContext,
|
|
rkisp1_params_cfg *params)
|
|
{
|
|
if (frame > 0)
|
|
return;
|
|
|
|
if (!tuningParameters_)
|
|
return;
|
|
|
|
params->others.bls_config.enable_auto = 0;
|
|
params->others.bls_config.fixed_val.r = blackLevelRed_;
|
|
params->others.bls_config.fixed_val.gr = blackLevelGreenR_;
|
|
params->others.bls_config.fixed_val.gb = blackLevelGreenB_;
|
|
params->others.bls_config.fixed_val.b = blackLevelBlue_;
|
|
|
|
params->module_en_update |= RKISP1_CIF_ISP_MODULE_BLS;
|
|
params->module_ens |= RKISP1_CIF_ISP_MODULE_BLS;
|
|
params->module_cfg_update |= RKISP1_CIF_ISP_MODULE_BLS;
|
|
}
|
|
|
|
REGISTER_IPA_ALGORITHM(BlackLevelCorrection, "BlackLevelCorrection")
|
|
|
|
} /* namespace ipa::rkisp1::algorithms */
|
|
|
|
} /* namespace libcamera */
|