Mattijs KorpershoekandKieran Bingham 3dc2605bda libcamera: controls: guard ControlInfoMap against nullptr idmap_ ...

It's possible to construct a Camera with an unsafe controlInfo_.
This is the case in the Simple pipeline, where the camera controls are
not populated.

With Simple, if we attempt to set a Control, we end up with a segfault
because the default constructor for ControlInfoMap doesn't
intialized idmap_ which is initialized at class declaration time as

  const ControlIdMap *idmap_ = nullptr;

Add some safeguards in ControlInfoMap to handle this case.

Link: https://lists.libcamera.org/pipermail/libcamera-devel/2023-April/037439.html
Suggested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

2023-04-20 10:54:12 +01:00

..

base

libcamera: Open files with O_CLOEXEC

2023-04-05 07:18:30 +03:00

converter

libcamera: pipeline: simple: converter: Use generic converter interface

2022-12-14 16:19:52 +00:00

ipa

meson: ipa: Build documentation cpp files from mojom files

2021-05-27 18:21:49 +09:00

pipeline

libcamera: Open files with O_CLOEXEC

2023-04-05 07:18:30 +03:00

proxy

libcamera/base: Validate internal headers as private

2021-06-25 16:11:11 +01:00

bayer_format.cpp

libcamera: formats: Add 14-bits Bayer RAW formats

2023-04-18 17:28:39 +02:00

byte_stream_buffer.cpp

libcamera: Rename 'method' to 'function'

2021-08-09 15:40:32 +03:00

camera_controls.cpp

libcamera: camera: Rename name() to id()

2020-08-05 20:07:13 +02:00

camera_lens.cpp

libcamera: camera_lens: Add function to fetch subdev controls

2022-03-15 17:20:59 +00:00

camera_manager.cpp

libcamera: camera_manager: Stop exponential explosive calls to createPipelineHandlers

2023-03-06 14:35:17 +02:00

camera_sensor_properties.cpp

ipa: libipa: Add OV2685 Camera Sensor Helper

2023-03-21 23:40:41 +00:00

camera_sensor.cpp

libcamera: Remove transform from V4L2SubdeviceFormat

2023-02-09 23:40:15 +01:00

camera.cpp

libcamera: camera: Ensure queued requests are invalid

2023-03-21 23:47:59 +00:00

color_space.cpp

libcamera: color_space: Move color space adjustment to ColorSpace class

2022-09-01 16:49:59 +05:30

control_ids.cpp.in

libcamera: controls: Generate an array of valid values

2020-10-26 17:51:55 +01:00

control_ids.yaml

libcamera: controls: Change LensPosition units to dioptres

2022-12-08 11:36:02 +00:00

control_serializer.cpp

libcamera: control_serializer: store/load all ControlValue types

2022-09-12 18:28:59 +09:00

control_validator.cpp

libcamera: Rename 'method' to 'function'

2021-08-09 15:40:32 +03:00

controls.cpp

libcamera: controls: guard ControlInfoMap against nullptr idmap_

2023-04-20 10:54:12 +01:00

converter.cpp

libcamera: converter: Check converter validity

2023-03-09 18:40:40 +02:00

delayed_controls.cpp

raspberrypi: Update Copyright statement in all Raspberry Pi source files

2022-07-27 18:12:15 +03:00

device_enumerator_sysfs.cpp

libcamera/base: Move extended base functionality

2021-06-25 16:11:08 +01:00

device_enumerator_udev.cpp

libcamera: device_enumerator_udev: Use std::string_view

2023-04-19 11:04:31 +03:00

device_enumerator.cpp

libcamera: Use const reference for range loops

2022-08-25 14:03:22 +02:00

fence.cpp

libcamera: fence: Introduce Fence

2021-12-11 17:53:40 +01:00

formats.c

libcamera: formats: Add 14-bits Bayer RAW formats

2023-04-18 17:28:39 +02:00

formats.cpp

libcamera: formats: Add 14-bits Bayer RAW formats

2023-04-18 17:28:39 +02:00

formats.yaml

libcamera: formats: Add 14-bits Bayer RAW formats

2023-04-18 17:28:39 +02:00

framebuffer_allocator.cpp

libcamera: framebuffer_allocator: Avoid double map lookup

2022-11-28 16:11:20 +02:00

framebuffer.cpp

libcamera: framebuffer: Move remaining private data to Private class

2022-10-10 17:49:49 +03:00

geometry.cpp

libcamera: geometry: Correct the string representation of Rectangle

2022-04-22 00:38:54 +03:00

ipa_controls.cpp

libcamera: ipa: Move IPA control serialization structures to libcamera namespace

2022-05-27 16:07:01 +03:00

ipa_data_serializer.cpp

libcamera: base: Rename FileDescriptor to SharedFD

2021-12-04 23:05:05 +02:00

ipa_interface.cpp

libcamera: Rename 'method' to 'function'

2021-08-09 15:40:32 +03:00

ipa_manager.cpp

libcamera: ipa_manager: Fix build without openssl

2022-09-15 16:13:40 +05:30

ipa_module.cpp

libcamera: ipa_module: Relax ipaModuleInfo symbol size check

2023-01-16 18:32:50 +02:00

ipa_proxy.cpp

libcamera: Rename 'method' to 'function'

2021-08-09 15:40:32 +03:00

ipa_pub_key.cpp.in

libcamera: Move internal headers to include/libcamera/internal/

2020-05-16 03:38:11 +03:00

ipc_pipe_unixsocket.cpp

libcamera: base: timer: Drop start() overload with int argument

2022-03-25 13:11:12 +02:00

ipc_pipe.cpp

libcamera: base: shared_fd: Rename fd() to get()

2021-12-04 23:05:07 +02:00

ipc_unixsocket.cpp

libcamera: ipc_unixsocket: Use UniqueFD for a file descriptor

2021-12-04 23:05:03 +02:00

mapped_framebuffer.cpp

libcamera: base: shared_fd: Rename fd() to get()

2021-12-04 23:05:07 +02:00

media_device.cpp

libcamera: Open files with O_CLOEXEC

2023-04-05 07:18:30 +03:00

media_object.cpp

libcamera: Add members to MediaEntity to support ancillary entities

2022-03-15 17:20:59 +00:00

meson.build

meson: libcamera: Report IPA signature method

2023-03-21 23:45:35 +00:00

pipeline_handler.cpp

libcamera: pipeline: Add a platform configuration file helper

2023-01-31 16:54:36 +00:00

pixel_format.cpp

libcamera: Add operator<<() for pixel format classes

2022-05-04 14:11:30 +03:00

process.cpp

libcamera: Keep using syslog for isolated IPA modules

2023-03-01 16:46:08 +01:00

property_ids.cpp.in

libcamera: Support draft controls and properties

2020-10-26 17:51:54 +01:00

property_ids.yaml

utils: gen-controls: Improve YAML notation for variable-size array controls

2022-10-07 18:28:05 +03:00

pub_key.cpp

libcamera: pub_key: Support openssl as an alternative to gnutls

2022-08-09 16:05:58 +03:00

request.cpp

libcamera: request: Rename Private::reuse() to Private::reset()

2022-08-31 20:51:31 +05:30

source_paths.cpp

libcamera/base: Move utils to the base library

2021-06-25 16:11:02 +01:00

stream.cpp

libcamera: stream: Add operator<<() to print StreamRole as a string

2022-11-25 10:52:05 +02:00

sysfs.cpp

libcamera/base: Move File to base library

2021-06-25 16:11:10 +01:00

tracepoints.cpp

libcamera: tracing: Implement tracing infrastructure

2020-11-03 11:07:21 +09:00

transform.cpp

raspberrypi: Update Copyright statement in all Raspberry Pi source files

2022-07-27 18:12:15 +03:00

v4l2_device.cpp

libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after exec(3)

2023-03-26 11:48:18 +03:00

v4l2_pixelformat.cpp

libcamera: formats: Add 14-bits Bayer RAW formats

2023-04-18 17:28:39 +02:00

v4l2_subdevice.cpp

libcamera: Remove transform from V4L2SubdeviceFormat

2023-02-09 23:40:15 +01:00

v4l2_videodevice.cpp

libcamera: v4l2_videodevice: Reduce zero sequence warning log level

2022-11-14 11:03:32 +00:00

version.cpp.in

libcamera: Rework automatic version generation to avoid rebuilds

2019-07-09 12:34:10 +03:00

yaml_parser.cpp

base: utils: Add and use strtod() helper

2023-01-10 15:39:18 +02:00