362301b131
The existing framerate/vblank calculations did not account for the sensor mode limits. This commit extracts vblank limits from the sensor v4l2 controls, and stores it in the camera modes structure. Exposure and vblank value calculations now use values clamped to the sensor mode limits. The libcamera::controls::FrameDurations metadata return values now reflect the minimum and maximum after clamping. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
143 lines
3.3 KiB
C++
143 lines
3.3 KiB
C++
/* SPDX-License-Identifier: BSD-2-Clause */
|
|
/*
|
|
* Copyright (C) 2019, Raspberry Pi (Trading) Limited
|
|
*
|
|
* cam_helper.cpp - helper information for different sensors
|
|
*/
|
|
|
|
#include <linux/videodev2.h>
|
|
|
|
#include <assert.h>
|
|
#include <map>
|
|
#include <string.h>
|
|
|
|
#include "libcamera/internal/v4l2_videodevice.h"
|
|
|
|
#include "cam_helper.hpp"
|
|
#include "md_parser.hpp"
|
|
|
|
using namespace RPiController;
|
|
|
|
static std::map<std::string, CamHelperCreateFunc> cam_helpers;
|
|
|
|
CamHelper *CamHelper::Create(std::string const &cam_name)
|
|
{
|
|
/*
|
|
* CamHelpers get registered by static RegisterCamHelper
|
|
* initialisers.
|
|
*/
|
|
for (auto &p : cam_helpers) {
|
|
if (cam_name.find(p.first) != std::string::npos)
|
|
return p.second();
|
|
}
|
|
|
|
return nullptr;
|
|
}
|
|
|
|
CamHelper::CamHelper(MdParser *parser, unsigned int frameIntegrationDiff)
|
|
: parser_(parser), initialized_(false),
|
|
frameIntegrationDiff_(frameIntegrationDiff)
|
|
{
|
|
}
|
|
|
|
CamHelper::~CamHelper()
|
|
{
|
|
delete parser_;
|
|
}
|
|
|
|
uint32_t CamHelper::ExposureLines(double exposure_us) const
|
|
{
|
|
assert(initialized_);
|
|
return exposure_us * 1000.0 / mode_.line_length;
|
|
}
|
|
|
|
double CamHelper::Exposure(uint32_t exposure_lines) const
|
|
{
|
|
assert(initialized_);
|
|
return exposure_lines * mode_.line_length / 1000.0;
|
|
}
|
|
|
|
uint32_t CamHelper::GetVBlanking(double &exposure, double minFrameDuration,
|
|
double maxFrameDuration) const
|
|
{
|
|
uint32_t frameLengthMin, frameLengthMax, vblank;
|
|
uint32_t exposureLines = ExposureLines(exposure);
|
|
|
|
assert(initialized_);
|
|
|
|
/*
|
|
* minFrameDuration and maxFrameDuration are clamped by the caller
|
|
* based on the limits for the active sensor mode.
|
|
*/
|
|
frameLengthMin = 1e3 * minFrameDuration / mode_.line_length;
|
|
frameLengthMax = 1e3 * maxFrameDuration / mode_.line_length;
|
|
|
|
/*
|
|
* Limit the exposure to the maximum frame duration requested, and
|
|
* re-calculate if it has been clipped.
|
|
*/
|
|
exposureLines = std::min(frameLengthMax - frameIntegrationDiff_, exposureLines);
|
|
exposure = Exposure(exposureLines);
|
|
|
|
/* Limit the vblank to the range allowed by the frame length limits. */
|
|
vblank = std::clamp(exposureLines + frameIntegrationDiff_,
|
|
frameLengthMin, frameLengthMax) - mode_.height;
|
|
return vblank;
|
|
}
|
|
|
|
void CamHelper::SetCameraMode(const CameraMode &mode)
|
|
{
|
|
mode_ = mode;
|
|
parser_->SetBitsPerPixel(mode.bitdepth);
|
|
parser_->SetLineLengthBytes(0); /* We use SetBufferSize. */
|
|
initialized_ = true;
|
|
}
|
|
|
|
void CamHelper::GetDelays(int &exposure_delay, int &gain_delay) const
|
|
{
|
|
/*
|
|
* These values are correct for many sensors. Other sensors will
|
|
* need to over-ride this method.
|
|
*/
|
|
exposure_delay = 2;
|
|
gain_delay = 1;
|
|
}
|
|
|
|
bool CamHelper::SensorEmbeddedDataPresent() const
|
|
{
|
|
return false;
|
|
}
|
|
|
|
unsigned int CamHelper::HideFramesStartup() const
|
|
{
|
|
/*
|
|
* The number of frames when a camera first starts that shouldn't be
|
|
* displayed as they are invalid in some way.
|
|
*/
|
|
return 0;
|
|
}
|
|
|
|
unsigned int CamHelper::HideFramesModeSwitch() const
|
|
{
|
|
/* After a mode switch, many sensors return valid frames immediately. */
|
|
return 0;
|
|
}
|
|
|
|
unsigned int CamHelper::MistrustFramesStartup() const
|
|
{
|
|
/* Many sensors return a single bad frame on start-up. */
|
|
return 1;
|
|
}
|
|
|
|
unsigned int CamHelper::MistrustFramesModeSwitch() const
|
|
{
|
|
/* Many sensors return valid metadata immediately. */
|
|
return 0;
|
|
}
|
|
|
|
RegisterCamHelper::RegisterCamHelper(char const *cam_name,
|
|
CamHelperCreateFunc create_func)
|
|
{
|
|
cam_helpers[std::string(cam_name)] = create_func;
|
|
}
|