The libyuv wrap uses a libyuv commit between versions 1770 and 1772, more than 5 years old. This specifies CMake 2.8 as the minimum required version. The most recent CMake has dropped compatibility with versions older than 3.5 in CMake 4.0. CMake 3.5 was released in 2016, and all distributions we care about ship more recent versions. With CMake 4.0 or newer, shipped for instance by Gentoo, compilation of the libyuv wrap fails. Update the wrap to version 1922, which is the latest numbered version (libyuv doesn't tag release by increases a version number in the README.chromium file). This requires CMake 3.16, released 6 years ago, and available in at least the last two LTS of major distributions. This update introduces two issues. First, due to a bug in Meson (see https://github.com/mesonbuild/meson/issues/10764), PIC handling is broken when a CMake project wraps a static library into another static library that has no additional source file. Work around it by wrapping the libyuv static library again, manually setting 'pic' to true. The second issue is that libyuv fails to compile for armhf platforms that don't support NEON instructions. This is the case on Debian 12 and 13 that ship armhf toolchains with NEON disabled by default. The issue causes CI failures. As the libyuv wrap is a convenience measure, disable NEON optimization on armfd platforms the same way Debian does in its armhf packages. If NEON support is important, the build environment should provide a suitable libyuv. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
8 lines
257 B
Plaintext
8 lines
257 B
Plaintext
# SPDX-License-Identifier: CC0-1.0
|
|
|
|
[wrap-git]
|
|
directory = libyuv
|
|
url = https://chromium.googlesource.com/libyuv/libyuv.git
|
|
revision = 500f45652c459cfccd20f83f297eb66cb7b015cb
|
|
diff_files = libyuv/0004-CMakeLists.txt-Do-not-enable-NEON-for-armel-armhf.patch
|