3335d5a504
Many signals used in internal and public APIs carry the emitter pointer as a signal argument. This was done to allow slots connected to multiple signal instances to differentiate between emitters. While starting from a good intention of facilitating the implementation of slots, it turned out to be a bad API design as the signal isn't meant to know what it will be connected to, and thus shouldn't carry parameters that are solely meant to support a use case specific to the connected slot. These pointers turn out to be unused in all slots but one. In the only case where it is needed, it can be obtained by wrapping the slot in a lambda function when connecting the signal. Do so, and drop the emitter pointer from all signals. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
51 lines
913 B
C++
51 lines
913 B
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* event_notifier.h - File descriptor event notifier
|
|
*/
|
|
#ifndef __LIBCAMERA_BASE_EVENT_NOTIFIER_H__
|
|
#define __LIBCAMERA_BASE_EVENT_NOTIFIER_H__
|
|
|
|
#include <libcamera/base/private.h>
|
|
|
|
#include <libcamera/base/object.h>
|
|
#include <libcamera/base/signal.h>
|
|
|
|
namespace libcamera {
|
|
|
|
class Message;
|
|
|
|
class EventNotifier : public Object
|
|
{
|
|
public:
|
|
enum Type {
|
|
Read,
|
|
Write,
|
|
Exception,
|
|
};
|
|
|
|
EventNotifier(int fd, Type type, Object *parent = nullptr);
|
|
virtual ~EventNotifier();
|
|
|
|
Type type() const { return type_; }
|
|
int fd() const { return fd_; }
|
|
|
|
bool enabled() const { return enabled_; }
|
|
void setEnabled(bool enable);
|
|
|
|
Signal<> activated;
|
|
|
|
protected:
|
|
void message(Message *msg) override;
|
|
|
|
private:
|
|
int fd_;
|
|
Type type_;
|
|
bool enabled_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|
|
|
|
#endif /* __LIBCAMERA_BASE_EVENT_NOTIFIER_H__ */
|