Files
external_libcamera/src/android
Laurent Pinchart a6799dc5b9 hal: Fix comparison of integers of different signs
The CameraHalManager::getCameraInfo() validates the camera id it
receives from the camera service, and in doing so compares it with an
unsigned integer, generating a compiler error:

src/android/camera_hal_manager.cpp:121:9: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
        if (id >= numCameras() || id < 0) {
            ~~ ^  ~~~~~~~~~~~~

Fix this by turning the id into an unsigned int, as camera ids can't be
negative. If a negative id is received from the camera service it will
be converted to a large unsigned integer that will fail the comparison
with numCameras().

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
2019-08-12 15:01:30 +03:00
..
2019-08-12 10:34:13 +02:00
2019-08-12 11:55:46 +02:00
2019-08-12 11:55:46 +02:00
2019-08-12 11:55:46 +02:00
2019-08-12 11:55:46 +02:00
2019-08-12 11:55:46 +02:00
2019-08-12 11:55:46 +02:00
2019-08-12 11:55:46 +02:00