947b8627f9
The RkISP1 can capture raw frames by bypassing the ISP. In that mode, the ISP will not produce statistics nor consume parameters. Most algorithms will thus be unable to run, with one exception: the AGC will still be able to configure the sensor exposure time and analog gain in manual mode. To prepare for this, add the ability to disable algorithms for the duration of the capture session based on the camera configuration. Individual algorithms report whether they support raw formats at construction time, and the IPA module disables algorithms in configure() based on the stream configurations. Disabled algorithms are skipped during the capture session in the processStatsBuffer() operation. As the ISP doesn't produce statistics, don't try to access the stats buffer. There is no need for similar logic in fillParamsBuffer() as that operation won't be called for raw capture. All algorithms report not supporting raw capture by default. Raw support in AGC will be added separately. The feature is implemented in the RkISP1 module without any support from libipa at this point to avoid designing a generic API based on a single user. This may be changed in the future. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
448 lines
13 KiB
C++
448 lines
13 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* rkisp1.cpp - RkISP1 Image Processing Algorithms
|
|
*/
|
|
|
|
#include <algorithm>
|
|
#include <math.h>
|
|
#include <queue>
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
|
|
#include <linux/rkisp1-config.h>
|
|
#include <linux/v4l2-controls.h>
|
|
|
|
#include <libcamera/base/file.h>
|
|
#include <libcamera/base/log.h>
|
|
|
|
#include <libcamera/control_ids.h>
|
|
#include <libcamera/framebuffer.h>
|
|
#include <libcamera/ipa/ipa_interface.h>
|
|
#include <libcamera/ipa/ipa_module_info.h>
|
|
#include <libcamera/ipa/rkisp1_ipa_interface.h>
|
|
#include <libcamera/request.h>
|
|
|
|
#include "libcamera/internal/formats.h"
|
|
#include "libcamera/internal/mapped_framebuffer.h"
|
|
#include "libcamera/internal/yaml_parser.h"
|
|
|
|
#include "algorithms/algorithm.h"
|
|
#include "libipa/camera_sensor_helper.h"
|
|
|
|
#include "ipa_context.h"
|
|
|
|
namespace libcamera {
|
|
|
|
LOG_DEFINE_CATEGORY(IPARkISP1)
|
|
|
|
using namespace std::literals::chrono_literals;
|
|
|
|
namespace ipa::rkisp1 {
|
|
|
|
/* Maximum number of frame contexts to be held */
|
|
static constexpr uint32_t kMaxFrameContexts = 16;
|
|
|
|
class IPARkISP1 : public IPARkISP1Interface, public Module
|
|
{
|
|
public:
|
|
IPARkISP1();
|
|
|
|
int init(const IPASettings &settings, unsigned int hwRevision,
|
|
const IPACameraSensorInfo &sensorInfo,
|
|
const ControlInfoMap &sensorControls,
|
|
ControlInfoMap *ipaControls) override;
|
|
int start() override;
|
|
void stop() override;
|
|
|
|
int configure(const IPAConfigInfo &ipaConfig,
|
|
const std::map<uint32_t, IPAStream> &streamConfig,
|
|
ControlInfoMap *ipaControls) override;
|
|
void mapBuffers(const std::vector<IPABuffer> &buffers) override;
|
|
void unmapBuffers(const std::vector<unsigned int> &ids) override;
|
|
|
|
void queueRequest(const uint32_t frame, const ControlList &controls) override;
|
|
void fillParamsBuffer(const uint32_t frame, const uint32_t bufferId) override;
|
|
void processStatsBuffer(const uint32_t frame, const uint32_t bufferId,
|
|
const ControlList &sensorControls) override;
|
|
|
|
protected:
|
|
std::string logPrefix() const override;
|
|
|
|
private:
|
|
void updateControls(const IPACameraSensorInfo &sensorInfo,
|
|
const ControlInfoMap &sensorControls,
|
|
ControlInfoMap *ipaControls);
|
|
void setControls(unsigned int frame);
|
|
|
|
std::map<unsigned int, FrameBuffer> buffers_;
|
|
std::map<unsigned int, MappedFrameBuffer> mappedBuffers_;
|
|
|
|
ControlInfoMap sensorControls_;
|
|
|
|
/* revision-specific data */
|
|
rkisp1_cif_isp_version hwRevision_;
|
|
unsigned int hwHistBinNMax_;
|
|
unsigned int hwGammaOutMaxSamples_;
|
|
unsigned int hwHistogramWeightGridsSize_;
|
|
|
|
/* Interface to the Camera Helper */
|
|
std::unique_ptr<CameraSensorHelper> camHelper_;
|
|
|
|
/* Local parameter storage */
|
|
struct IPAContext context_;
|
|
};
|
|
|
|
namespace {
|
|
|
|
/* List of controls handled by the RkISP1 IPA */
|
|
const ControlInfoMap::Map rkisp1Controls{
|
|
{ &controls::AeEnable, ControlInfo(false, true) },
|
|
{ &controls::AwbEnable, ControlInfo(false, true) },
|
|
{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },
|
|
{ &controls::Brightness, ControlInfo(-1.0f, 0.993f) },
|
|
{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },
|
|
{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },
|
|
{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },
|
|
{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },
|
|
};
|
|
|
|
} /* namespace */
|
|
|
|
IPARkISP1::IPARkISP1()
|
|
: context_({ {}, {}, { kMaxFrameContexts } })
|
|
{
|
|
}
|
|
|
|
std::string IPARkISP1::logPrefix() const
|
|
{
|
|
return "rkisp1";
|
|
}
|
|
|
|
int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,
|
|
const IPACameraSensorInfo &sensorInfo,
|
|
const ControlInfoMap &sensorControls,
|
|
ControlInfoMap *ipaControls)
|
|
{
|
|
/* \todo Add support for other revisions */
|
|
switch (hwRevision) {
|
|
case RKISP1_V10:
|
|
hwHistBinNMax_ = RKISP1_CIF_ISP_HIST_BIN_N_MAX_V10;
|
|
hwGammaOutMaxSamples_ = RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10;
|
|
hwHistogramWeightGridsSize_ = RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10;
|
|
break;
|
|
case RKISP1_V12:
|
|
hwHistBinNMax_ = RKISP1_CIF_ISP_HIST_BIN_N_MAX_V12;
|
|
hwGammaOutMaxSamples_ = RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V12;
|
|
hwHistogramWeightGridsSize_ = RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V12;
|
|
break;
|
|
default:
|
|
LOG(IPARkISP1, Error)
|
|
<< "Hardware revision " << hwRevision
|
|
<< " is currently not supported";
|
|
return -ENODEV;
|
|
}
|
|
|
|
LOG(IPARkISP1, Debug) << "Hardware revision is " << hwRevision;
|
|
|
|
/* Cache the value to set it in configure. */
|
|
hwRevision_ = static_cast<rkisp1_cif_isp_version>(hwRevision);
|
|
|
|
camHelper_ = CameraSensorHelperFactoryBase::create(settings.sensorModel);
|
|
if (!camHelper_) {
|
|
LOG(IPARkISP1, Error)
|
|
<< "Failed to create camera sensor helper for "
|
|
<< settings.sensorModel;
|
|
return -ENODEV;
|
|
}
|
|
|
|
/* Load the tuning data file. */
|
|
File file(settings.configurationFile);
|
|
if (!file.open(File::OpenModeFlag::ReadOnly)) {
|
|
int ret = file.error();
|
|
LOG(IPARkISP1, Error)
|
|
<< "Failed to open configuration file "
|
|
<< settings.configurationFile << ": " << strerror(-ret);
|
|
return ret;
|
|
}
|
|
|
|
std::unique_ptr<libcamera::YamlObject> data = YamlParser::parse(file);
|
|
if (!data)
|
|
return -EINVAL;
|
|
|
|
unsigned int version = (*data)["version"].get<uint32_t>(0);
|
|
if (version != 1) {
|
|
LOG(IPARkISP1, Error)
|
|
<< "Invalid tuning file version " << version;
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (!data->contains("algorithms")) {
|
|
LOG(IPARkISP1, Error)
|
|
<< "Tuning file doesn't contain any algorithm";
|
|
return -EINVAL;
|
|
}
|
|
|
|
int ret = createAlgorithms(context_, (*data)["algorithms"]);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Initialize controls. */
|
|
updateControls(sensorInfo, sensorControls, ipaControls);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int IPARkISP1::start()
|
|
{
|
|
setControls(0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void IPARkISP1::stop()
|
|
{
|
|
context_.frameContexts.clear();
|
|
}
|
|
|
|
int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,
|
|
const std::map<uint32_t, IPAStream> &streamConfig,
|
|
ControlInfoMap *ipaControls)
|
|
{
|
|
sensorControls_ = ipaConfig.sensorControls;
|
|
|
|
const auto itExp = sensorControls_.find(V4L2_CID_EXPOSURE);
|
|
int32_t minExposure = itExp->second.min().get<int32_t>();
|
|
int32_t maxExposure = itExp->second.max().get<int32_t>();
|
|
|
|
const auto itGain = sensorControls_.find(V4L2_CID_ANALOGUE_GAIN);
|
|
int32_t minGain = itGain->second.min().get<int32_t>();
|
|
int32_t maxGain = itGain->second.max().get<int32_t>();
|
|
|
|
LOG(IPARkISP1, Debug)
|
|
<< "Exposure: [" << minExposure << ", " << maxExposure
|
|
<< "], gain: [" << minGain << ", " << maxGain << "]";
|
|
|
|
/* Clear the IPA context before the streaming session. */
|
|
context_.configuration = {};
|
|
context_.activeState = {};
|
|
context_.frameContexts.clear();
|
|
|
|
/* Set the hardware revision for the algorithms. */
|
|
context_.configuration.hw.revision = hwRevision_;
|
|
|
|
const IPACameraSensorInfo &info = ipaConfig.sensorInfo;
|
|
const ControlInfo vBlank = sensorControls_.find(V4L2_CID_VBLANK)->second;
|
|
context_.configuration.sensor.defVBlank = vBlank.def().get<int32_t>();
|
|
context_.configuration.sensor.size = info.outputSize;
|
|
context_.configuration.sensor.lineDuration = info.minLineLength * 1.0s / info.pixelRate;
|
|
|
|
/* Update the camera controls using the new sensor settings. */
|
|
updateControls(info, sensorControls_, ipaControls);
|
|
|
|
/*
|
|
* When the AGC computes the new exposure values for a frame, it needs
|
|
* to know the limits for shutter speed and analogue gain.
|
|
* As it depends on the sensor, update it with the controls.
|
|
*
|
|
* \todo take VBLANK into account for maximum shutter speed
|
|
*/
|
|
context_.configuration.sensor.minShutterSpeed =
|
|
minExposure * context_.configuration.sensor.lineDuration;
|
|
context_.configuration.sensor.maxShutterSpeed =
|
|
maxExposure * context_.configuration.sensor.lineDuration;
|
|
context_.configuration.sensor.minAnalogueGain = camHelper_->gain(minGain);
|
|
context_.configuration.sensor.maxAnalogueGain = camHelper_->gain(maxGain);
|
|
|
|
context_.configuration.raw = std::any_of(streamConfig.begin(), streamConfig.end(),
|
|
[](auto &cfg) -> bool {
|
|
PixelFormat pixelFormat{ cfg.second.pixelFormat };
|
|
const PixelFormatInfo &format = PixelFormatInfo::info(pixelFormat);
|
|
return format.colourEncoding == PixelFormatInfo::ColourEncodingRAW;
|
|
});
|
|
|
|
for (auto const &a : algorithms()) {
|
|
Algorithm *algo = static_cast<Algorithm *>(a.get());
|
|
|
|
/* Disable algorithms that don't support raw formats. */
|
|
algo->disabled_ = context_.configuration.raw && !algo->supportsRaw_;
|
|
if (algo->disabled_)
|
|
continue;
|
|
|
|
int ret = algo->configure(context_, info);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
void IPARkISP1::mapBuffers(const std::vector<IPABuffer> &buffers)
|
|
{
|
|
for (const IPABuffer &buffer : buffers) {
|
|
auto elem = buffers_.emplace(std::piecewise_construct,
|
|
std::forward_as_tuple(buffer.id),
|
|
std::forward_as_tuple(buffer.planes));
|
|
const FrameBuffer &fb = elem.first->second;
|
|
|
|
MappedFrameBuffer mappedBuffer(&fb, MappedFrameBuffer::MapFlag::ReadWrite);
|
|
if (!mappedBuffer.isValid()) {
|
|
LOG(IPARkISP1, Fatal) << "Failed to mmap buffer: "
|
|
<< strerror(mappedBuffer.error());
|
|
}
|
|
|
|
mappedBuffers_.emplace(buffer.id, std::move(mappedBuffer));
|
|
}
|
|
}
|
|
|
|
void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
|
|
{
|
|
for (unsigned int id : ids) {
|
|
const auto fb = buffers_.find(id);
|
|
if (fb == buffers_.end())
|
|
continue;
|
|
|
|
mappedBuffers_.erase(id);
|
|
buffers_.erase(id);
|
|
}
|
|
}
|
|
|
|
void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
|
|
{
|
|
IPAFrameContext &frameContext = context_.frameContexts.alloc(frame);
|
|
|
|
for (auto const &a : algorithms()) {
|
|
Algorithm *algo = static_cast<Algorithm *>(a.get());
|
|
if (algo->disabled_)
|
|
continue;
|
|
algo->queueRequest(context_, frame, frameContext, controls);
|
|
}
|
|
}
|
|
|
|
void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)
|
|
{
|
|
IPAFrameContext &frameContext = context_.frameContexts.get(frame);
|
|
|
|
rkisp1_params_cfg *params =
|
|
reinterpret_cast<rkisp1_params_cfg *>(
|
|
mappedBuffers_.at(bufferId).planes()[0].data());
|
|
|
|
/* Prepare parameters buffer. */
|
|
memset(params, 0, sizeof(*params));
|
|
|
|
for (auto const &algo : algorithms())
|
|
algo->prepare(context_, frame, frameContext, params);
|
|
|
|
paramsBufferReady.emit(frame);
|
|
}
|
|
|
|
void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId,
|
|
const ControlList &sensorControls)
|
|
{
|
|
IPAFrameContext &frameContext = context_.frameContexts.get(frame);
|
|
|
|
/*
|
|
* In raw capture mode, the ISP is bypassed and no statistics buffer is
|
|
* provided.
|
|
*/
|
|
const rkisp1_stat_buffer *stats = nullptr;
|
|
if (!context_.configuration.raw)
|
|
stats = reinterpret_cast<rkisp1_stat_buffer *>(
|
|
mappedBuffers_.at(bufferId).planes()[0].data());
|
|
|
|
frameContext.sensor.exposure =
|
|
sensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();
|
|
frameContext.sensor.gain =
|
|
camHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>());
|
|
|
|
ControlList metadata(controls::controls);
|
|
|
|
for (auto const &a : algorithms()) {
|
|
Algorithm *algo = static_cast<Algorithm *>(a.get());
|
|
if (algo->disabled_)
|
|
continue;
|
|
algo->process(context_, frame, frameContext, stats, metadata);
|
|
}
|
|
|
|
setControls(frame);
|
|
|
|
metadataReady.emit(frame, metadata);
|
|
}
|
|
|
|
void IPARkISP1::updateControls(const IPACameraSensorInfo &sensorInfo,
|
|
const ControlInfoMap &sensorControls,
|
|
ControlInfoMap *ipaControls)
|
|
{
|
|
ControlInfoMap::Map ctrlMap = rkisp1Controls;
|
|
|
|
/*
|
|
* Compute the frame duration limits.
|
|
*
|
|
* The frame length is computed assuming a fixed line length combined
|
|
* with the vertical frame sizes.
|
|
*/
|
|
const ControlInfo &v4l2HBlank = sensorControls.find(V4L2_CID_HBLANK)->second;
|
|
uint32_t hblank = v4l2HBlank.def().get<int32_t>();
|
|
uint32_t lineLength = sensorInfo.outputSize.width + hblank;
|
|
|
|
const ControlInfo &v4l2VBlank = sensorControls.find(V4L2_CID_VBLANK)->second;
|
|
std::array<uint32_t, 3> frameHeights{
|
|
v4l2VBlank.min().get<int32_t>() + sensorInfo.outputSize.height,
|
|
v4l2VBlank.max().get<int32_t>() + sensorInfo.outputSize.height,
|
|
v4l2VBlank.def().get<int32_t>() + sensorInfo.outputSize.height,
|
|
};
|
|
|
|
std::array<int64_t, 3> frameDurations;
|
|
for (unsigned int i = 0; i < frameHeights.size(); ++i) {
|
|
uint64_t frameSize = lineLength * frameHeights[i];
|
|
frameDurations[i] = frameSize / (sensorInfo.pixelRate / 1000000U);
|
|
}
|
|
|
|
ctrlMap[&controls::FrameDurationLimits] = ControlInfo(frameDurations[0],
|
|
frameDurations[1],
|
|
frameDurations[2]);
|
|
|
|
*ipaControls = ControlInfoMap(std::move(ctrlMap), controls::controls);
|
|
}
|
|
|
|
void IPARkISP1::setControls(unsigned int frame)
|
|
{
|
|
/*
|
|
* \todo The frame number is most likely wrong here, we need to take
|
|
* internal sensor delays and other timing parameters into account.
|
|
*/
|
|
|
|
IPAFrameContext &frameContext = context_.frameContexts.get(frame);
|
|
uint32_t exposure = frameContext.agc.exposure;
|
|
uint32_t gain = camHelper_->gainCode(frameContext.agc.gain);
|
|
|
|
ControlList ctrls(sensorControls_);
|
|
ctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure));
|
|
ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain));
|
|
|
|
setSensorControls.emit(frame, ctrls);
|
|
}
|
|
|
|
} /* namespace ipa::rkisp1 */
|
|
|
|
/*
|
|
* External IPA module interface
|
|
*/
|
|
|
|
extern "C" {
|
|
const struct IPAModuleInfo ipaModuleInfo = {
|
|
IPA_MODULE_API_VERSION,
|
|
1,
|
|
"PipelineHandlerRkISP1",
|
|
"rkisp1",
|
|
};
|
|
|
|
IPAInterface *ipaCreate()
|
|
{
|
|
return new ipa::rkisp1::IPARkISP1();
|
|
}
|
|
}
|
|
|
|
} /* namespace libcamera */
|