Many signals used in internal and public APIs carry the emitter pointer as a signal argument. This was done to allow slots connected to multiple signal instances to differentiate between emitters. While starting from a good intention of facilitating the implementation of slots, it turned out to be a bad API design as the signal isn't meant to know what it will be connected to, and thus shouldn't carry parameters that are solely meant to support a use case specific to the connected slot. These pointers turn out to be unused in all slots but one. In the only case where it is needed, it can be obtained by wrapping the slot in a lambda function when connecting the signal. Do so, and drop the emitter pointer from all signals. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
372 lines
8.0 KiB
C++
372 lines
8.0 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* process.cpp - Process object
|
|
*/
|
|
|
|
#include "libcamera/internal/process.h"
|
|
|
|
#include <algorithm>
|
|
#include <dirent.h>
|
|
#include <fcntl.h>
|
|
#include <iostream>
|
|
#include <list>
|
|
#include <signal.h>
|
|
#include <string.h>
|
|
#include <sys/socket.h>
|
|
#include <sys/types.h>
|
|
#include <sys/wait.h>
|
|
#include <unistd.h>
|
|
#include <vector>
|
|
|
|
#include <libcamera/base/event_notifier.h>
|
|
#include <libcamera/base/log.h>
|
|
#include <libcamera/base/utils.h>
|
|
|
|
/**
|
|
* \file process.h
|
|
* \brief Process object
|
|
*/
|
|
|
|
namespace libcamera {
|
|
|
|
LOG_DEFINE_CATEGORY(Process)
|
|
|
|
/**
|
|
* \class ProcessManager
|
|
* \brief Manager of processes
|
|
*
|
|
* The ProcessManager singleton keeps track of all created Process instances,
|
|
* and manages the signal handling involved in terminating processes.
|
|
*/
|
|
|
|
namespace {
|
|
|
|
void sigact(int signal, siginfo_t *info, void *ucontext)
|
|
{
|
|
#pragma GCC diagnostic push
|
|
#pragma GCC diagnostic ignored "-Wunused-result"
|
|
/*
|
|
* We're in a signal handler so we can't log any message, and we need
|
|
* to continue anyway.
|
|
*/
|
|
char data = 0;
|
|
write(ProcessManager::instance()->writePipe(), &data, sizeof(data));
|
|
#pragma GCC diagnostic pop
|
|
|
|
const struct sigaction &oldsa = ProcessManager::instance()->oldsa();
|
|
if (oldsa.sa_flags & SA_SIGINFO) {
|
|
oldsa.sa_sigaction(signal, info, ucontext);
|
|
} else {
|
|
if (oldsa.sa_handler != SIG_IGN && oldsa.sa_handler != SIG_DFL)
|
|
oldsa.sa_handler(signal);
|
|
}
|
|
}
|
|
|
|
} /* namespace */
|
|
|
|
void ProcessManager::sighandler()
|
|
{
|
|
char data;
|
|
ssize_t ret = read(pipe_[0], &data, sizeof(data));
|
|
if (ret < 0) {
|
|
LOG(Process, Error)
|
|
<< "Failed to read byte from signal handler pipe";
|
|
return;
|
|
}
|
|
|
|
for (auto it = processes_.begin(); it != processes_.end(); ) {
|
|
Process *process = *it;
|
|
|
|
int wstatus;
|
|
pid_t pid = waitpid(process->pid_, &wstatus, WNOHANG);
|
|
if (process->pid_ != pid) {
|
|
++it;
|
|
continue;
|
|
}
|
|
|
|
it = processes_.erase(it);
|
|
process->died(wstatus);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* \brief Register process with process manager
|
|
* \param[in] proc Process to register
|
|
*
|
|
* This function registers the \a proc with the process manager. It
|
|
* shall be called by the parent process after successfully forking, in
|
|
* order to let the parent signal process termination.
|
|
*/
|
|
void ProcessManager::registerProcess(Process *proc)
|
|
{
|
|
processes_.push_back(proc);
|
|
}
|
|
|
|
ProcessManager *ProcessManager::self_ = nullptr;
|
|
|
|
/**
|
|
* \brief Construct a ProcessManager instance
|
|
*
|
|
* The ProcessManager class is meant to only be instantiated once, by the
|
|
* CameraManager.
|
|
*/
|
|
ProcessManager::ProcessManager()
|
|
{
|
|
if (self_)
|
|
LOG(Process, Fatal)
|
|
<< "Multiple ProcessManager objects are not allowed";
|
|
|
|
sigaction(SIGCHLD, NULL, &oldsa_);
|
|
|
|
struct sigaction sa;
|
|
memset(&sa, 0, sizeof(sa));
|
|
sa.sa_sigaction = &sigact;
|
|
memcpy(&sa.sa_mask, &oldsa_.sa_mask, sizeof(sa.sa_mask));
|
|
sigaddset(&sa.sa_mask, SIGCHLD);
|
|
sa.sa_flags = oldsa_.sa_flags | SA_SIGINFO;
|
|
|
|
sigaction(SIGCHLD, &sa, NULL);
|
|
|
|
if (pipe2(pipe_, O_CLOEXEC | O_DIRECT | O_NONBLOCK))
|
|
LOG(Process, Fatal)
|
|
<< "Failed to initialize pipe for signal handling";
|
|
sigEvent_ = new EventNotifier(pipe_[0], EventNotifier::Read);
|
|
sigEvent_->activated.connect(this, &ProcessManager::sighandler);
|
|
|
|
self_ = this;
|
|
}
|
|
|
|
ProcessManager::~ProcessManager()
|
|
{
|
|
sigaction(SIGCHLD, &oldsa_, NULL);
|
|
delete sigEvent_;
|
|
close(pipe_[0]);
|
|
close(pipe_[1]);
|
|
|
|
self_ = nullptr;
|
|
}
|
|
|
|
/**
|
|
* \brief Retrieve the Process manager instance
|
|
*
|
|
* The ProcessManager is constructed by the CameraManager. This function shall
|
|
* be used to retrieve the single instance of the manager.
|
|
*
|
|
* \return The Process manager instance
|
|
*/
|
|
ProcessManager *ProcessManager::instance()
|
|
{
|
|
return self_;
|
|
}
|
|
|
|
/**
|
|
* \brief Retrieve the Process manager's write pipe
|
|
*
|
|
* This function is meant only to be used by the static signal handler.
|
|
*
|
|
* \return Pipe for writing
|
|
*/
|
|
int ProcessManager::writePipe() const
|
|
{
|
|
return pipe_[1];
|
|
}
|
|
|
|
/**
|
|
* \brief Retrive the old signal action data
|
|
*
|
|
* This function is meant only to be used by the static signal handler.
|
|
*
|
|
* \return The old signal action data
|
|
*/
|
|
const struct sigaction &ProcessManager::oldsa() const
|
|
{
|
|
return oldsa_;
|
|
}
|
|
|
|
|
|
/**
|
|
* \class Process
|
|
* \brief Process object
|
|
*
|
|
* The Process class models a process, and simplifies spawning new processes
|
|
* and monitoring the exiting of a process.
|
|
*/
|
|
|
|
/**
|
|
* \enum Process::ExitStatus
|
|
* \brief Exit status of process
|
|
* \var Process::NotExited
|
|
* The process hasn't exited yet
|
|
* \var Process::NormalExit
|
|
* The process exited normally, either via exit() or returning from main
|
|
* \var Process::SignalExit
|
|
* The process was terminated by a signal (this includes crashing)
|
|
*/
|
|
|
|
Process::Process()
|
|
: pid_(-1), running_(false), exitStatus_(NotExited), exitCode_(0)
|
|
{
|
|
}
|
|
|
|
Process::~Process()
|
|
{
|
|
kill();
|
|
/* \todo wait for child process to exit */
|
|
}
|
|
|
|
/**
|
|
* \brief Fork and exec a process, and close fds
|
|
* \param[in] path Path to executable
|
|
* \param[in] args Arguments to pass to executable (optional)
|
|
* \param[in] fds Vector of file descriptors to keep open (optional)
|
|
*
|
|
* Fork a process, and exec the executable specified by path. Prior to
|
|
* exec'ing, but after forking, all file descriptors except for those
|
|
* specified in fds will be closed.
|
|
*
|
|
* All indexes of args will be incremented by 1 before being fed to exec(),
|
|
* so args[0] should not need to be equal to path.
|
|
*
|
|
* \return Zero on successful fork, exec, and closing the file descriptors,
|
|
* or a negative error code otherwise
|
|
*/
|
|
int Process::start(const std::string &path,
|
|
const std::vector<std::string> &args,
|
|
const std::vector<int> &fds)
|
|
{
|
|
int ret;
|
|
|
|
if (running_)
|
|
return 0;
|
|
|
|
int childPid = fork();
|
|
if (childPid == -1) {
|
|
ret = -errno;
|
|
LOG(Process, Error) << "Failed to fork: " << strerror(-ret);
|
|
return ret;
|
|
} else if (childPid) {
|
|
pid_ = childPid;
|
|
ProcessManager::instance()->registerProcess(this);
|
|
|
|
running_ = true;
|
|
|
|
return 0;
|
|
} else {
|
|
if (isolate())
|
|
_exit(EXIT_FAILURE);
|
|
|
|
closeAllFdsExcept(fds);
|
|
|
|
unsetenv("LIBCAMERA_LOG_FILE");
|
|
|
|
const char **argv = new const char *[args.size() + 2];
|
|
unsigned int len = args.size();
|
|
argv[0] = path.c_str();
|
|
for (unsigned int i = 0; i < len; i++)
|
|
argv[i+1] = args[i].c_str();
|
|
argv[len+1] = nullptr;
|
|
|
|
execv(path.c_str(), (char **)argv);
|
|
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
}
|
|
|
|
void Process::closeAllFdsExcept(const std::vector<int> &fds)
|
|
{
|
|
std::vector<int> v(fds);
|
|
sort(v.begin(), v.end());
|
|
|
|
DIR *dir = opendir("/proc/self/fd");
|
|
if (!dir)
|
|
return;
|
|
|
|
int dfd = dirfd(dir);
|
|
|
|
struct dirent *ent;
|
|
while ((ent = readdir(dir)) != nullptr) {
|
|
char *endp;
|
|
int fd = strtoul(ent->d_name, &endp, 10);
|
|
if (*endp)
|
|
continue;
|
|
|
|
if (fd >= 0 && fd != dfd &&
|
|
!std::binary_search(v.begin(), v.end(), fd))
|
|
close(fd);
|
|
}
|
|
|
|
closedir(dir);
|
|
}
|
|
|
|
int Process::isolate()
|
|
{
|
|
int ret = unshare(CLONE_NEWUSER | CLONE_NEWNET);
|
|
if (ret) {
|
|
ret = -errno;
|
|
LOG(Process, Error) << "Failed to unshare execution context: "
|
|
<< strerror(-ret);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* \brief SIGCHLD handler
|
|
* \param[in] wstatus The status as output by waitpid()
|
|
*
|
|
* This function is called when the process associated with Process terminates.
|
|
* It emits the Process::finished signal.
|
|
*/
|
|
void Process::died(int wstatus)
|
|
{
|
|
running_ = false;
|
|
exitStatus_ = WIFEXITED(wstatus) ? NormalExit : SignalExit;
|
|
exitCode_ = exitStatus_ == NormalExit ? WEXITSTATUS(wstatus) : -1;
|
|
|
|
finished.emit(exitStatus_, exitCode_);
|
|
}
|
|
|
|
/**
|
|
* \fn Process::exitStatus()
|
|
* \brief Retrieve the exit status of the process
|
|
*
|
|
* Return the exit status of the process, that is, whether the process
|
|
* has exited via exit() or returning from main, or if the process was
|
|
* terminated by a signal.
|
|
*
|
|
* \sa ExitStatus
|
|
*
|
|
* \return The process exit status
|
|
*/
|
|
|
|
/**
|
|
* \fn Process::exitCode()
|
|
* \brief Retrieve the exit code of the process
|
|
*
|
|
* This function is only valid if exitStatus() returned NormalExit.
|
|
*
|
|
* \return Exit code
|
|
*/
|
|
|
|
/**
|
|
* \var Process::finished
|
|
*
|
|
* Signal that is emitted when the process is confirmed to have terminated.
|
|
*/
|
|
|
|
/**
|
|
* \brief Kill the process
|
|
*
|
|
* Sends SIGKILL to the process.
|
|
*/
|
|
void Process::kill()
|
|
{
|
|
if (pid_ > 0)
|
|
::kill(pid_, SIGKILL);
|
|
}
|
|
|
|
} /* namespace libcamera */
|