Naushir Patuck
aa2fe6a86f
Update CamHelper::getDelays() to return the sensor HBLANK delay. The HBLANK delay is set to the same value as VBLANK delay for all sensors in the Raspberry Pi IPA. Return the HBLANK gain delay from the IPA to the pipeline handler, and initialise DelayedControls to handle V4L2_CID_HBLANK with this delay value. As a drive-by, check that the V4L2_CID_HBLANK control is available when calling IPARPi::configure(). Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Tested-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
110 lines
2.4 KiB
C++
110 lines
2.4 KiB
C++
/* SPDX-License-Identifier: BSD-2-Clause */
|
|
/*
|
|
* Copyright (C) 2019, Raspberry Pi Ltd
|
|
*
|
|
* cam_helper_ov5647.cpp - camera information for ov5647 sensor
|
|
*/
|
|
|
|
#include <assert.h>
|
|
|
|
#include "cam_helper.h"
|
|
|
|
using namespace RPiController;
|
|
|
|
class CamHelperOv5647 : public CamHelper
|
|
{
|
|
public:
|
|
CamHelperOv5647();
|
|
uint32_t gainCode(double gain) const override;
|
|
double gain(uint32_t gainCode) const override;
|
|
void getDelays(int &exposureDelay, int &gainDelay,
|
|
int &vblankDelay, int &hblankDelay) const override;
|
|
unsigned int hideFramesStartup() const override;
|
|
unsigned int hideFramesModeSwitch() const override;
|
|
unsigned int mistrustFramesStartup() const override;
|
|
unsigned int mistrustFramesModeSwitch() const override;
|
|
|
|
private:
|
|
/*
|
|
* Smallest difference between the frame length and integration time,
|
|
* in units of lines.
|
|
*/
|
|
static constexpr int frameIntegrationDiff = 4;
|
|
};
|
|
|
|
/*
|
|
* OV5647 doesn't output metadata, so we have to use the "unicam parser" which
|
|
* works by counting frames.
|
|
*/
|
|
|
|
CamHelperOv5647::CamHelperOv5647()
|
|
: CamHelper({}, frameIntegrationDiff)
|
|
{
|
|
}
|
|
|
|
uint32_t CamHelperOv5647::gainCode(double gain) const
|
|
{
|
|
return static_cast<uint32_t>(gain * 16.0);
|
|
}
|
|
|
|
double CamHelperOv5647::gain(uint32_t gainCode) const
|
|
{
|
|
return static_cast<double>(gainCode) / 16.0;
|
|
}
|
|
|
|
void CamHelperOv5647::getDelays(int &exposureDelay, int &gainDelay,
|
|
int &vblankDelay, int &hblankDelay) const
|
|
{
|
|
/*
|
|
* We run this sensor in a mode where the gain delay is bumped up to
|
|
* 2. It seems to be the only way to make the delays "predictable".
|
|
*/
|
|
exposureDelay = 2;
|
|
gainDelay = 2;
|
|
vblankDelay = 2;
|
|
hblankDelay = 2;
|
|
}
|
|
|
|
unsigned int CamHelperOv5647::hideFramesStartup() const
|
|
{
|
|
/*
|
|
* On startup, we get a couple of under-exposed frames which
|
|
* we don't want shown.
|
|
*/
|
|
return 2;
|
|
}
|
|
|
|
unsigned int CamHelperOv5647::hideFramesModeSwitch() const
|
|
{
|
|
/*
|
|
* After a mode switch, we get a couple of under-exposed frames which
|
|
* we don't want shown.
|
|
*/
|
|
return 2;
|
|
}
|
|
|
|
unsigned int CamHelperOv5647::mistrustFramesStartup() const
|
|
{
|
|
/*
|
|
* First couple of frames are under-exposed and are no good for control
|
|
* algos.
|
|
*/
|
|
return 2;
|
|
}
|
|
|
|
unsigned int CamHelperOv5647::mistrustFramesModeSwitch() const
|
|
{
|
|
/*
|
|
* First couple of frames are under-exposed even after a simple
|
|
* mode switch, and are no good for control algos.
|
|
*/
|
|
return 2;
|
|
}
|
|
|
|
static CamHelper *create()
|
|
{
|
|
return new CamHelperOv5647();
|
|
}
|
|
|
|
static RegisterCamHelper reg("ov5647", &create);
|