Files
external_libcamera/src/libcamera/software_isp/software_isp.cpp
Milan Zamazal 6c17996879 libcamera: ipa_proxy: Report a missing configuration as a warning
When the configuration file for an IPA module is missing, it is reported
as an error in the log, for example:

  ERROR IPAProxy ipa_proxy.cpp:149 Configuration file 'imx219.yaml' not found for IPA module 'simple'

This is misleading because several pipelines use uncalibrated.yaml in
such a case and can continue working.  And in case of software ISP,
there is currently no other configuration file so the error is always
reported.

On the other hand, in some other cases the presence of the configuration
file is required and it is an error if it is missing.

Let's introduce a new optional argument to IPAProxy::configurationFile
that specifies a fallback file if the requested file is not found.  If
the primary requested file is not found and a non-empty fallback file is
specified then a warning is logged and the fallback file is looked up.
If neither the fallback file can be found then only then an error is
logged and the method returns an empty string.  This change has also the
benefit of putting the common fallback file ("uncalibrated.yaml")
pattern to a single place.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
2024-08-01 08:50:36 +01:00

371 lines
9.7 KiB
C++

/* SPDX-License-Identifier: LGPL-2.1-or-later */
/*
* Copyright (C) 2023, Linaro Ltd
*
* Simple software ISP implementation
*/
#include "libcamera/internal/software_isp/software_isp.h"
#include <cmath>
#include <stdint.h>
#include <sys/mman.h>
#include <sys/types.h>
#include <unistd.h>
#include <libcamera/formats.h>
#include <libcamera/stream.h>
#include "libcamera/internal/bayer_format.h"
#include "libcamera/internal/framebuffer.h"
#include "libcamera/internal/ipa_manager.h"
#include "libcamera/internal/mapped_framebuffer.h"
#include "libcamera/internal/software_isp/debayer_params.h"
#include "debayer_cpu.h"
/**
* \file software_isp.cpp
* \brief Simple software ISP implementation
*/
namespace libcamera {
LOG_DEFINE_CATEGORY(SoftwareIsp)
/**
* \class SoftwareIsp
* \brief Class for the Software ISP
*/
/**
* \var SoftwareIsp::inputBufferReady
* \brief A signal emitted when the input frame buffer completes
*/
/**
* \var SoftwareIsp::outputBufferReady
* \brief A signal emitted when the output frame buffer completes
*/
/**
* \var SoftwareIsp::ispStatsReady
* \brief A signal emitted when the statistics for IPA are ready
*/
/**
* \var SoftwareIsp::setSensorControls
* \brief A signal emitted when the values to write to the sensor controls are
* ready
*/
/**
* \brief Constructs SoftwareIsp object
* \param[in] pipe The pipeline handler in use
* \param[in] sensor Pointer to the CameraSensor instance owned by the pipeline
* handler
*/
SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor)
: dmaHeap_(DmaBufAllocator::DmaBufAllocatorFlag::CmaHeap |
DmaBufAllocator::DmaBufAllocatorFlag::SystemHeap |
DmaBufAllocator::DmaBufAllocatorFlag::UDmaBuf)
{
/*
* debayerParams_ must be initialized because the initial value is used for
* the first two frames, i.e. until stats processing starts providing its
* own parameters.
*
* \todo This should be handled in the same place as the related
* operations, in the IPA module.
*/
std::array<uint8_t, 256> gammaTable;
for (unsigned int i = 0; i < 256; i++)
gammaTable[i] = UINT8_MAX * std::pow(i / 256.0, 0.5);
for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {
debayerParams_.red[i] = gammaTable[i];
debayerParams_.green[i] = gammaTable[i];
debayerParams_.blue[i] = gammaTable[i];
}
if (!dmaHeap_.isValid()) {
LOG(SoftwareIsp, Error) << "Failed to create DmaBufAllocator object";
return;
}
sharedParams_ = SharedMemObject<DebayerParams>("softIsp_params");
if (!sharedParams_) {
LOG(SoftwareIsp, Error) << "Failed to create shared memory for parameters";
return;
}
auto stats = std::make_unique<SwStatsCpu>();
if (!stats->isValid()) {
LOG(SoftwareIsp, Error) << "Failed to create SwStatsCpu object";
return;
}
stats->statsReady.connect(this, &SoftwareIsp::statsReady);
debayer_ = std::make_unique<DebayerCpu>(std::move(stats));
debayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);
debayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);
ipa_ = IPAManager::createIPA<ipa::soft::IPAProxySoft>(pipe, 0, 0);
if (!ipa_) {
LOG(SoftwareIsp, Error)
<< "Creating IPA for software ISP failed";
debayer_.reset();
return;
}
/*
* The API tuning file is made from the sensor name. If the tuning file
* isn't found, fall back to the 'uncalibrated' file.
*/
std::string ipaTuningFile =
ipa_->configurationFile(sensor->model() + ".yaml", "uncalibrated.yaml");
int ret = ipa_->init(IPASettings{ ipaTuningFile, sensor->model() },
debayer_->getStatsFD(),
sharedParams_.fd(),
sensor->controls());
if (ret) {
LOG(SoftwareIsp, Error) << "IPA init failed";
debayer_.reset();
return;
}
ipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams);
ipa_->setSensorControls.connect(this, &SoftwareIsp::setSensorCtrls);
debayer_->moveToThread(&ispWorkerThread_);
}
SoftwareIsp::~SoftwareIsp()
{
/* make sure to destroy the DebayerCpu before the ispWorkerThread_ is gone */
debayer_.reset();
}
/**
* \fn int SoftwareIsp::loadConfiguration([[maybe_unused]] const std::string &filename)
* \brief Load a configuration from a file
* \param[in] filename The file to load the configuration data from
*
* Currently is a stub doing nothing and always returning "success".
*
* \return 0 on success
*/
/**
* \brief Process the statistics gathered
* \param[in] sensorControls The sensor controls
*
* Requests the IPA to calculate new parameters for ISP and new control
* values for the sensor.
*/
void SoftwareIsp::processStats(const ControlList &sensorControls)
{
ASSERT(ipa_);
ipa_->processStats(sensorControls);
}
/**
* \brief Check the validity of Software Isp object
* \return True if Software Isp is valid, false otherwise
*/
bool SoftwareIsp::isValid() const
{
return !!debayer_;
}
/**
* \brief Get the output formats supported for the given input format
* \param[in] inputFormat The input format
* \return All the supported output formats or an empty vector if there are none
*/
std::vector<PixelFormat> SoftwareIsp::formats(PixelFormat inputFormat)
{
ASSERT(debayer_);
return debayer_->formats(inputFormat);
}
/**
* \brief Get the supported output sizes for the given input format and size
* \param[in] inputFormat The input format
* \param[in] inputSize The input frame size
* \return The valid size range or an empty range if there are none
*/
SizeRange SoftwareIsp::sizes(PixelFormat inputFormat, const Size &inputSize)
{
ASSERT(debayer_);
return debayer_->sizes(inputFormat, inputSize);
}
/**
* Get the output stride and the frame size in bytes for the given output format and size
* \param[in] outputFormat The output format
* \param[in] size The output size (width and height in pixels)
* \return A tuple of the stride and the frame size in bytes, or a tuple of 0,0
* if there is no valid output config
*/
std::tuple<unsigned int, unsigned int>
SoftwareIsp::strideAndFrameSize(const PixelFormat &outputFormat, const Size &size)
{
ASSERT(debayer_);
return debayer_->strideAndFrameSize(outputFormat, size);
}
/**
* \brief Configure the SoftwareIsp object according to the passed in parameters
* \param[in] inputCfg The input configuration
* \param[in] outputCfgs The output configurations
* \param[in] sensorControls ControlInfoMap of the controls supported by the sensor
* \return 0 on success, a negative errno on failure
*/
int SoftwareIsp::configure(const StreamConfiguration &inputCfg,
const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs,
const ControlInfoMap &sensorControls)
{
ASSERT(ipa_ && debayer_);
int ret = ipa_->configure(sensorControls);
if (ret < 0)
return ret;
return debayer_->configure(inputCfg, outputCfgs);
}
/**
* \brief Export the buffers from the Software ISP
* \param[in] stream Output stream exporting the buffers
* \param[in] count Number of buffers to allocate
* \param[out] buffers Vector to store the allocated buffers
* \return The number of allocated buffers on success or a negative error code
* otherwise
*/
int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,
std::vector<std::unique_ptr<FrameBuffer>> *buffers)
{
ASSERT(debayer_ != nullptr);
/* single output for now */
if (stream == nullptr)
return -EINVAL;
for (unsigned int i = 0; i < count; i++) {
const std::string name = "frame-" + std::to_string(i);
const size_t frameSize = debayer_->frameSize();
FrameBuffer::Plane outPlane;
outPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));
if (!outPlane.fd.isValid()) {
LOG(SoftwareIsp, Error)
<< "failed to allocate a dma_buf";
return -ENOMEM;
}
outPlane.offset = 0;
outPlane.length = frameSize;
std::vector<FrameBuffer::Plane> planes{ outPlane };
buffers->emplace_back(std::make_unique<FrameBuffer>(std::move(planes)));
}
return count;
}
/**
* \brief Queue buffers to Software ISP
* \param[in] input The input framebuffer
* \param[in] outputs The container holding the output stream pointers and
* their respective frame buffer outputs
* \return 0 on success, a negative errno on failure
*/
int SoftwareIsp::queueBuffers(FrameBuffer *input,
const std::map<const Stream *, FrameBuffer *> &outputs)
{
/*
* Validate the outputs as a sanity check: at least one output is
* required, all outputs must reference a valid stream.
*/
if (outputs.empty())
return -EINVAL;
for (auto [stream, buffer] : outputs) {
if (!buffer)
return -EINVAL;
if (outputs.size() != 1) /* only single stream atm */
return -EINVAL;
}
for (auto iter = outputs.begin(); iter != outputs.end(); iter++)
process(input, iter->second);
return 0;
}
/**
* \brief Starts the Software ISP streaming operation
* \return 0 on success, any other value indicates an error
*/
int SoftwareIsp::start()
{
int ret = ipa_->start();
if (ret)
return ret;
ispWorkerThread_.start();
return 0;
}
/**
* \brief Stops the Software ISP streaming operation
*/
void SoftwareIsp::stop()
{
ispWorkerThread_.exit();
ispWorkerThread_.wait();
ipa_->stop();
}
/**
* \brief Passes the input framebuffer to the ISP worker to process
* \param[in] input The input framebuffer
* \param[out] output The framebuffer to write the processed frame to
*/
void SoftwareIsp::process(FrameBuffer *input, FrameBuffer *output)
{
debayer_->invokeMethod(&DebayerCpu::process,
ConnectionTypeQueued, input, output, debayerParams_);
}
void SoftwareIsp::saveIspParams()
{
debayerParams_ = *sharedParams_;
}
void SoftwareIsp::setSensorCtrls(const ControlList &sensorControls)
{
setSensorControls.emit(sensorControls);
}
void SoftwareIsp::statsReady()
{
ispStatsReady.emit();
}
void SoftwareIsp::inputReady(FrameBuffer *input)
{
inputBufferReady.emit(input);
}
void SoftwareIsp::outputReady(FrameBuffer *output)
{
outputBufferReady.emit(output);
}
} /* namespace libcamera */