52cc91f3f1
Presently the colour processing component exposes controls for brightness, saturation, and contrast to the applications which are handled and processed accordingly on the ISP. The implementation lacks reporting the values that are set back to the application. Utilise the new Quantised types to provide the values that were applied to the hardware and report them in the completed request metadata. Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
165 lines
4.1 KiB
C++
165 lines
4.1 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2021-2022, Ideas On Board
|
|
*
|
|
* RkISP1 Color Processing control
|
|
*/
|
|
|
|
#include "cproc.h"
|
|
|
|
#include <algorithm>
|
|
#include <cmath>
|
|
|
|
#include <libcamera/base/log.h>
|
|
|
|
#include <libcamera/control_ids.h>
|
|
|
|
/**
|
|
* \file cproc.h
|
|
*/
|
|
|
|
namespace libcamera {
|
|
|
|
namespace ipa::rkisp1::algorithms {
|
|
|
|
/**
|
|
* \class ColorProcessing
|
|
* \brief RkISP1 Color Processing control
|
|
*
|
|
* The ColorProcessing algorithm is responsible for applying brightness,
|
|
* contrast and saturation corrections. The values are directly provided
|
|
* through requests by the corresponding controls.
|
|
*/
|
|
|
|
LOG_DEFINE_CATEGORY(RkISP1CProc)
|
|
|
|
namespace {
|
|
|
|
constexpr float kDefaultBrightness = 0.0f;
|
|
constexpr float kDefaultContrast = 1.0f;
|
|
constexpr float kDefaultSaturation = 1.0f;
|
|
|
|
} /* namespace */
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::init
|
|
*/
|
|
int ColorProcessing::init(IPAContext &context,
|
|
[[maybe_unused]] const YamlObject &tuningData)
|
|
{
|
|
auto &cmap = context.ctrlMap;
|
|
|
|
cmap[&controls::Brightness] = ControlInfo(-1.0f, 0.993f, kDefaultBrightness);
|
|
cmap[&controls::Contrast] = ControlInfo(0.0f, 1.993f, kDefaultContrast);
|
|
cmap[&controls::Saturation] = ControlInfo(0.0f, 1.993f, kDefaultSaturation);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::configure
|
|
*/
|
|
int ColorProcessing::configure(IPAContext &context,
|
|
[[maybe_unused]] const IPACameraSensorInfo &configInfo)
|
|
{
|
|
auto &cproc = context.activeState.cproc;
|
|
|
|
cproc.brightness = BrightnessQ(kDefaultBrightness);
|
|
cproc.contrast = ContrastQ(kDefaultContrast);
|
|
cproc.saturation = SaturationQ(kDefaultSaturation);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::queueRequest
|
|
*/
|
|
void ColorProcessing::queueRequest(IPAContext &context,
|
|
const uint32_t frame,
|
|
IPAFrameContext &frameContext,
|
|
const ControlList &controls)
|
|
{
|
|
auto &cproc = context.activeState.cproc;
|
|
bool update = false;
|
|
|
|
if (frame == 0)
|
|
update = true;
|
|
|
|
const auto &brightness = controls.get(controls::Brightness);
|
|
if (brightness) {
|
|
BrightnessQ value = *brightness;
|
|
if (cproc.brightness != value) {
|
|
cproc.brightness = value;
|
|
update = true;
|
|
}
|
|
|
|
LOG(RkISP1CProc, Debug) << "Set brightness to " << value;
|
|
}
|
|
|
|
const auto &contrast = controls.get(controls::Contrast);
|
|
if (contrast) {
|
|
ContrastQ value = *contrast;
|
|
if (cproc.contrast != value) {
|
|
cproc.contrast = value;
|
|
update = true;
|
|
}
|
|
|
|
LOG(RkISP1CProc, Debug) << "Set contrast to " << value;
|
|
}
|
|
|
|
const auto saturation = controls.get(controls::Saturation);
|
|
if (saturation) {
|
|
SaturationQ value = *saturation;
|
|
if (cproc.saturation != value) {
|
|
cproc.saturation = value;
|
|
update = true;
|
|
}
|
|
|
|
LOG(RkISP1CProc, Debug) << "Set saturation to " << value;
|
|
}
|
|
|
|
frameContext.cproc.brightness = cproc.brightness;
|
|
frameContext.cproc.contrast = cproc.contrast;
|
|
frameContext.cproc.saturation = cproc.saturation;
|
|
frameContext.cproc.update = update;
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::prepare
|
|
*/
|
|
void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,
|
|
[[maybe_unused]] const uint32_t frame,
|
|
IPAFrameContext &frameContext,
|
|
RkISP1Params *params)
|
|
{
|
|
/* Check if the algorithm configuration has been updated. */
|
|
if (!frameContext.cproc.update)
|
|
return;
|
|
|
|
auto config = params->block<BlockType::Cproc>();
|
|
config.setEnabled(true);
|
|
config->brightness = frameContext.cproc.brightness.quantized();
|
|
config->contrast = frameContext.cproc.contrast.quantized();
|
|
config->sat = frameContext.cproc.saturation.quantized();
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::process
|
|
*/
|
|
void ColorProcessing::process([[maybe_unused]] IPAContext &context,
|
|
[[maybe_unused]] const uint32_t frame,
|
|
IPAFrameContext &frameContext,
|
|
[[maybe_unused]] const rkisp1_stat_buffer *stats,
|
|
ControlList &metadata)
|
|
{
|
|
metadata.set(controls::Brightness, frameContext.cproc.brightness.value());
|
|
metadata.set(controls::Contrast, frameContext.cproc.contrast.value());
|
|
metadata.set(controls::Saturation, frameContext.cproc.saturation.value());
|
|
}
|
|
|
|
REGISTER_IPA_ALGORITHM(ColorProcessing, "ColorProcessing")
|
|
|
|
} /* namespace ipa::rkisp1::algorithms */
|
|
|
|
} /* namespace libcamera */
|