Laurent Pinchart
cb08adffe2
Rework the algorithm's usage of the active state, to store the value of controls for the last queued request in the queueRequest() function, and store a copy of the values in the corresponding frame context. The latter is used in the prepare() function to populate the ISP parameters with values corresponding to the right frame. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
112 lines
2.9 KiB
C++
112 lines
2.9 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2021-2022, Ideas On Board
|
|
*
|
|
* cproc.cpp - RkISP1 Color Processing control
|
|
*/
|
|
|
|
#include "cproc.h"
|
|
|
|
#include <algorithm>
|
|
#include <cmath>
|
|
|
|
#include <libcamera/base/log.h>
|
|
|
|
#include <libcamera/control_ids.h>
|
|
|
|
/**
|
|
* \file cproc.h
|
|
*/
|
|
|
|
namespace libcamera {
|
|
|
|
namespace ipa::rkisp1::algorithms {
|
|
|
|
/**
|
|
* \class ColorProcessing
|
|
* \brief RkISP1 Color Processing control
|
|
*
|
|
* The ColorProcessing algorithm is responsible for applying brightness,
|
|
* contrast and saturation corrections. The values are directly provided
|
|
* through requests by the corresponding controls.
|
|
*/
|
|
|
|
LOG_DEFINE_CATEGORY(RkISP1CProc)
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::queueRequest
|
|
*/
|
|
void ColorProcessing::queueRequest(IPAContext &context,
|
|
[[maybe_unused]] const uint32_t frame,
|
|
IPAFrameContext &frameContext,
|
|
const ControlList &controls)
|
|
{
|
|
auto &cproc = context.activeState.cproc;
|
|
bool update = false;
|
|
|
|
const auto &brightness = controls.get(controls::Brightness);
|
|
if (brightness) {
|
|
int value = std::clamp<int>(std::lround(*brightness * 128), -128, 127);
|
|
if (cproc.brightness != value) {
|
|
cproc.brightness = value;
|
|
update = true;
|
|
}
|
|
|
|
LOG(RkISP1CProc, Debug) << "Set brightness to " << value;
|
|
}
|
|
|
|
const auto &contrast = controls.get(controls::Contrast);
|
|
if (contrast) {
|
|
int value = std::clamp<int>(std::lround(*contrast * 128), 0, 255);
|
|
if (cproc.contrast != value) {
|
|
cproc.contrast = value;
|
|
update = true;
|
|
}
|
|
|
|
LOG(RkISP1CProc, Debug) << "Set contrast to " << value;
|
|
}
|
|
|
|
const auto saturation = controls.get(controls::Saturation);
|
|
if (saturation) {
|
|
int value = std::clamp<int>(std::lround(*saturation * 128), 0, 255);
|
|
if (cproc.saturation != value) {
|
|
cproc.saturation = value;
|
|
update = true;
|
|
}
|
|
|
|
LOG(RkISP1CProc, Debug) << "Set saturation to " << value;
|
|
}
|
|
|
|
frameContext.cproc.brightness = cproc.brightness;
|
|
frameContext.cproc.contrast = cproc.contrast;
|
|
frameContext.cproc.saturation = cproc.saturation;
|
|
frameContext.cproc.update = update;
|
|
}
|
|
|
|
/**
|
|
* \copydoc libcamera::ipa::Algorithm::prepare
|
|
*/
|
|
void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,
|
|
[[maybe_unused]] const uint32_t frame,
|
|
IPAFrameContext &frameContext,
|
|
rkisp1_params_cfg *params)
|
|
{
|
|
/* Check if the algorithm configuration has been updated. */
|
|
if (!frameContext.cproc.update)
|
|
return;
|
|
|
|
params->others.cproc_config.brightness = frameContext.cproc.brightness;
|
|
params->others.cproc_config.contrast = frameContext.cproc.contrast;
|
|
params->others.cproc_config.sat = frameContext.cproc.saturation;
|
|
|
|
params->module_en_update |= RKISP1_CIF_ISP_MODULE_CPROC;
|
|
params->module_ens |= RKISP1_CIF_ISP_MODULE_CPROC;
|
|
params->module_cfg_update |= RKISP1_CIF_ISP_MODULE_CPROC;
|
|
}
|
|
|
|
REGISTER_IPA_ALGORITHM(ColorProcessing, "ColorProcessing")
|
|
|
|
} /* namespace ipa::rkisp1::algorithms */
|
|
|
|
} /* namespace libcamera */
|