626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
57 lines
1.5 KiB
C++
57 lines
1.5 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2021, Google Inc.
|
|
*
|
|
* Interface definition to allocate Frame buffer in
|
|
* platform dependent way.
|
|
*/
|
|
#ifndef __ANDROID_FRAME_BUFFER_ALLOCATOR_H__
|
|
#define __ANDROID_FRAME_BUFFER_ALLOCATOR_H__
|
|
|
|
#include <memory>
|
|
|
|
#include <libcamera/base/class.h>
|
|
|
|
#include <libcamera/camera.h>
|
|
#include <libcamera/geometry.h>
|
|
|
|
#include "hal_framebuffer.h"
|
|
|
|
class CameraDevice;
|
|
|
|
class PlatformFrameBufferAllocator : libcamera::Extensible
|
|
{
|
|
LIBCAMERA_DECLARE_PRIVATE()
|
|
|
|
public:
|
|
explicit PlatformFrameBufferAllocator(CameraDevice *const cameraDevice);
|
|
~PlatformFrameBufferAllocator();
|
|
|
|
/*
|
|
* FrameBuffer owns the underlying buffer. Returns nullptr on failure.
|
|
* Note: The returned FrameBuffer needs to be destroyed before
|
|
* PlatformFrameBufferAllocator is destroyed.
|
|
*/
|
|
std::unique_ptr<HALFrameBuffer> allocate(
|
|
int halPixelFormat, const libcamera::Size &size, uint32_t usage);
|
|
};
|
|
|
|
#define PUBLIC_FRAME_BUFFER_ALLOCATOR_IMPLEMENTATION \
|
|
PlatformFrameBufferAllocator::PlatformFrameBufferAllocator( \
|
|
CameraDevice *const cameraDevice) \
|
|
: Extensible(std::make_unique<Private>(cameraDevice)) \
|
|
{ \
|
|
} \
|
|
PlatformFrameBufferAllocator::~PlatformFrameBufferAllocator() \
|
|
{ \
|
|
} \
|
|
std::unique_ptr<HALFrameBuffer> \
|
|
PlatformFrameBufferAllocator::allocate(int halPixelFormat, \
|
|
const libcamera::Size &size, \
|
|
uint32_t usage) \
|
|
{ \
|
|
return _d()->allocate(halPixelFormat, size, usage); \
|
|
}
|
|
|
|
#endif /* __ANDROID_FRAME_BUFFER_ALLOCATOR_H__ */
|