3335d5a504
Many signals used in internal and public APIs carry the emitter pointer as a signal argument. This was done to allow slots connected to multiple signal instances to differentiate between emitters. While starting from a good intention of facilitating the implementation of slots, it turned out to be a bad API design as the signal isn't meant to know what it will be connected to, and thus shouldn't carry parameters that are solely meant to support a use case specific to the connected slot. These pointers turn out to be unused in all slots but one. In the only case where it is needed, it can be obtained by wrapping the slot in a lambda function when connecting the signal. Do so, and drop the emitter pointer from all signals. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
84 lines
2.0 KiB
C++
84 lines
2.0 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* v4l2_device.h - Common base for V4L2 video devices and subdevices
|
|
*/
|
|
#ifndef __LIBCAMERA_INTERNAL_V4L2_DEVICE_H__
|
|
#define __LIBCAMERA_INTERNAL_V4L2_DEVICE_H__
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include <linux/videodev2.h>
|
|
|
|
#include <libcamera/base/log.h>
|
|
#include <libcamera/base/signal.h>
|
|
#include <libcamera/base/span.h>
|
|
|
|
#include <libcamera/controls.h>
|
|
|
|
namespace libcamera {
|
|
|
|
class EventNotifier;
|
|
|
|
class V4L2Device : protected Loggable
|
|
{
|
|
public:
|
|
void close();
|
|
bool isOpen() const { return fd_ != -1; }
|
|
|
|
const ControlInfoMap &controls() const { return controls_; }
|
|
|
|
ControlList getControls(const std::vector<uint32_t> &ids);
|
|
int setControls(ControlList *ctrls);
|
|
|
|
const struct v4l2_query_ext_ctrl *controlInfo(uint32_t id) const;
|
|
|
|
const std::string &deviceNode() const { return deviceNode_; }
|
|
std::string devicePath() const;
|
|
|
|
int setFrameStartEnabled(bool enable);
|
|
Signal<uint32_t> frameStart;
|
|
|
|
void updateControlInfo();
|
|
|
|
protected:
|
|
V4L2Device(const std::string &deviceNode);
|
|
~V4L2Device();
|
|
|
|
int open(unsigned int flags);
|
|
int setFd(int fd);
|
|
|
|
int ioctl(unsigned long request, void *argp);
|
|
|
|
int fd() const { return fd_; }
|
|
|
|
private:
|
|
static ControlType v4l2CtrlType(uint32_t ctrlType);
|
|
static std::unique_ptr<ControlId> v4l2ControlId(const v4l2_query_ext_ctrl &ctrl);
|
|
ControlInfo v4l2ControlInfo(const v4l2_query_ext_ctrl &ctrl);
|
|
ControlInfo v4l2MenuControlInfo(const v4l2_query_ext_ctrl &ctrl);
|
|
|
|
void listControls();
|
|
void updateControls(ControlList *ctrls,
|
|
Span<const v4l2_ext_control> v4l2Ctrls);
|
|
|
|
void eventAvailable();
|
|
|
|
std::map<unsigned int, struct v4l2_query_ext_ctrl> controlInfo_;
|
|
std::vector<std::unique_ptr<ControlId>> controlIds_;
|
|
ControlIdMap controlIdMap_;
|
|
ControlInfoMap controls_;
|
|
std::string deviceNode_;
|
|
int fd_;
|
|
|
|
EventNotifier *fdEventNotifier_;
|
|
bool frameStartEnabled_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|
|
|
|
#endif /* __LIBCAMERA_INTERNAL_V4L2_DEVICE_H__ */
|