25b254fe61
Even though there is an abstract class to represent the interface of an IPA, the threaded and IPC versions are still multiplexed using the same type, which uses a boolean to actually dispatch to the right function. Instead of doing that, split the classes into "threaded" and "isolated" variants, and make `IPAManager` choose accordingly. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
90 lines
2.0 KiB
C++
90 lines
2.0 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* Image Processing Algorithm module manager
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <stdint.h>
|
|
#include <vector>
|
|
|
|
#include <libcamera/base/log.h>
|
|
|
|
#include <libcamera/ipa/ipa_interface.h>
|
|
#include <libcamera/ipa/ipa_module_info.h>
|
|
|
|
#include "libcamera/internal/camera_manager.h"
|
|
#include "libcamera/internal/global_configuration.h"
|
|
#include "libcamera/internal/ipa_module.h"
|
|
#include "libcamera/internal/pipeline_handler.h"
|
|
#include "libcamera/internal/pub_key.h"
|
|
|
|
namespace libcamera {
|
|
|
|
LOG_DECLARE_CATEGORY(IPAManager)
|
|
|
|
class IPAManager
|
|
{
|
|
public:
|
|
IPAManager(const GlobalConfiguration &configuration);
|
|
~IPAManager();
|
|
|
|
template<typename T>
|
|
static std::unique_ptr<T> createIPA(PipelineHandler *pipe,
|
|
uint32_t minVersion,
|
|
uint32_t maxVersion)
|
|
{
|
|
CameraManager *cm = pipe->cameraManager();
|
|
IPAManager *self = cm->_d()->ipaManager();
|
|
IPAModule *m = self->module(pipe, minVersion, maxVersion);
|
|
if (!m)
|
|
return nullptr;
|
|
|
|
const GlobalConfiguration &configuration = cm->_d()->configuration();
|
|
|
|
auto proxy = [&]() -> std::unique_ptr<T> {
|
|
if (self->isSignatureValid(m))
|
|
return std::make_unique<typename T::Threaded>(m, configuration);
|
|
else
|
|
return std::make_unique<typename T::Isolated>(m, configuration);
|
|
}();
|
|
|
|
if (!proxy->isValid()) {
|
|
LOG(IPAManager, Error) << "Failed to load proxy";
|
|
return nullptr;
|
|
}
|
|
|
|
return proxy;
|
|
}
|
|
|
|
#if HAVE_IPA_PUBKEY
|
|
static const PubKey &pubKey()
|
|
{
|
|
return pubKey_;
|
|
}
|
|
#endif
|
|
|
|
private:
|
|
void parseDir(const char *libDir, unsigned int maxDepth,
|
|
std::vector<std::string> &files);
|
|
unsigned int addDir(const char *libDir, unsigned int maxDepth = 0);
|
|
|
|
IPAModule *module(PipelineHandler *pipe, uint32_t minVersion,
|
|
uint32_t maxVersion);
|
|
|
|
bool isSignatureValid(IPAModule *ipa) const;
|
|
|
|
std::vector<std::unique_ptr<IPAModule>> modules_;
|
|
|
|
#if HAVE_IPA_PUBKEY
|
|
static const uint8_t publicKeyData_[];
|
|
static const PubKey pubKey_;
|
|
bool forceIsolation_;
|
|
#endif
|
|
};
|
|
|
|
} /* namespace libcamera */
|