0eacde623b
Template argument deduction results in the lvalue and lvalue reference arguments to the invokeMethod() function causing deduction of the Args template type to a non-reference type. This results in the argument being passed by value and copied. Fix this by using a cv-unqualified rvalue reference parameter type. The type is then deduced to an lvalue reference when the argument is an lvalue or lvalue reference, due to a combination of the special template argument deduction rule for rvalue reference parameter types: If P is an rvalue reference to a cv-unqualified template parameter (so-called forwarding reference), and the corresponding function call argument is an lvalue, the type lvalue reference to A is used in place of A for deduction. (https://en.cppreference.com/w/cpp/language/template_argument_deduction) and the reference collapsing rule (https://en.cppreference.com/w/cpp/language/reference#Reference_collapsing). Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
70 lines
1.4 KiB
C++
70 lines
1.4 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* object.h - Base object
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <list>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include <libcamera/base/bound_method.h>
|
|
|
|
namespace libcamera {
|
|
|
|
class Message;
|
|
template<typename... Args>
|
|
class Signal;
|
|
class SignalBase;
|
|
class Thread;
|
|
|
|
class Object
|
|
{
|
|
public:
|
|
Object(Object *parent = nullptr);
|
|
virtual ~Object();
|
|
|
|
void deleteLater();
|
|
|
|
void postMessage(std::unique_ptr<Message> msg);
|
|
|
|
template<typename T, typename R, typename... FuncArgs, typename... Args,
|
|
typename std::enable_if_t<std::is_base_of<Object, T>::value> * = nullptr>
|
|
R invokeMethod(R (T::*func)(FuncArgs...), ConnectionType type,
|
|
Args&&... args)
|
|
{
|
|
T *obj = static_cast<T *>(this);
|
|
auto *method = new BoundMethodMember<T, R, FuncArgs...>(obj, this, func, type);
|
|
return method->activate(args..., true);
|
|
}
|
|
|
|
Thread *thread() const { return thread_; }
|
|
void moveToThread(Thread *thread);
|
|
|
|
Object *parent() const { return parent_; }
|
|
|
|
protected:
|
|
virtual void message(Message *msg);
|
|
|
|
private:
|
|
friend class SignalBase;
|
|
friend class Thread;
|
|
|
|
void notifyThreadMove();
|
|
|
|
void connect(SignalBase *signal);
|
|
void disconnect(SignalBase *signal);
|
|
|
|
Object *parent_;
|
|
std::vector<Object *> children_;
|
|
|
|
Thread *thread_;
|
|
std::list<SignalBase *> signals_;
|
|
unsigned int pendingMessages_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|