Jacopo Mondi
855228f7d5
The RkISP1 implementation of IPA::configure() still uses the legacy interface where sensor controls (and eventually lens controls) are passed from the pipeline handler to the IPA in a map. Since the introduction of mojom-based IPA interface definition, it is possible to define custom data types and use them in the interface definition between the pipeline handler and the IPA. Align the RkISP1 IPA::configure() implementation with the one in the IPU3 IPA module by using a custom data type instead of relying on a map to pass controls to the IPA. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
41 lines
1.1 KiB
Plaintext
41 lines
1.1 KiB
Plaintext
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
/*
|
|
* \todo Document the interface and remove the related EXCLUDE_PATTERNS entry.
|
|
*/
|
|
|
|
module ipa.rkisp1;
|
|
|
|
import "include/libcamera/ipa/core.mojom";
|
|
|
|
struct IPAConfigInfo {
|
|
libcamera.IPACameraSensorInfo sensorInfo;
|
|
libcamera.ControlInfoMap sensorControls;
|
|
};
|
|
|
|
interface IPARkISP1Interface {
|
|
init(libcamera.IPASettings settings,
|
|
uint32 hwRevision)
|
|
=> (int32 ret, libcamera.ControlInfoMap ipaControls);
|
|
start() => (int32 ret);
|
|
stop();
|
|
|
|
configure(IPAConfigInfo configInfo,
|
|
map<uint32, libcamera.IPAStream> streamConfig)
|
|
=> (int32 ret);
|
|
|
|
mapBuffers(array<libcamera.IPABuffer> buffers);
|
|
unmapBuffers(array<uint32> ids);
|
|
|
|
[async] queueRequest(uint32 frame, libcamera.ControlList reqControls);
|
|
[async] fillParamsBuffer(uint32 frame, uint32 bufferId);
|
|
[async] processStatsBuffer(uint32 frame, uint32 bufferId,
|
|
libcamera.ControlList sensorControls);
|
|
};
|
|
|
|
interface IPARkISP1EventInterface {
|
|
paramsBufferReady(uint32 frame);
|
|
setSensorControls(uint32 frame, libcamera.ControlList sensorControls);
|
|
metadataReady(uint32 frame, libcamera.ControlList metadata);
|
|
};
|