PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: controls: Expose string controls as std::string_view

Browse Source 
When retrieving the value from a `ControlValue` usually one of two
things happen: a small, trivially copyable object is returned by
value; or a view into the internal buffer is provided. This is true
for everything except strings, which are returned in `std::string`,
incurring the overhead of string construction.

To guarantee no potentially "expensive" copies, use `std::string_view`
pointing to the internal buffer to return the value. This is similar
to how other array-like types are returned with a `Span<>`.

This is an API break, but its scope is limited to just `properties::Model`.

Bug: https://bugs.libcamera.org/show_bug.cgi?id=256
Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze
2025-04-16 13:57:06 +02:00
parent b320b20db7
commit f84522d7cd
9 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/qcam/cam_select_dialog.cpp
+2 -2
View File
@@ -114,8 +114,8 @@ void CameraSelectorDialog::updateCameraInfo(QString cameraId)
cameraLocation_->setText("Unknown");
}
const auto &model = properties.get(libcamera::properties::Model)
const auto model = properties.get(libcamera::properties::Model)
.value_or("Unknown");
cameraModel_->setText(QString::fromStdString(model));
cameraModel_->setText(QString::fromUtf8(model.data(), model.length()));
}