From f7417c38e47d6b6eb0e9ce6a35847b2c8060aa78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Thu, 15 Jan 2026 12:05:37 +0100 Subject: [PATCH] ipa: rpi: Fix printing of `utils::Duration` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `utils::Duration` derives from `std::chrono::duration<...>`, but multiplying it yields an `std::chrono::duration<...>`, not `Duration`. chrono duration types only have `operator<<` in C++20 or later, so this usage should not compile. It only did so because the `operator<<` for `Duration` was in the `libcamera` namespace and `Duration` has an implicit constructor from any chrono duration type. This will cease to work when that operator is moved into the `utils` namespace for ADL purposes. So fix it by making the cast to `Duration` explicit. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Naushir Patuck --- src/ipa/rpi/common/ipa_base.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 32269498..7072b38c 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -604,7 +604,7 @@ void IpaBase::setMode(const IPACameraSensorInfo &sensorInfo) mode_.minLineLength = adjustedLineLength; } else { LOG(IPARPI, Error) - << "Sensor minimum line length of " << pixelTime * mode_.width + << "Sensor minimum line length of " << Duration(pixelTime * mode_.width) << " (" << 1us / pixelTime << " MPix/s)" << " is below the minimum allowable ISP limit of " << adjustedLineLength